| Message ID | 1456359089-19807-2-git-send-email-dbasehore@chromium.org (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
On 25 February 2016 at 01:11, Derek Basehore <dbasehore@chromium.org> wrote: > This tries to runtime suspend devices that are still active for direct > complete. This is for cases such as autosuspend delays which leaves > devices able to runtime suspend but still active. It's beneficial in > this case to runtime suspend the device to take advantage of direct > complete when possible. Unfortunate this doesn't work. In the device_prepare() phase the PM core prevents runtime suspend via a call to pm_runtime_get_noresume(). Kind regards Uffe > > Signed-off-by: Derek Basehore <dbasehore@chromium.org> > Reviewed-by: Eric Caruso <ejcaruso@chromium.org> > --- > drivers/base/power/main.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c > index e0017d9..9693032 100644 > --- a/drivers/base/power/main.c > +++ b/drivers/base/power/main.c > @@ -1380,7 +1380,12 @@ static int __device_suspend(struct device *dev, pm_message_t state, bool async) > goto Complete; > > if (dev->power.direct_complete) { > - if (pm_runtime_status_suspended(dev)) { > + /* > + * Check if we're runtime suspended. If not, try to runtime > + * suspend for autosuspend cases. > + */ > + if (pm_runtime_status_suspended(dev) || > + !pm_runtime_suspend(dev)) { > pm_runtime_disable(dev); > if (pm_runtime_status_suspended(dev)) > goto Complete; > -- > 2.7.0.rc3.207.g0ac5344 > -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2 March 2016 at 09:31, dbasehore . <dbasehore@chromium.org> wrote: > > On Mar 1, 2016 12:41, "Ulf Hansson" <ulf.hansson@linaro.org> wrote: >> >> On 25 February 2016 at 01:11, Derek Basehore <dbasehore@chromium.org> >> wrote: >> > This tries to runtime suspend devices that are still active for direct >> > complete. This is for cases such as autosuspend delays which leaves >> > devices able to runtime suspend but still active. It's beneficial in >> > this case to runtime suspend the device to take advantage of direct >> > complete when possible. >> >> Unfortunate this doesn't work. In the device_prepare() phase the PM >> core prevents runtime suspend via a call to pm_runtime_get_noresume(). >> >> Kind regards >> Uffe >> > > A call to pm_runtime_put_sync_suspend should work. We can't do this > earlier, because we don't know if the device will actually use > direct_complete due to its children. Calling pm_runtime_put_noidle may > allow another pm_runtime_put to runtime suspend the device, but we're > trying to do that anyways. Also, we can't just call ...put_sync since that > might not suspend due to autosuspend delays. > > We just need to balance the call with another get_noresume after. Am I > missing anything? Yes. The important part that you need to take into consideration is the sysfs intererface for runtime PM of devices. It allows userspace to prevent runtime PM suspend (pm_runtime_forbid()). Therefore, you simply can not rely on the regular runtime PM APIs to put a device into low power state during system PM. In cases of a runtime PM centric subsystem/driver, it can instead use pm_runtime_force_suspend(). Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c index e0017d9..9693032 100644 --- a/drivers/base/power/main.c +++ b/drivers/base/power/main.c @@ -1380,7 +1380,12 @@ static int __device_suspend(struct device *dev, pm_message_t state, bool async) goto Complete; if (dev->power.direct_complete) { - if (pm_runtime_status_suspended(dev)) { + /* + * Check if we're runtime suspended. If not, try to runtime + * suspend for autosuspend cases. + */ + if (pm_runtime_status_suspended(dev) || + !pm_runtime_suspend(dev)) { pm_runtime_disable(dev); if (pm_runtime_status_suspended(dev)) goto Complete;