From patchwork Sat Apr 23 23:34:25 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eduardo Valentin X-Patchwork-Id: 8919171 X-Patchwork-Delegate: rui.zhang@intel.com Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id AA9D3BF29F for ; Sat, 23 Apr 2016 23:36:39 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DFE0A20219 for ; Sat, 23 Apr 2016 23:36:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 09101201FA for ; Sat, 23 Apr 2016 23:36:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752621AbcDWXe4 (ORCPT ); Sat, 23 Apr 2016 19:34:56 -0400 Received: from mail-pa0-f43.google.com ([209.85.220.43]:34943 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752604AbcDWXey (ORCPT ); Sat, 23 Apr 2016 19:34:54 -0400 Received: by mail-pa0-f43.google.com with SMTP id iv1so2896883pac.2; Sat, 23 Apr 2016 16:34:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=oW2VRTI/cpWCvlTaQyIGpGw9BtABK7sxh0riAl+ZuKo=; b=zK7OI8DGggvhmr+TOZKweozkfPs3LePpPMQH+kuO19mZO2tiNrOyF1v+xo76EfUqQa kyKt07vYT9sCbPPxi0ehTYwQMPixC6ySTFfuygn8m6SCiRCrLLy60cF1fXLGSaSPjDlQ 5B9uZ+a41kRkrLcF9z/cpxBE0jTPy8vWZMS2t+4kwRrKAGMx8hviabA3Lq3BXMBxMgkW Wzb1JmYhPr3zjtuMkG7xjzLvvHw7ddKK80doBFSnZSCK4A0IxKeL6eGcQ8kMFDUrH79O xhBs5WoNiNNRp3S4WhCk6Lv2Hif17+DQiJZs8w7i4BPm5HNRCyCw3jgBEjwuHes6BdL4 qbrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=oW2VRTI/cpWCvlTaQyIGpGw9BtABK7sxh0riAl+ZuKo=; b=TSPH0qnFcFIu2sr0GK2rS0wl+/HX/vGxEd7dRRmI3MFgVZM/5kIlBfypvx73aNj5pb l0JQZVCdA6kxonIpsqbtML//lbRPytfYjbF0Sec3FnXKfGJZnzTS7seVkd3pbzHs418b mU8fGdegS/9pbnDMsfHFvwUI1UVnY8z1E3PvZFvkuDbk/JnLAlbIJVsYISuUnzKhcWb+ numJRG9FkpgQyKkUc3mti+yeMklcZ0HUvgFlmQyoe13/FHp20eE6v1DtHjbpj1rUX0P+ KQMPresoXr22O+ph/6hBk+ztCQ1hcbQJcQP3QTdmwNmaYiLQwtv3Bc3hM9rDEeVlXPvI CgRw== X-Gm-Message-State: AOPr4FXbgTUGDLIuQdCbXbhR+36ce4LXekHZ2R4jSASKyflVWYCjiydVydquwAEO/zR6mQ== X-Received: by 10.66.236.232 with SMTP id ux8mr38853477pac.145.1461454493321; Sat, 23 Apr 2016 16:34:53 -0700 (PDT) Received: from localhost ([2601:647:4203:c8e0:7256:81ff:febd:926d]) by smtp.gmail.com with ESMTPSA id qm10sm18761276pac.33.2016.04.23.16.34.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 23 Apr 2016 16:34:52 -0700 (PDT) From: Eduardo Valentin To: Rui Zhang Cc: Linux PM , LKML , Eduardo Valentin Subject: [RFC PATCH 06/11] thermal: move mode attribute to tz->device.groups Date: Sat, 23 Apr 2016 16:34:25 -0700 Message-Id: <1461454470-27714-7-git-send-email-edubezval@gmail.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1461454470-27714-1-git-send-email-edubezval@gmail.com> References: <1461454470-27714-1-git-send-email-edubezval@gmail.com> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Moving mode attribute to tz->device.groups requires the implementation of a .is_visible() callback. The condition returned by .is_visible() of the mode attribute group is kept the same, we allow the attribute to be visible only if ops->get_mode() is set by the thermal driver. Cc: Zhang Rui Cc: linux-pm@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin --- drivers/thermal/thermal_core.c | 35 +++++++++++++++++++++++++++-------- 1 file changed, 27 insertions(+), 8 deletions(-) diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c index e32f851..6e44038 100644 --- a/drivers/thermal/thermal_core.c +++ b/drivers/thermal/thermal_core.c @@ -1006,6 +1006,7 @@ static DEVICE_ATTR(sustainable_power, S_IWUSR | S_IRUGO, sustainable_power_show, static DEVICE_ATTR(mode, 0644, mode_show, mode_store); static DEVICE_ATTR(passive, S_IRUGO | S_IWUSR, passive_show, passive_store); +/* These attributes are unconditionally added to a thermal zone */ static struct attribute *thermal_zone_dev_attrs[] = { &dev_attr_type.attr, &dev_attr_temp.attr, @@ -1028,8 +1029,34 @@ static struct attribute_group thermal_zone_attribute_group = { .attrs = thermal_zone_dev_attrs, }; +/* We expose mode only if .get_mode is present */ +static struct attribute *thermal_zone_mode_attrs[] = { + &dev_attr_mode.attr, +}; + +static umode_t thermal_zone_mode_is_visible(struct kobject *kobj, + struct attribute *attr, + int attrno) +{ + struct device *dev = container_of(kobj, struct device, kobj); + struct thermal_zone_device *tz; + + tz = container_of(dev, struct thermal_zone_device, device); + + if (tz->ops->get_mode) + return attr->mode; + + return 0; +} + +static struct attribute_group thermal_zone_mode_attribute_group = { + .attrs = thermal_zone_mode_attrs, + .is_visible = thermal_zone_mode_is_visible, +}; + static const struct attribute_group *thermal_zone_attribute_groups[] = { &thermal_zone_attribute_group, + &thermal_zone_mode_attribute_group, NULL }; @@ -1868,12 +1895,6 @@ struct thermal_zone_device *thermal_zone_device_register(const char *type, } /* sys I/F */ - if (ops->get_mode) { - result = device_create_file(&tz->device, &dev_attr_mode); - if (result) - goto unregister; - } - result = create_trip_attrs(tz, mask); if (result) goto unregister; @@ -1990,8 +2011,6 @@ void thermal_zone_device_unregister(struct thermal_zone_device *tz) thermal_zone_device_set_polling(tz, 0); - if (tz->ops->get_mode) - device_remove_file(&tz->device, &dev_attr_mode); remove_trip_attrs(tz); thermal_set_governor(tz, NULL);