diff mbox

[2/2] powercap/rapl: reduce warning level

Message ID 1464021943-14915-3-git-send-email-jacob.jun.pan@linux.intel.com (mailing list archive)
State Accepted, archived
Delegated to: Rafael Wysocki
Headers show

Commit Message

Jacob Pan May 23, 2016, 4:45 p.m. UTC
Since RAPL interface is not architectual, its enumeration depends on poking
MSRs instead of using CPUID method.

In KVM guest, RAPL driver probe will fail and emit the following message
for every CPU: no valid rapl domains found in package

This patch limit the warning to debug only. Still return ENODEV so that RAPL
does not run on KVM guest.

Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
---
 drivers/powercap/intel_rapl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Rafael J. Wysocki June 16, 2016, 2:01 p.m. UTC | #1
On Monday, May 23, 2016 09:45:43 AM Jacob Pan wrote:
> Since RAPL interface is not architectual, its enumeration depends on poking
> MSRs instead of using CPUID method.
> 
> In KVM guest, RAPL driver probe will fail and emit the following message
> for every CPU: no valid rapl domains found in package
> 
> This patch limit the warning to debug only. Still return ENODEV so that RAPL
> does not run on KVM guest.
> 
> Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>

Applied, thanks!

--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/powercap/intel_rapl.c b/drivers/powercap/intel_rapl.c
index a417e68..b0a2dc4 100644
--- a/drivers/powercap/intel_rapl.c
+++ b/drivers/powercap/intel_rapl.c
@@ -1324,7 +1324,7 @@  static int rapl_detect_domains(struct rapl_package *rp, int cpu)
 	}
 	rp->nr_domains = bitmap_weight(&rp->domain_map,	RAPL_DOMAIN_MAX);
 	if (!rp->nr_domains) {
-		pr_err("no valid rapl domains found in package %d\n", rp->id);
+		pr_debug("no valid rapl domains found in package %d\n", rp->id);
 		ret = -ENODEV;
 		goto done;
 	}