From patchwork Wed May 25 03:47:48 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Caesar Wang X-Patchwork-Id: 9134653 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 246AE60221 for ; Wed, 25 May 2016 03:49:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 180002810D for ; Wed, 25 May 2016 03:49:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0CA482825C; Wed, 25 May 2016 03:49:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8696E2810D for ; Wed, 25 May 2016 03:49:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755350AbcEYDst (ORCPT ); Tue, 24 May 2016 23:48:49 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:33749 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756053AbcEYDsT (ORCPT ); Tue, 24 May 2016 23:48:19 -0400 Received: by mail-pf0-f193.google.com with SMTP id b124so3542792pfb.0; Tue, 24 May 2016 20:48:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=QFdOIhAqEkZixD7ZNYxMITd60tksJIQajwRt8XuWXMY=; b=l80ls0dIBlgEHccagGJ7vF4C1Qi5vvgcbR50N0+Waq+V8oKanGoOfS0n1ydyIbjuNO O86xHzersma0ciizk78YLkIAl+bkYDqh6QfCuvh8zv411WsO172aHphRRAg9j+y0oj8S TVUAg85q3riIktQd1wyGDSQBsoIVROC1Yy97wY1u0yesO+sdYydbmbzqBrHJoiss6FBk yMxB3MfaOL3hGsVGbClxTXyZdXk1DkHvWrMPQwNotvzZgL2eCLtkI7h0j2FH2rGX7wy3 A0rai+V5WaqH6bI9deFGnO4T5W1W6neqtFjhNFqrWF72sQTbgbIbVmRduWnOjj2STGG1 YGQQ== X-Gm-Message-State: ALyK8tL0EhS75Cb8mhILZFaf0BbNQoXgIt8g/QB/GIIJG/BiGkrpDukXrPuorR2Mj/esDA== X-Received: by 10.98.104.133 with SMTP id d127mr2519190pfc.112.1464148098506; Tue, 24 May 2016 20:48:18 -0700 (PDT) Received: from localhost.localdomain ([103.29.142.67]) by smtp.gmail.com with ESMTPSA id u127sm57645436pfb.82.2016.05.24.20.48.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 24 May 2016 20:48:17 -0700 (PDT) From: Caesar Wang To: edubezval@gmail.com, linux-pm@vger.kernel.org Cc: Heiko Stuebner , dianders@chromium.org, briannorris@google.com, smbarber@google.com, linux-rockchip@lists.infradead.org, cf@rock-chips.com, huangtao@rock-chips.com, dmitry.torokhov@gmail.com, javi.merino@arm.com, peter@piie.net, Sascha Hauer , Caesar Wang , Zhang Rui , linux-kernel@vger.kernel.org Subject: [PATCH v3 4/5] thermal: bang-bang governor: act on lower trip boundary Date: Wed, 25 May 2016 11:47:48 +0800 Message-Id: <1464148069-26254-5-git-send-email-wxt@rock-chips.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1464148069-26254-1-git-send-email-wxt@rock-chips.com> References: <1464148069-26254-1-git-send-email-wxt@rock-chips.com> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Sascha Hauer With interrupt driven thermal zones we pass the lower and upper temperature on which shall be acted, so in the governor we have to act on the exact lower temperature to be consistent. Otherwise an interrupt maybe generated on the exact lower temperature, but the bang bang governor does not react since The polling driven zones have to be one step cooler before the governor reacts. Signed-off-by: Sascha Hauer Signed-off-by: Caesar Wang Cc: Zhang Rui Cc: Eduardo Valentin Cc: linux-pm@vger.kernel.org Acked-by: Peter Feuerer --- Changes in v3: - Add the peter's ACK. Changes in v2: - Update the commit for patch[v2 4/5]. drivers/thermal/gov_bang_bang.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/gov_bang_bang.c b/drivers/thermal/gov_bang_bang.c index 70836c5..9d1dfea 100644 --- a/drivers/thermal/gov_bang_bang.c +++ b/drivers/thermal/gov_bang_bang.c @@ -59,7 +59,7 @@ static void thermal_zone_trip_update(struct thermal_zone_device *tz, int trip) if (instance->target == 0 && tz->temperature >= trip_temp) instance->target = 1; else if (instance->target == 1 && - tz->temperature < trip_temp - trip_hyst) + tz->temperature <= trip_temp - trip_hyst) instance->target = 0; dev_dbg(&instance->cdev->device, "target=%d\n",