From patchwork Tue May 31 06:31:31 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eduardo Valentin X-Patchwork-Id: 9143527 X-Patchwork-Delegate: rui.zhang@intel.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DE8AB607D6 for ; Tue, 31 May 2016 06:32:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D31B427D17 for ; Tue, 31 May 2016 06:32:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C4EB827DA9; Tue, 31 May 2016 06:32:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7839827DA9 for ; Tue, 31 May 2016 06:32:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162127AbcEaGcc (ORCPT ); Tue, 31 May 2016 02:32:32 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:34604 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1162122AbcEaGc0 (ORCPT ); Tue, 31 May 2016 02:32:26 -0400 Received: by mail-pf0-f193.google.com with SMTP id c84so17240455pfc.1; Mon, 30 May 2016 23:32:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ISTJJ2u9ddFpTyHHFUNhq2DcAYwzpM13dOiqPL0Vt8w=; b=RquU+qY1ypmvzguqG1ESs7Sdg3EobByO7yn7kn244gBAne817Sq0WZ3M+P2kehw3fa y6lj4p9bpq/HYvl0dbjRs/eENRR20+M2QhBPnxx4X55935FgD2iI9XS32B5w+t9m4A8f yfObAa6jm5j5Cph2sUQ3PxrWROAqCFlmP0uX3dk0aId2+WBwS7GayaPJ6IK3qADNYyPs kYx4I69/HhYK+a1PG3UVb4qB5p4OhwW9EmxigSY0MxmErHulUPjm1EcwZHlNiY6viwCw tvP+YGNDNf/JjFubj0wkaWyeMEPxHk7387q26eE7HOhAqbQGlxJPejZnm+tPUNFCt3V8 wDjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ISTJJ2u9ddFpTyHHFUNhq2DcAYwzpM13dOiqPL0Vt8w=; b=cKvELh8gYIMWxkaY2ea/E963vtAxbxsCtqnfbSWo/+82lC7C7X7etGd/mHubIa+MQ2 3sH5WEbilzvKg083iM3Tb24SRotRwvz0FCtcPS5NGwe9UuxRcV/scZPyZghh4A/hxtQn r/jeUhGV+ME1W0Pjzje4V4moFdcMUz9axWxzSW72M3p1IoDjEQ3ExmL/nii6PIRCD5/D EIK7Irp+R9mAPIfhShYCxbpDpg+5Vn0G5ShTLTEQ3V96yKFMqUbJUIX2a5BTwME9xAGS GWbYxyNJBk0lOJ+97d8E/AJUf4qk6CS20L8gdqWd6ZOCZs2EQgwKdARxg4a0XPhgNoAh JkDQ== X-Gm-Message-State: ALyK8tJ89+1YgJd8IzcdNIHN/v9lr9GQFiZQP+BH58K+3XILyNXPaQqdI79RwtxR3WaJfA== X-Received: by 10.98.64.21 with SMTP id n21mr42228212pfa.161.1464676345172; Mon, 30 May 2016 23:32:25 -0700 (PDT) Received: from localhost ([2601:b00:c501:3660:7256:81ff:febd:926d]) by smtp.gmail.com with ESMTPSA id 75sm1095605pfo.82.2016.05.30.23.32.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 May 2016 23:32:24 -0700 (PDT) From: Eduardo Valentin To: Rui Zhang Cc: Linux PM , LKML , Eduardo Valentin Subject: [PATCH 10/15] thermal: sysfs: lock tz when access tzp properties Date: Mon, 30 May 2016 23:31:31 -0700 Message-Id: <1464676296-5610-11-git-send-email-edubezval@gmail.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1464676296-5610-1-git-send-email-edubezval@gmail.com> References: <1464676296-5610-1-git-send-email-edubezval@gmail.com> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Lock tz when in user facing sysfs handlers to expose tzp properties. This includes changing the macro create_s32_tzp_attr(), which is used in the tzp properties: k_po, k_pu, k_i, k_d, integral_cutoff, slope, offset. Cc: Zhang Rui Cc: linux-pm@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin --- drivers/thermal/thermal_sysfs.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/thermal/thermal_sysfs.c b/drivers/thermal/thermal_sysfs.c index 5b08d64..86a77cd 100644 --- a/drivers/thermal/thermal_sysfs.c +++ b/drivers/thermal/thermal_sysfs.c @@ -398,11 +398,16 @@ sustainable_power_store(struct device *dev, struct device_attribute *devattr, char *buf) \ { \ struct thermal_zone_device *tz = to_thermal_zone(dev); \ + int value; \ \ - if (tz->tzp) \ - return sprintf(buf, "%d\n", tz->tzp->name); \ - else \ + if (!tz->tzp) \ return -EIO; \ + \ + mutex_lock(&tz->lock); \ + value = tz->tzp->name; \ + mutex_unlock(&tz->lock); \ + \ + return sprintf(buf, "%d\n", value); \ } \ \ static ssize_t \ @@ -418,7 +423,9 @@ sustainable_power_store(struct device *dev, struct device_attribute *devattr, if (kstrtos32(buf, 10, &value)) \ return -EINVAL; \ \ + mutex_lock(&tz->lock); \ tz->tzp->name = value; \ + mutex_unlock(&tz->lock); \ \ return count; \ } \