| Message ID | 1465410534-29694-1-git-send-email-ben.dooks@codethink.co.uk (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Wed, Jun 8, 2016 at 8:28 PM, Ben Dooks <ben.dooks@codethink.co.uk> wrote: > The syscon_poweroff() function is not exported or declared for > usage elsewhere, so make it static to avoid the folloiwing warning: > > drivers/power/reset/syscon-poweroff.c:33:6: warning: symbol 'syscon_poweroff' was not declared. Should it be static? > > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> > --- > Cc: Sebastian Reichel <sre@kernel.org> > Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> > Cc: David Woodhouse <dwmw2@infradead.org> > Cc: linux-pm@vger.kernel.org > --- > drivers/power/reset/syscon-poweroff.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Wed, Jun 08, 2016 at 07:28:54PM +0100, Ben Dooks wrote: > The syscon_poweroff() function is not exported or declared for > usage elsewhere, so make it static to avoid the folloiwing warning: > > drivers/power/reset/syscon-poweroff.c:33:6: warning: symbol 'syscon_poweroff' was not declared. Should it be static? > > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> Thanks, queued. -- Sebastian
diff --git a/drivers/power/reset/syscon-poweroff.c b/drivers/power/reset/syscon-poweroff.c index 5560b0d..b683383 100644 --- a/drivers/power/reset/syscon-poweroff.c +++ b/drivers/power/reset/syscon-poweroff.c @@ -30,7 +30,7 @@ static struct regmap *map; static u32 offset; static u32 mask; -void syscon_poweroff(void) +static void syscon_poweroff(void) { /* Issue the poweroff */ regmap_write(map, offset, mask);
The syscon_poweroff() function is not exported or declared for usage elsewhere, so make it static to avoid the folloiwing warning: drivers/power/reset/syscon-poweroff.c:33:6: warning: symbol 'syscon_poweroff' was not declared. Should it be static? Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> --- Cc: Sebastian Reichel <sre@kernel.org> Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> Cc: David Woodhouse <dwmw2@infradead.org> Cc: linux-pm@vger.kernel.org --- drivers/power/reset/syscon-poweroff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)