From patchwork Thu Jun 16 13:14:54 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Jon Medhurst (Tixy)" X-Patchwork-Id: 9180801 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5B5E260760 for ; Thu, 16 Jun 2016 13:15:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4B08C2835D for ; Thu, 16 Jun 2016 13:15:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3FD5B28362; Thu, 16 Jun 2016 13:15:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D90182835D for ; Thu, 16 Jun 2016 13:15:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754392AbcFPNPD (ORCPT ); Thu, 16 Jun 2016 09:15:03 -0400 Received: from queue01b.mail.zen.net.uk ([212.23.3.242]:36246 "EHLO queue01b.mail.zen.net.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753849AbcFPNPA (ORCPT ); Thu, 16 Jun 2016 09:15:00 -0400 Received: from [212.23.1.3] (helo=smarthost01b.mail.zen.net.uk) by queue01b.mail.zen.net.uk with esmtp (Exim 4.72) (envelope-from ) id 1bDX8M-0001zG-Ig for linux-pm@vger.kernel.org; Thu, 16 Jun 2016 13:14:58 +0000 Received: from [82.69.122.217] (helo=linaro2) by smarthost01b.mail.zen.net.uk with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1bDX8J-0006iS-Q7; Thu, 16 Jun 2016 13:14:55 +0000 Message-ID: <1466082894.20208.1.camel@linaro.org> Subject: Re: [PATCH v2 0/3] firmware: scpi: add device power domain support From: "Jon Medhurst (Tixy)" To: Sudeep Holla Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Ulf Hansson , Mathieu Poirier , Suzuki K Poulose Date: Thu, 16 Jun 2016 14:14:54 +0100 In-Reply-To: <1466073481-697-1-git-send-email-sudeep.holla@arm.com> References: <1466073481-697-1-git-send-email-sudeep.holla@arm.com> X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 X-Originating-smarthost01b-IP: [82.69.122.217] Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Thu, 2016-06-16 at 11:37 +0100, Sudeep Holla wrote: > This series add support for SCPI based device device power state > management using genpd. > > Regards, > Sudeep > > v1[1]->v2: > - Fixed the endianness handling in scpi_device_get_power_state > as spotted by Tixy > - Renamed scpi_pd.c to scpi_pm_domain.c as suggested by Ulf You seemed to also have made some changes to the contents of the file, is that deliberate? This is the diff... static int scpi_pd_power_on(struct generic_pm_domain *domain) Reviewed-by: Ulf Hansson --- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/drivers/firmware/scpi_pm_domain.c +++ b/drivers/firmware/scpi_pd.c @@ -27,7 +27,7 @@ struct scpi_pm_domain { struct generic_pm_domain genpd; struct scpi_ops *ops; u32 domain; - char name[20]; + char name[30]; }; enum scpi_power_domain_state { @@ -51,7 +51,7 @@ static int scpi_pd_power(struct scpi_pm_domain *pd, bool power_on) if (ret) return ret; - return (state == pd->ops->device_get_power_state(pd->domain)); + return !(state == pd->ops->device_get_power_state(pd->domain)); }