From patchwork Wed Jun 22 08:42:04 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Caesar Wang X-Patchwork-Id: 9192631 X-Patchwork-Delegate: eduardo.valentin@ti.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 07E086075A for ; Wed, 22 Jun 2016 12:33:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EBEB6283E9 for ; Wed, 22 Jun 2016 12:33:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E019328402; Wed, 22 Jun 2016 12:33:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 708A0283E9 for ; Wed, 22 Jun 2016 12:33:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752466AbcFVMd3 (ORCPT ); Wed, 22 Jun 2016 08:33:29 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:35762 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752465AbcFVMd3 (ORCPT ); Wed, 22 Jun 2016 08:33:29 -0400 Received: by mail-pf0-f193.google.com with SMTP id t190so4014828pfb.2 for ; Wed, 22 Jun 2016 05:33:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ECjGvAOnFfD7T/fAfN5VtrBSreLeQZF/m1DTHJJAn4c=; b=SGx97jOiE1XdLOT3i0VLyRMnzZ7jT+8K1suLZrsk6JXygr/jyX6JvYFruisdWRXhAW TOh0sYjssbIq8S1y1jscNUswYgmRGUUElhHQU6hL7rpw3NDa3icW34x9cvpWg+Efmb+b 7pOXfNLKnzDrKiFBuLudnn3U4aD8sGy5gwN+XoZ2WLFF7gcu31luFsvq8NAq7Qh0/YPd BWtL8ngClAUM8Z3WB7UQ6jnssUzrNMmgfRXnKltq7yAauOw2rX9ag1MjJ4K3r3Z85iZ2 GcjD/lU0UKoltOobiURWc7KYojG4U7b14THMaltZg7qcmd9EWMuN6KDBNLAl8h/F/8e4 HzEg== X-Gm-Message-State: ALyK8tJJgGKVm7QSdD1oDvodwv7UsyQ9YygMmI2qNINyWYXnTkllATvLrd4O/Ah4VeEntQ== X-Received: by 10.98.10.148 with SMTP id 20mr33475829pfk.154.1466584962251; Wed, 22 Jun 2016 01:42:42 -0700 (PDT) Received: from localhost.localdomain ([103.29.142.67]) by smtp.gmail.com with ESMTPSA id z88sm73881467pfa.59.2016.06.22.01.42.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 22 Jun 2016 01:42:41 -0700 (PDT) From: Caesar Wang To: edubezval@gmail.com, linux-pm@vger.kernel.org Cc: Heiko Stuebner , dianders@chromium.org, briannorris@google.com, smbarber@google.com, linux-rockchip@lists.infradead.org, cf@rock-chips.com, huangtao@rock-chips.com, dmitry.torokhov@gmail.com, javi.merino@arm.com, peter@piie.net, rocky.hao@rock-chips.com, Sascha Hauer , Caesar Wang , Zhang Rui , linux-kernel@vger.kernel.org Subject: [PATCH v6 4/5] thermal: bang-bang governor: act on lower trip boundary Date: Wed, 22 Jun 2016 16:42:04 +0800 Message-Id: <1466584925-4829-5-git-send-email-wxt@rock-chips.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1466584925-4829-1-git-send-email-wxt@rock-chips.com> References: <1466584925-4829-1-git-send-email-wxt@rock-chips.com> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Sascha Hauer With interrupt driven thermal zones we pass the lower and upper temperature on which shall be acted, so in the governor we have to act on the exact lower temperature to be consistent. Otherwise an interrupt maybe generated on the exact lower temperature, but the bang bang governor does not react since The polling driven zones have to be one step cooler before the governor reacts. Signed-off-by: Sascha Hauer Signed-off-by: Caesar Wang Cc: Zhang Rui Cc: Eduardo Valentin Cc: linux-pm@vger.kernel.org Acked-by: Peter Feuerer --- Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: - Add the peter's ACK. Changes in v2: - Update the commit for patch[v2 4/5]. drivers/thermal/gov_bang_bang.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/gov_bang_bang.c b/drivers/thermal/gov_bang_bang.c index fc52016..5073871 100644 --- a/drivers/thermal/gov_bang_bang.c +++ b/drivers/thermal/gov_bang_bang.c @@ -65,7 +65,7 @@ static void thermal_zone_trip_update(struct thermal_zone_device *tz, int trip) if (instance->target == 0 && tz->temperature >= trip_temp) instance->target = 1; else if (instance->target == 1 && - tz->temperature < trip_temp - trip_hyst) + tz->temperature <= trip_temp - trip_hyst) instance->target = 0; dev_dbg(&instance->cdev->device, "target=%d\n",