| Message ID | 1473441919-7809-1-git-send-email-labbott@redhat.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
Hi, On 09/09/2016 10:55 PM, Laura Abbott wrote: > When converting to a shared library in ac5a181d065d ("cpupower: Add > cpuidle parts into library"), cpu_freq_cpu_exists was converted to > cpupower_is_cpu_online. cpu_req_cpu_exists returned 0 on success and > -ENOSYS on failure whereas cpupower_is_cpu_online returns 1 on success. > Check for the correct return value in cpufreq-set. > > See https://bugzilla.redhat.com/show_bug.cgi?id=1374212 > > Fixes: ac5a181d065d ("cpupower: Add cpuidle parts into library") > Reported-by: Julian Seward <jseward@acm.org> > Signed-off-by: Laura Abbott <labbott@redhat.com> > --- > tools/power/cpupower/utils/cpufreq-set.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/power/cpupower/utils/cpufreq-set.c b/tools/power/cpupower/utils/cpufreq-set.c > index b4bf769..8971d71 100644 > --- a/tools/power/cpupower/utils/cpufreq-set.c > +++ b/tools/power/cpupower/utils/cpufreq-set.c > @@ -296,7 +296,7 @@ int cmd_freq_set(int argc, char **argv) > struct cpufreq_affected_cpus *cpus; > > if (!bitmask_isbitset(cpus_chosen, cpu) || > - cpupower_is_cpu_online(cpu)) > + cpupower_is_cpu_online(cpu) != 1) > continue; > > cpus = cpufreq_get_related_cpus(cpu); > @@ -316,7 +316,7 @@ int cmd_freq_set(int argc, char **argv) > cpu <= bitmask_last(cpus_chosen); cpu++) { > > if (!bitmask_isbitset(cpus_chosen, cpu) || > - cpupower_is_cpu_online(cpu)) > + cpupower_is_cpu_online(cpu) != 1) > continue; > > if (cpupower_is_cpu_online(cpu) != 1) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Can you also remove the above check where the same condition 'cpupower_is_cpu_online(cpu) != 1' is tested twice ? Thanks and Regards, Shilpa -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/tools/power/cpupower/utils/cpufreq-set.c b/tools/power/cpupower/utils/cpufreq-set.c index b4bf769..8971d71 100644 --- a/tools/power/cpupower/utils/cpufreq-set.c +++ b/tools/power/cpupower/utils/cpufreq-set.c @@ -296,7 +296,7 @@ int cmd_freq_set(int argc, char **argv) struct cpufreq_affected_cpus *cpus; if (!bitmask_isbitset(cpus_chosen, cpu) || - cpupower_is_cpu_online(cpu)) + cpupower_is_cpu_online(cpu) != 1) continue; cpus = cpufreq_get_related_cpus(cpu); @@ -316,7 +316,7 @@ int cmd_freq_set(int argc, char **argv) cpu <= bitmask_last(cpus_chosen); cpu++) { if (!bitmask_isbitset(cpus_chosen, cpu) || - cpupower_is_cpu_online(cpu)) + cpupower_is_cpu_online(cpu) != 1) continue; if (cpupower_is_cpu_online(cpu) != 1)
When converting to a shared library in ac5a181d065d ("cpupower: Add cpuidle parts into library"), cpu_freq_cpu_exists was converted to cpupower_is_cpu_online. cpu_req_cpu_exists returned 0 on success and -ENOSYS on failure whereas cpupower_is_cpu_online returns 1 on success. Check for the correct return value in cpufreq-set. See https://bugzilla.redhat.com/show_bug.cgi?id=1374212 Fixes: ac5a181d065d ("cpupower: Add cpuidle parts into library") Reported-by: Julian Seward <jseward@acm.org> Signed-off-by: Laura Abbott <labbott@redhat.com> --- tools/power/cpupower/utils/cpufreq-set.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)