From patchwork Tue Nov 1 10:49:56 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 9407151 X-Patchwork-Delegate: rjw@sisk.pl Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7E74C60585 for ; Tue, 1 Nov 2016 10:50:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 82179297F2 for ; Tue, 1 Nov 2016 10:50:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 72EAB297F4; Tue, 1 Nov 2016 10:50:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 20F7D297F2 for ; Tue, 1 Nov 2016 10:50:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1168701AbcKAKuR (ORCPT ); Tue, 1 Nov 2016 06:50:17 -0400 Received: from mail-lf0-f65.google.com ([209.85.215.65]:36606 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1168617AbcKAKuQ (ORCPT ); Tue, 1 Nov 2016 06:50:16 -0400 Received: by mail-lf0-f65.google.com with SMTP id o20so2977511lfg.3; Tue, 01 Nov 2016 03:50:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id; bh=E57Ho11Dstjy19pOZgCpJNQU00g1nXMoy8IYe1BWjOg=; b=M45KxqfR26WFowJcWxEhMTak0ln/i/vwlKGsWEumv4Q5m8vRUBkj+ACiC0MvRt7Gb7 Z938cupYm77QvGm3tf+SVB8NjEeaDv7LQ/NHofpBLUGAJiuqAqX6nP91apgFIoW1XvfF Bq2nuxV/SbS+BcRhAjFu1orc3xiRcHTEVgVKUKWbNLve7vLBagzasSGCgAOWQF8Etfjt BMMgTZfBMYGDsicP0uv+bYcln0YBlR96W/82vT6eYDRdVlnpUtpbGFxacI9Y5f1o2B4f kkU6iDOGy+IFoPIIdiLXVHjXLq0H4xYkcd8ja5mJNNRUSDHBgTkn6zMygAiKQ2AqUNpq SXhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=E57Ho11Dstjy19pOZgCpJNQU00g1nXMoy8IYe1BWjOg=; b=D02SSMVmB0ARkB+Q9//T2p/KtSQ5GyNWdD8ke+Ps8YD00ZfxerLXiaNcARhDNC1jwk 3PUxL6VLT9nyBfgsaVjKQ7TiH6deTqH3MJSbfvfQ7N+L4FWs11Bhh3zMClCNOzZVhJBw SfrmmwKQVokva5jfOGi0BZ1Sk76ICu7UnGCzg+3FlnRZmQ0SLQCkZfGE77ltY4426lKo gVmZj3eRuVxQrCV/CM6UkcqGZL+yfhvzqfIjb8n+m6QPSRqi8ereSh6cCpQiC6DpsD0o vxlJWAHQJ4p6Sh/0Jy5jPRfjTQNKgvnp9PdGrEJLwdtZkuB3KSr4sxmgWTVQsRfSEeaZ K8Sw== X-Gm-Message-State: ABUngvcgwqKTXJRgPfkIrmpjRmy/zfEfrV966x7O7+9EeI3eclKRbqSy5CC9OEEgvwlfWA== X-Received: by 10.25.18.201 with SMTP id 70mr1235587lfs.78.1477997414473; Tue, 01 Nov 2016 03:50:14 -0700 (PDT) Received: from xi.terra (c-04aadb54.07-184-6d6c6d4.cust.bredbandsbolaget.se. [84.219.170.4]) by smtp.gmail.com with ESMTPSA id f124sm5343414lff.20.2016.11.01.03.50.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Nov 2016 03:50:14 -0700 (PDT) Received: from johan by xi.terra with local (Exim 4.87) (envelope-from ) id 1c1Wdx-0007gP-DO; Tue, 01 Nov 2016 11:50:13 +0100 From: Johan Hovold To: "Rafael J. Wysocki" Cc: Pavel Machek , Len Brown , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH] PM / sleep: fix device reference leak in test_suspend Date: Tue, 1 Nov 2016 11:49:56 +0100 Message-Id: <1477997396-29476-1-git-send-email-johan@kernel.org> X-Mailer: git-send-email 2.7.3 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Make sure to drop the reference taken by class_find_device() after opening the rtc device. Fixes: 77437fd4e61f ("pm: boot time suspend selftest") Signed-off-by: Johan Hovold Acked-by: Pavel Machek --- kernel/power/suspend_test.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/kernel/power/suspend_test.c b/kernel/power/suspend_test.c index 084452e34a12..bdff5ed57f10 100644 --- a/kernel/power/suspend_test.c +++ b/kernel/power/suspend_test.c @@ -203,8 +203,10 @@ static int __init test_suspend(void) /* RTCs have initialized by now too ... can we use one? */ dev = class_find_device(rtc_class, NULL, NULL, has_wakealarm); - if (dev) + if (dev) { rtc = rtc_class_open(dev_name(dev)); + put_device(dev); + } if (!rtc) { printk(warn_no_rtc); return 0;