From patchwork Mon Mar 20 10:19:23 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulf Hansson X-Patchwork-Id: 9633681 X-Patchwork-Delegate: rjw@sisk.pl Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 922BC601E9 for ; Mon, 20 Mar 2017 10:21:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 819822780C for ; Mon, 20 Mar 2017 10:21:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7675C27F9A; Mon, 20 Mar 2017 10:21:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 140E62780C for ; Mon, 20 Mar 2017 10:21:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753019AbdCTKVC (ORCPT ); Mon, 20 Mar 2017 06:21:02 -0400 Received: from mail-lf0-f51.google.com ([209.85.215.51]:34598 "EHLO mail-lf0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753688AbdCTKUX (ORCPT ); Mon, 20 Mar 2017 06:20:23 -0400 Received: by mail-lf0-f51.google.com with SMTP id z15so53400734lfd.1 for ; Mon, 20 Mar 2017 03:19:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=5KIZ6nL2aZukKxZne4YS/KyosXE2bZQMD4xvdYsEm4o=; b=c5fFtS9PpUnkkfUO7ey8YA4nSXfqOpsC0mI0WORf2k+gnjX4uZ/bG7VXgmhfUgCo3B 9FBmgXk9dcciRQt6zbXTMogYXCHOTDfZE5eEhdJXY/L8H866ELPk9WBi1dSwbAkUSssp R3yNx1L28UEdkMUwBxEEEHfG6xHQPqlbNNjhM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=5KIZ6nL2aZukKxZne4YS/KyosXE2bZQMD4xvdYsEm4o=; b=Mw9gubimN8gScP7Chm2yCkdfTj2y9iTyeuw+hY9FZihUO2E6k85GP7NA2ixRF+TZXM Jhqc1Tg5z0M2e9n3Ram+I2ASXG8KPDkez9QkvKcvE6zHqaaUifpmZCNiZfyabS09/A5A IqjVyK82SR+Agf9BR3YuWoR278KrcoM0xjUwJRyBkTwTU/ggZYShlAghXUhs5Wg0Rmd8 w2yxxb49oVVqnOWipPaZu0g9+skmX0FVO4CBtVDl8H5LTF8ki0sVnVEIMSyxFRdQT6XV tv+q1CMg02WGtkbNak6cQrSxY/dzJALvbk5XmdfDubpq+J4QsYX/Chf6uz7IuQ8IZNTW JneQ== X-Gm-Message-State: AFeK/H2kTv92YRiAJ8AeIIqFxEiDYHpVTQbTsrLuXLhnb04sZkRZeyDQ6p/X4UdCAImW+Hpe X-Received: by 10.25.211.2 with SMTP id k2mr7960062lfg.61.1490005178536; Mon, 20 Mar 2017 03:19:38 -0700 (PDT) Received: from uffe-XPS-13-9360.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id c5sm223825lfk.51.2017.03.20.03.19.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 20 Mar 2017 03:19:37 -0700 (PDT) From: Ulf Hansson To: "Rafael J . Wysocki" , Ulf Hansson , linux-pm@vger.kernel.org Cc: Len Brown , Pavel Machek , Kevin Hilman , Geert Uytterhoeven , Lina Iyer , Jon Hunter , Marek Szyprowski , Viresh Kumar Subject: [PATCH 4/4] PM / Domains: Don't warn about IRQ safe device for an always on PM domain Date: Mon, 20 Mar 2017 11:19:23 +0100 Message-Id: <1490005163-28633-5-git-send-email-ulf.hansson@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1490005163-28633-1-git-send-email-ulf.hansson@linaro.org> References: <1490005163-28633-1-git-send-email-ulf.hansson@linaro.org> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When an IRQ safe device is attached to a no sleep domain, genpd prints a warning once, as to indicate it is a suboptimal configuration from power consumption point of view. However the warning doesn't make sense for an always on domain, since it anyway remains powered on. Therefore, let's change to not print the warning for this configuration. Signed-off-by: Ulf Hansson Reviewed-by: Viresh Kumar Reviewed-by: Geert Uytterhoeven Reviewed-by: Bartlomiej Zolnierkiewicz --- drivers/base/power/domain.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index 8a2bfc8..bfba02f 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -132,8 +132,12 @@ static inline bool irq_safe_dev_in_no_sleep_domain(struct device *dev, ret = pm_runtime_is_irq_safe(dev) && !genpd_is_irq_safe(genpd); - /* Warn once if IRQ safe dev in no sleep domain */ - if (ret) + /* + * Warn once if an IRQ safe device is attached to a no sleep domain, as + * to indicate a suboptimal configuration for PM. For an always on + * domain this isn't case, thus don't warn. + */ + if (ret && !genpd_is_always_on(genpd)) dev_warn_once(dev, "PM domain %s will not be powered off\n", genpd->name);