From patchwork Fri Sep 29 17:39:49 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 9978469 X-Patchwork-Delegate: rjw@sisk.pl Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A571960329 for ; Fri, 29 Sep 2017 17:40:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 97E072989D for ; Fri, 29 Sep 2017 17:40:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8CA412989F; Fri, 29 Sep 2017 17:40:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 57F52298A1 for ; Fri, 29 Sep 2017 17:40:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752285AbdI2Rkq (ORCPT ); Fri, 29 Sep 2017 13:40:46 -0400 Received: from mail-bl2nam02on0081.outbound.protection.outlook.com ([104.47.38.81]:53472 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752006AbdI2Rkp (ORCPT ); Fri, 29 Sep 2017 13:40:45 -0400 Received: from BLUPR0301CA0031.namprd03.prod.outlook.com (10.162.113.169) by CO2PR03MB2360.namprd03.prod.outlook.com (10.166.93.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Fri, 29 Sep 2017 17:40:43 +0000 Received: from BL2FFO11FD051.protection.gbl (2a01:111:f400:7c09::117) by BLUPR0301CA0031.outlook.office365.com (2a01:111:e400:5259::41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.8 via Frontend Transport; Fri, 29 Sep 2017 17:40:43 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11FD051.mail.protection.outlook.com (10.173.161.213) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.56.11 via Frontend Transport; Fri, 29 Sep 2017 17:40:43 +0000 Received: from r49496.am.freescale.net (r49496.am.freescale.net [10.29.244.74]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v8THee78010560; Fri, 29 Sep 2017 10:40:40 -0700 From: Fabio Estevam To: CC: , , , , , , , Fabio Estevam Subject: [PATCH] PM / OPP: Move error message to debug level Date: Fri, 29 Sep 2017 14:39:49 -0300 Message-ID: <1506706789-7717-1-git-send-email-fabio.estevam@nxp.com> X-Mailer: git-send-email 2.7.4 X-EOPAttributedMessage: 0 X-Matching-Connectors: 131511804436695173; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39380400002)(39860400002)(346002)(376002)(2980300002)(1109001)(1110001)(339900001)(189002)(199003)(85426001)(81156014)(16586007)(81166006)(316002)(8676002)(50466002)(6306002)(305945005)(498600001)(77096006)(36756003)(105606002)(54906003)(104016004)(8936002)(356003)(97736004)(106466001)(68736007)(8656003)(33646002)(50226002)(2906002)(5660300001)(48376002)(86362001)(4326008)(53936002)(2351001)(966005)(50986999)(39060400002)(47776003)(6916009)(189998001)(5003940100001)(15650500001); DIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR03MB2360; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD051; 1:Skd6nCssBxagfdgTC53S1BepvlE11+EI+McRPKYUt+T9DrDshZ9My1k7gXqf9IFOYhpd82TUjNDFVdusQGMTcJmnqUsWCcZesDkGjpHiMIiVklRhLsqSIFplfYyIdi1l MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f3ea3ad5-9105-4de0-e726-08d5076135ac X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017052603199)(201703131430075)(201703131517081); SRVR:CO2PR03MB2360; X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2360; 3:dCG9o0jc1P6MSwYwDaQRa1pMo+CGhNbQ5S9fMb8eZJRVg7rQFw7W6fjjSpRHKHoF0P5NS38v7gMs6sej+dcqn1P8QYU1wVE2xzZ9hlbDvPQNKh+CLNAIHiIv95MTgk4tFNz4IZC527nMzZDIGPrVm6IUnwIz7ukxYp6SFdFgIqecCNBu1hj0c5xiK92kdSnACPUJU5GQ/8V4sD8GQMYAel/w/W91qroM+0c5bxusWgAxgSFc4y86+knzvFf9cBU2+MM/CZa4iZ9JkbHw+F8zsqriL86zPSPtP3/UFRhwIW1NF3mHeYx1HOa22hsNXWW4grWM1ywhay68YQggFipibWc0DKq7w5UjvlXbhgA0fkk=; 25:4Y8tLd6Gx+0dug8KRMX+slfq7+Z4eCa/m9i+qR/6PhsvRTda9ew5sHndrnEZ08DAFaGDhT2Nno1Moz7s0qv2FUF6qJOdJuGdo6JXr34ikRR+uSahgejsk9YplQgSs0OXVBPGaCan7atEd6t5RIekDlsXc1BmWFqElPMcfPAlS8A3KqVgq9p7hOjcwmujYPFsFTz1Czdav0E2P7/o/7mMn9rtWkqbn+/328HPMCe1eBoVxIY44Dcj2S57vYTyprZgtTbx4e4OijZs9ptlqYwhKMPcfNrESYNmu3ezZmyX5k6fbJzem7wtwrwSCAokdJoP3+xUQ5421Y9moAJaPdzIeQ== X-MS-TrafficTypeDiagnostic: CO2PR03MB2360: X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2360; 31:mA6t3aYdzimVpyRiEIZJ7K+Lil62V1Afi1604Eov3Hvcj4eKMGmB3q9ZpntgWH3E9QExbo2RjKlRGKG4gXpij3kB9P3L1xlLDmAlLiAywdP1gkrU88Ou1c7BQCu3iAqynwNFFoqAq4tKmKXfs2m572icwua78fVhqSMHXtHjfZ70835xGqKzyHXCKEmCCv8BqY4MdBkf7kW1u4MYa5K5nBmooS+rKBzRLVnhfCQbRC8=; 4:eyXJfKkXZ6FaAqHiSsIVm9AqeXEjj0Z8wQGHR/OKPqxkhKBwuM7uoa30znuAHmwYWL7ch2AVi6+oKfPGN6pEM/l0gKvYkFaAx3reKYcKDd3ndf4Euf1XmmS+0735x5CI5HzprJ6WOEfoAAC/ohjsNPBJBG1eMdNfMf57fKLi12H8AGFjU1731dSSrdFXDGBnlmo3wK8waAB3fDp38kg+lauZi8EZ4jv+PuJ01kUFM0hg7Z+0t0mg3KCGY5ai1B5FezHDLGQ/BtZSyZEHZabIUeS3c7rRm0HXWodyWu81tO0= X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3002001)(6055026)(6096035)(20161123556025)(20161123561025)(201703131430075)(201703131448075)(201703131433075)(201703161259150)(201703151042153)(20161123559100)(20161123563025)(20161123565025)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CO2PR03MB2360; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CO2PR03MB2360; X-Forefront-PRVS: 0445A82F82 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CO2PR03MB2360; 23:l3c0fOwm9EOSXERi/B8aa/VrWKwE7fnGMoRZwjeKY?= =?us-ascii?Q?+mB7/H5hRedOhS+K1LUuDoVDqGCHDKNuV6RPpUxyy0R2pPo0qBeJBf8k8OLc?= =?us-ascii?Q?BgkW0ffuyY3Ru3Ujbl4Co8Qq7IyHO0VXU/jcK6c+aegxtvrGdU6MV1IFkbAU?= =?us-ascii?Q?3ItHAEZik5pifWqXXovlZM2Juv3P6yoXYmc/0icabm2Sf+eUaLBREdAtddVh?= =?us-ascii?Q?N95sqNytOBs5elpfcjaKKCUH44z/rULv4JfCbW3SQNF25w/70P/VqH8dO5Dy?= =?us-ascii?Q?G7hR5Xg10AnNrb4HLoY7tTSsxfEs3JAayWSxY6G7QJH1z8k4T3AjmM7+zUUT?= =?us-ascii?Q?pyuKsJcsElzkp/qyWuoB30PKpYVGPmbwQ2LymTfNspltH66V+mRl440/GTL9?= =?us-ascii?Q?+UtyVMaPklzSyY/KEzFFzTEgHiasUjpOhSEVDJyiN5yD4r6tLi1HG61iwEP0?= =?us-ascii?Q?VF//2s+sKkT6U5K0d2MSc/H0mvjqpI/cGH87JJkf4B0QkvlDozvkYkEn2yVs?= =?us-ascii?Q?u99KJPKSMFM+DAd/QRjbEl9V2cz8+q3oJEuRj7ozESjoQ8tjLLIyCQC5PLEu?= =?us-ascii?Q?IEe7TWkE4tu2p6FWqyp+yWvPjk00f4DlH2IafjfmZHoU9l3tfinvFwg0Vl0d?= =?us-ascii?Q?Gpf4sgw52mFYrmje6KcLtlNCqTNyLMhogICjOfGnNUqItsBy2hObny67SBP1?= =?us-ascii?Q?PoyRT5lnKqe53qxgztHzQPJepuN3rY373IHc1Z7s2Rn1rpzN4EpCW0btaAxf?= =?us-ascii?Q?/1CiemA4wFqAuyseDh03K6ygrW5E2sojejJ20vA3nrY2c3PqC42m0J34Ufxj?= =?us-ascii?Q?CsKX7C8FzGkMf0kE6UvxoutZZVbGKB1YfmdToGlg99rQC1OFcFrInKkIuN+G?= =?us-ascii?Q?Ujk57qtU6yhDAJSDpceBQhhETW9xp5mBR36DyUeFTWQzp+T29wTpJTppsohr?= =?us-ascii?Q?51R4KtHc/qTt7Jzi0ljFTiAPVSNc0a4coyV29OpdCyLbxpPe0GrN1BPhjZpj?= =?us-ascii?Q?I8pQ2HtPKGFuFo3B3qcoNumbTVOjcjy720iUy9Q5SHk/ezC8wPCVyziD0+mr?= =?us-ascii?Q?cLaIxFl8hGaIP5Et+PFISr3MdYR+oyKr5fIn1EKvfQ2JhxnpuTlU1c02LiQp?= =?us-ascii?Q?XgR6Y02lkOSXjGf/oWBAwfwcVyzJNj0nSJcizkb15aJb/1n/RKCG6StAiT/Q?= =?us-ascii?Q?5+ON7DsdHqB8u8=3D?= X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2360; 6:4mH+YCk936dRBANITFPeNEaHU+slOXQERiWPul+ds7GnPPtGr6Q5huMiP8T2hxMdJBOjftbpvTkphVaQ6odszWXqYfIL7cxZ/tHoxm+bbTvaYzpiU58TenVPBDL/9oaQH4s079SAV9gvYy3+3rXugcMkN/9hdxQI/bjKb7r1zMo3GDoPAd4rMcL01UxzuPO4x415hGn8Sycm5BG6Fq9TLxgttw686+Ou76WNpPW1NndZ4XwHR4RlZ4mlxj/X3F4dDDpmUHP9UqsNFInurkR7bJ3/BL85M2k98Tj0MNdyMTAvu9Kcq6jnLYceCpmua1gG0J9fANA4EYofte07hviu8w==; 5:WGnJE2CuHX7leir2T4OQsqK3PjiEGGBWg7621lwFhpSojKu/NlRC1TdlP4IeKMPExH2VLkKaL4kz9u85KO6ylcXMecvp5JS+ds7UXHJJx/m2ewlwVGHayPMjKnmKsqzLzvpFBsWmfNKl7jlhP2/MQlA/n+x+pcwvK/9XZ6spExw=; 24:tnPSxUGX45xCId+efVN3IX0fgyl+G5pr7c2mqPZCjaS+bBto4+s2Jy7BdBVpog5JygparLz4+uijtH6UawCxcVYS1/lhZhVuSJ7Iy/CyXS0=; 7:GErtRDTbxQQwStZkiPGIeeF76U2ozGhXe4buNAvl8wnxgQaRq1qGRlxU+wMvD+cZFMOquALvwh+fwZtlqykkfBr98BjqckHst0jcxatuhMT0YOmARkae3WxEY/jHkXUmPERBGzOwyq3qyKMGFTns54K1OQc8qz214QYPUZSc4ot/Pt7BXuAratColuWfRcaxfysNT+Zlft5p1QU/VHkaWqBXlzyoNoKiVePNI5mzx+c= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2017 17:40:43.4823 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR03MB2360 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On some i.MX6 platforms which do not have speed grading check, opp table will not be created in platform code, so cpufreq driver prints the following error message: cpu cpu0: dev_pm_opp_get_opp_count: OPP table not found (-19) However, this is not really an error in this case because the imx6q-cpufreq driver first calls dev_pm_opp_get_opp_count() and if it fails, it means that platform code does not provide OPP and then dev_pm_opp_of_add_table() will be called. In order to avoid such confusing error message, move it to debug level. It is up to the caller of dev_pm_opp_get_opp_count() to check its return value and decide if it will print an error or not. Signed-off-by: Fabio Estevam --- Previous discussion on this topic: https://patchwork.kernel.org/patch/9295059/ drivers/base/power/opp/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/power/opp/core.c b/drivers/base/power/opp/core.c index a6de325..0459b12 100644 --- a/drivers/base/power/opp/core.c +++ b/drivers/base/power/opp/core.c @@ -296,7 +296,7 @@ int dev_pm_opp_get_opp_count(struct device *dev) opp_table = _find_opp_table(dev); if (IS_ERR(opp_table)) { count = PTR_ERR(opp_table); - dev_err(dev, "%s: OPP table not found (%d)\n", + dev_dbg(dev, "%s: OPP table not found (%d)\n", __func__, count); return count; }