From patchwork Tue Apr 10 08:13:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jia-Ju Bai X-Patchwork-Id: 10332499 X-Patchwork-Delegate: eduardo.valentin@ti.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 53BE06028A for ; Tue, 10 Apr 2018 08:13:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4A95028CFB for ; Tue, 10 Apr 2018 08:13:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3F0AA28D09; Tue, 10 Apr 2018 08:13:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8552F28D07 for ; Tue, 10 Apr 2018 08:13:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752596AbeDJINY (ORCPT ); Tue, 10 Apr 2018 04:13:24 -0400 Received: from mail-it0-f65.google.com ([209.85.214.65]:51012 "EHLO mail-it0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752255AbeDJINX (ORCPT ); Tue, 10 Apr 2018 04:13:23 -0400 Received: by mail-it0-f65.google.com with SMTP id r19-v6so14694852itc.0; Tue, 10 Apr 2018 01:13:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=d0gAr96IqlEEn2cMl9+gwnzV3Sbq3AgRTUbUzo7xOqw=; b=KoFb/Z8k0ea0+jNHuqLgf32yFT1lK3WmEzCnymfEtivS4s4jXwDNNU5vDKQcXQjHo+ yUhqyRCwrdfozIE1TAIHZehH5hLpqpnL/bbKIHtXhWTaHm1i6tfEqBpdl6Qx5650qZwq RDWkpdmNAIF45bH8fK8g3vyNYGNTbBJobNsFCOE+/3fDGgSTe+hDkVfThME6A73u27K4 +u6ggxE4z8AwvzW5nJ4QPVksOs/WZQieTFbFfeHh+769QwML6IXjUFGH6KAb+P+/Gqn/ Z7AEiaXKX+IpRQ/L9gXB01pbeRPokxvxLPVkZsd5740CcMaArbmGdq5ZIlvCMHdo8DVM MX6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=d0gAr96IqlEEn2cMl9+gwnzV3Sbq3AgRTUbUzo7xOqw=; b=qIQ0tZlqUsXbR8BzBE1VsKT3fWxg+iqmVecs0n8HavmQEVRYNgXC3kLsfhd5RxWmvC naKJC/tNtfpMeQ7bczOusotNnWw0gjQArtYUELxagqTV26MWDtTNUfkZKH2On0xdLsgj RXhuB+YeqAKbNdzKJlQn23CU49aEkfRlmWGLPM09kt8lNyeSsHwRc7VcPYSUa9scGrSS uKJtu1LztWX4dzLeq4ZzpyxNo/iAs7zjzp/9BpF5Og2d7uRl5NICcIwgNnkU2ArklX+H qGB1EELinwf+zlvfXisaDBJW2DMA9xFGil90PUEAvksGm4VZj8p4R1AkHdW/xXF99nT7 Qt2A== X-Gm-Message-State: ALQs6tAqpQro/wCZlXvmoDTJnhSATJF1JHm4CXV9JG+vggW+INx5es9W tC/29r2hLxq4Hok1iRZh/qFrJJJj X-Google-Smtp-Source: AIpwx4+4emyTOda7+svMEGrFq1Ld/ylLv2QfGtbLmQzwkxWyPOxowCeyzHMjEalcKQW3CsVTBomY/w== X-Received: by 2002:a24:7a12:: with SMTP id a18-v6mr1153274itc.88.1523348002927; Tue, 10 Apr 2018 01:13:22 -0700 (PDT) Received: from oslab.tsinghua.edu.cn ([2402:f000:1:4413:8dc7:7954:4991:f324]) by smtp.gmail.com with ESMTPSA id i1-v6sm647981itf.28.2018.04.10.01.13.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 10 Apr 2018 01:13:22 -0700 (PDT) From: Jia-Ju Bai To: rui.zhang@intel.com, edubezval@gmail.com Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Jia-Ju Bai Subject: [PATCH 2/3] thermal: armada_thermal: Replace mdelay with msleep in armada375_init_sensor Date: Tue, 10 Apr 2018 16:13:16 +0800 Message-Id: <1523347996-29417-1-git-send-email-baijiaju1990@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP armada375_init_sensor() is never called in atomic context. armada375_init_sensor() is set as ".init_sensor" in struct armada_thermal_data. ".init_sensor" is called armada_thermal_probe(). armada_thermal_probe() is set as ".probe" in struct platform_driver. This function is not called in atomic context. Despite never getting called from atomic context, armada375_init_sensor() calls mdelay() to busily wait. This is not necessary and can be replaced with msleep() to avoid busy waiting. This is found by a static analysis tool named DCNS written by myself. And I also manually check it. Signed-off-by: Jia-Ju Bai --- drivers/thermal/armada_thermal.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/thermal/armada_thermal.c b/drivers/thermal/armada_thermal.c index ae75328..0825a7a 100644 --- a/drivers/thermal/armada_thermal.c +++ b/drivers/thermal/armada_thermal.c @@ -127,11 +127,11 @@ static void armada375_init_sensor(struct platform_device *pdev, reg &= ~A375_HW_RESETn; writel(reg, priv->control + 4); - mdelay(20); + msleep(20); reg |= A375_HW_RESETn; writel(reg, priv->control + 4); - mdelay(50); + msleep(50); } static void armada380_init_sensor(struct platform_device *pdev,