From patchwork Wed Oct 3 07:25:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cao Van Dong X-Patchwork-Id: 10624417 X-Patchwork-Delegate: eduardo.valentin@ti.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3F5D913BB for ; Wed, 3 Oct 2018 08:19:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2D5DC286CA for ; Wed, 3 Oct 2018 08:19:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1F7CC286D0; Wed, 3 Oct 2018 08:19:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C5A0F286CA for ; Wed, 3 Oct 2018 08:19:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727203AbeJCPGv (ORCPT ); Wed, 3 Oct 2018 11:06:51 -0400 Received: from www3345.sakura.ne.jp ([49.212.235.55]:32830 "EHLO www3345.sakura.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727001AbeJCPGv (ORCPT ); Wed, 3 Oct 2018 11:06:51 -0400 X-Greylist: delayed 3142 seconds by postgrey-1.27 at vger.kernel.org; Wed, 03 Oct 2018 11:06:50 EDT Received: from fsav304.sakura.ne.jp (fsav304.sakura.ne.jp [153.120.85.135]) by www3345.sakura.ne.jp (8.15.2/8.15.2) with ESMTP id w937RHa4037885; Wed, 3 Oct 2018 16:27:17 +0900 (JST) (envelope-from cv-dong@jinso.co.jp) Received: from www3345.sakura.ne.jp (49.212.235.55) by fsav304.sakura.ne.jp (F-Secure/fsigk_smtp/530/fsav304.sakura.ne.jp); Wed, 03 Oct 2018 16:27:17 +0900 (JST) X-Virus-Status: clean(F-Secure/fsigk_smtp/530/fsav304.sakura.ne.jp) Received: from localhost (p14010-ipadfx41marunouchi.tokyo.ocn.ne.jp [61.118.107.10]) (authenticated bits=0) by www3345.sakura.ne.jp (8.15.2/8.15.2) with ESMTPSA id w937PpEr036322 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 3 Oct 2018 16:27:17 +0900 (JST) (envelope-from cv-dong@jinso.co.jp) From: Cao Van Dong To: broonie@kernel.org, geert+renesas@glider.be, linux-pm@vger.kernel.org Cc: marc.zyngier@arm.com, kuninori.morimoto.gx@renesas.com, yoshihiro.shimoda.uh@renesas.com, linux-renesas-soc@vger.kernel.org, h-inayoshi@jinso.co.jp, nv-dung@jinso.co.jp, na-hoan@jinso.co.jp, cv-dong@jinso.co.jp Subject: [PATCH v2] thermal_hwmon: Fix the 'No sensors found' error after replacing the parameter NULL by the actual device Date: Wed, 3 Oct 2018 16:25:51 +0900 Message-Id: <1538551551-3431-1-git-send-email-cv-dong@jinso.co.jp> X-Mailer: git-send-email 2.7.4 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Formerly, when registering the hwmon device, we pass NULL as the device. It's not a problem. Recently, the developer has replaced the parameter NULL as the device by the actual device. This causes the "No sensors found" error. Therefore, instead of using the device we will use pass the parent of that device as parameter. This will sync with the processor on the hwmon core. This patch is to fix this error. This patch is based on the v4.19-rc3 tag. --- drivers/thermal/thermal_hwmon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/thermal_hwmon.c b/drivers/thermal/thermal_hwmon.c index 40c69a5..a918ba9 100644 --- a/drivers/thermal/thermal_hwmon.c +++ b/drivers/thermal/thermal_hwmon.c @@ -143,7 +143,7 @@ int thermal_add_hwmon_sysfs(struct thermal_zone_device *tz) INIT_LIST_HEAD(&hwmon->tz_list); strlcpy(hwmon->type, tz->type, THERMAL_NAME_LENGTH); strreplace(hwmon->type, '-', '_'); - hwmon->device = hwmon_device_register_with_info(&tz->device, hwmon->type, + hwmon->device = hwmon_device_register_with_info(tz->device.parent, hwmon->type, hwmon, NULL, NULL); if (IS_ERR(hwmon->device)) { result = PTR_ERR(hwmon->device);