From patchwork Thu Oct 18 17:26:06 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aisheng Dong X-Patchwork-Id: 10647683 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8999B3B73 for ; Thu, 18 Oct 2018 17:26:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6A7CD28CD0 for ; Thu, 18 Oct 2018 17:26:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5EBC528DCD; Thu, 18 Oct 2018 17:26:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7BE4928CFB for ; Thu, 18 Oct 2018 17:26:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727859AbeJSB2I (ORCPT ); Thu, 18 Oct 2018 21:28:08 -0400 Received: from mail-eopbgr60074.outbound.protection.outlook.com ([40.107.6.74]:6688 "EHLO EUR04-DB3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728150AbeJSB2I (ORCPT ); Thu, 18 Oct 2018 21:28:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5hPQWaTOMUFgUoaNrlbWfn+x/0DemwbFl8HhjIV9nbY=; b=ciKOcudzW6zL4zxOYvIzOlakEk6bo5hCKHz8CEeqbApg/1aYPbjtB1o3d/xPKDU+WVvUfs6x0tBqQ8YBz6ELGtq6xvmD16oaURZsxhJsyJheGdwZIPLxetU+eXDzeB7uHC1doKoWBJEW90eDPtVRO/O1rukVUI6a8wtTcq8wWgs= Received: from AM0PR04MB4211.eurprd04.prod.outlook.com (52.134.126.21) by AM0PR04MB3956.eurprd04.prod.outlook.com (52.134.90.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1228.23; Thu, 18 Oct 2018 17:26:06 +0000 Received: from AM0PR04MB4211.eurprd04.prod.outlook.com ([fe80::25a0:3167:d718:91c1]) by AM0PR04MB4211.eurprd04.prod.outlook.com ([fe80::25a0:3167:d718:91c1%3]) with mapi id 15.20.1228.033; Thu, 18 Oct 2018 17:26:06 +0000 From: "A.s. Dong" To: "linux-arm-kernel@lists.infradead.org" CC: "dongas86@gmail.com" , "kernel@pengutronix.de" , "shawnguo@kernel.org" , Fabio Estevam , dl-linux-imx , "rjw@rjwysocki.net" , "ulf.hansson@linaro.org" , "khilman@kernel.org" , "linux-pm@vger.kernel.org" , "A.s. Dong" Subject: [PATCH V7 3/3] firmware: imx: add SCU power domain driver Thread-Topic: [PATCH V7 3/3] firmware: imx: add SCU power domain driver Thread-Index: AQHUZwemYO3WeRLT4UuGVb9JNMDY6w== Date: Thu, 18 Oct 2018 17:26:06 +0000 Message-ID: <1539883285-7990-4-git-send-email-aisheng.dong@nxp.com> References: <1539883285-7990-1-git-send-email-aisheng.dong@nxp.com> In-Reply-To: <1539883285-7990-1-git-send-email-aisheng.dong@nxp.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.7.4 x-clientproxiedby: HK0PR01CA0029.apcprd01.prod.exchangelabs.com (2603:1096:203:3e::17) To AM0PR04MB4211.eurprd04.prod.outlook.com (2603:10a6:208:66::21) authentication-results: spf=none (sender IP is ) smtp.mailfrom=aisheng.dong@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [119.31.174.66] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;AM0PR04MB3956;6:RHuq8ubxctBrKZu3Eg1vcACGXLo01EFX0TUusa6of+GJvkhLX1YGgNfTdJ2Bpe/Jd3asquwb0Cfd+A9oqrFjG36GfLbdq2oZx8Yg0qs/eQ8E/K6s5CwMp9ipOw/MUiREe9cCG17FMDHkn6Ll8uHIR/xnRHSHvVaalA3Mmgv58Jg5USewEM+HIjV4uVILHG33PgRWo03wE6566sUEcxIShgDhbozXYNsR8lHS16B7/QhZ1B2ELEJyU+0sKABVUhDYbkAJDEmWmcTvmIA6IFqXyRN2Q4R03J8xzWECvb6Uly8yZ/u3Lc/N3u2LnvUK7a7xsPDr2WjjPhJylnhiPOPdOqmov91JIftcBbuaWxK+wDPdh+LHecWKuomhnKNEq5vaE0mhnX9a9E1ST+YJvI3A9B+iOD710fkmSkNMCc+KinuGUhl2gmfSt57YOz/FIAL9hIIzt4vGmXZuoaEtJFkgiw==;5:IhOV/KkZfDqHiNMwNyxzXNe17DE9WXdVWsZwPV6te9Euu3QnZ09Jsoae1l9Rg/VYLGG8oDuILuUdmYrJrAUmdxa5w1+s60GZdy0CqLKI0PPbrGMl/Si0rHlebFy0lROiZWPlOAo3piqOQR+ocuR/3VFbTlHFGSmLTPTGF9FfQ0I=;7:XfO94tLDLowOxIEamPklMRsgwv9kD5uPrde/vfBQidAChacnDFkLFdLfQvQMUlqT/wrfrJs9RBNac73d01CLHFYb3LcR6Ap+aeWfM0lt96V8PpvrRxM680oiJ/ESiRAc3xXjQzuMoCtCBpsqjN6F7VLZ88STIN42WD5s4tbceX8PL/JzXm/Jd2tyXJMy2IWkWweir4k1hMq4LMlgOFmj8Sp9ZGpnzeDPxq0F2aCXuoqlKMxq6q8ycJnjJMC/LTi+ x-ms-office365-filtering-correlation-id: 23105239-07c8-4d0b-c520-08d6351ec91c x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020);SRVR:AM0PR04MB3956; x-ms-traffictypediagnostic: AM0PR04MB3956: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(269456686620040)(9452136761055)(185117386973197); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(3231355)(944501410)(52105095)(10201501046)(93006095)(93001095)(6055026)(149066)(150057)(6041310)(20161123560045)(20161123558120)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201708071742011)(7699051)(76991095);SRVR:AM0PR04MB3956;BCL:0;PCL:0;RULEID:;SRVR:AM0PR04MB3956; x-forefront-prvs: 08296C9B35 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(39860400002)(136003)(376002)(396003)(366004)(346002)(199004)(189003)(54534003)(14444005)(2906002)(486006)(186003)(2351001)(76176011)(7736002)(25786009)(81156014)(6916009)(6436002)(305945005)(26005)(8676002)(81166006)(8936002)(106356001)(54906003)(102836004)(99286004)(2501003)(316002)(97736004)(14454004)(508600001)(386003)(52116002)(256004)(6506007)(105586002)(68736007)(5660300001)(71200400001)(71190400001)(5250100002)(86362001)(6116002)(3846002)(66066001)(50226002)(6486002)(5640700003)(2616005)(4326008)(36756003)(476003)(53936002)(2900100001)(6512007)(39060400002)(446003)(11346002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM0PR04MB3956;H:AM0PR04MB4211.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: aXRyWrzqxtwMpYo8VQqNyPwwOfA86nl24MjaHPuM72LV8T4pJ7BTv7LFWfrEQKZfQy1AOPkH47N/7263zshoHG/8MqXoDAgV06N5BEKWSCe1msf2B6zYn/xkPHehlPygAsFeNJPAsBznmsh3mwHVPaGMGlJz3Uv56bMvW9ZuJK8Pj2N/U7sAnmiMH6d16+jTB9anzFrqUpYdes+8Hk3RTt1KEuvENAl2HKQMpna1VXRWdwTWr7DNbQggjIQ/XELBeqKo7FP0WGD1ACx38ZAe7EDWnWviDZeVpll3Z3NXMzRI+ZkIgutAV2cmI/LgB5IwRC39CCGw6NL4BNej2pn9dommRDqKxkv7FxGM4WesmTo= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 23105239-07c8-4d0b-c520-08d6351ec91c X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Oct 2018 17:26:06.2353 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB3956 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Some i.MX SoCs contain a system controller that is responsible for controlling the state of the IPs that are present. Communication between the host processor running an OS and the system controller happens through a SCU protocol. This patch adds SCU protocol based power domains drivers. Cc: Shawn Guo Cc: Sascha Hauer Cc: Fabio Estevam Cc: "Rafael J. Wysocki" Cc: Kevin Hilman Cc: linux-pm@vger.kernel.org Reviewed-by: Ulf Hansson Signed-off-by: Dong Aisheng --- ChangeLog: v6->v7: * still using generic "fsl,scu-pd" to driver binding incase the future SoC is compatible * remove unnecessary cast v5->v6: * only compatible string name updated from fsl,scu-pd to fsl,imx8qxp-scu-pd accordingly v4->v5: * minor improvements according to Sascha's suggestions v3->v4: * update firmware headfile patch from include/soc/imx to include/linux/firmware/imx v2->v3: * name of structures/enums updated with imx_sc prefix v1->v2: * move into drivers/firmware/imx * Implement sc_pm_set_resource_power_mode() API in the driver instead of call it via SCU API according to Sascha's suggestion --- drivers/firmware/imx/Kconfig | 6 ++ drivers/firmware/imx/Makefile | 3 +- drivers/firmware/imx/scu-pd.c | 164 ++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 172 insertions(+), 1 deletion(-) create mode 100644 drivers/firmware/imx/scu-pd.c diff --git a/drivers/firmware/imx/Kconfig b/drivers/firmware/imx/Kconfig index b170c28..6a7a7c2 100644 --- a/drivers/firmware/imx/Kconfig +++ b/drivers/firmware/imx/Kconfig @@ -9,3 +9,9 @@ config IMX_SCU This driver manages the IPC interface between host CPU and the SCU firmware running on M4. + +config IMX_SCU_PD + bool "IMX SCU Power Domain driver" + depends on IMX_SCU + help + The System Controller Firmware (SCFW) based power domain driver. diff --git a/drivers/firmware/imx/Makefile b/drivers/firmware/imx/Makefile index 0ac04df..1b2e15b 100644 --- a/drivers/firmware/imx/Makefile +++ b/drivers/firmware/imx/Makefile @@ -1,2 +1,3 @@ # SPDX-License-Identifier: GPL-2.0 -obj-$(CONFIG_IMX_SCU) += imx-scu.o misc.o +obj-$(CONFIG_IMX_SCU) += imx-scu.o misc.o +obj-$(CONFIG_IMX_SCU_PD) += scu-pd.o diff --git a/drivers/firmware/imx/scu-pd.c b/drivers/firmware/imx/scu-pd.c new file mode 100644 index 0000000..13478cd --- /dev/null +++ b/drivers/firmware/imx/scu-pd.c @@ -0,0 +1,164 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Copyright (C) 2016 Freescale Semiconductor, Inc. + * Copyright 2017~2018 NXP + * Dong Aisheng + * + * Implementation of the SCU based Power Domains + */ + +#define pr_fmt(fmt) "scu_pd: " fmt + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +struct imx_sc_pm_domain { + struct generic_pm_domain pd; + u32 rsrc_id; +}; + +static struct imx_sc_ipc *pm_ipc_handle; + +/* SCU Power Mode Protocol definition */ +struct imx_sc_msg_req_set_resource_power_mode { + struct imx_sc_rpc_msg hdr; + u16 resource; + u8 mode; +} __packed; + +static int imx_sc_pd_power(struct generic_pm_domain *domain, bool power_on) +{ + struct imx_sc_msg_req_set_resource_power_mode msg; + struct imx_sc_rpc_msg *hdr = &msg.hdr; + struct imx_sc_pm_domain *pd; + int ret; + + pd = container_of(domain, struct imx_sc_pm_domain, pd); + + hdr->ver = IMX_SC_RPC_VERSION; + hdr->svc = IMX_SC_RPC_SVC_PM; + hdr->func = IMX_SC_PM_FUNC_SET_RESOURCE_POWER_MODE; + hdr->size = 2; + + msg.resource = pd->rsrc_id; + msg.mode = power_on ? IMX_SC_PM_PW_MODE_ON : IMX_SC_PM_PW_MODE_LP; + + ret = imx_scu_call_rpc(pm_ipc_handle, &msg, true); + if (ret) + pr_err("failed to power %s resource %d ret %d\n", + power_on ? "up" : "off", pd->rsrc_id, ret); + + return ret; +} + +static int imx_sc_pd_power_on(struct generic_pm_domain *domain) +{ + return imx_sc_pd_power(domain, true); +} + +static int imx_sc_pd_power_off(struct generic_pm_domain *domain) +{ + return imx_sc_pd_power(domain, false); +} + +static struct generic_pm_domain *imx_sc_pm_add_one_domain( + struct device_node *np, + struct generic_pm_domain *genpd_parent) +{ + struct imx_sc_pm_domain *imx_sc_pd; + u32 rsrc_id; + int ret; + + imx_sc_pd = kzalloc(sizeof(*imx_sc_pd), GFP_KERNEL); + if (!imx_sc_pd) + return ERR_PTR(-ENOMEM); + + if (!of_property_read_u32(np, "reg", &rsrc_id)) { + if (rsrc_id >= IMX_SC_R_LAST) { + pr_warn("%pOF: invalid rsrc id %d found", np, rsrc_id); + ret = -EINVAL; + goto err; + } + imx_sc_pd->rsrc_id = rsrc_id; + imx_sc_pd->pd.power_off = imx_sc_pd_power_off; + imx_sc_pd->pd.power_on = imx_sc_pd_power_on; + } else { + imx_sc_pd->rsrc_id = IMX_SC_R_LAST; + } + + imx_sc_pd->pd.name = np->name; + + ret = pm_genpd_init(&imx_sc_pd->pd, NULL, true); + if (ret < 0) + goto err; + + if (genpd_parent) { + ret = pm_genpd_add_subdomain(genpd_parent, &imx_sc_pd->pd); + if (ret) + goto err; + } + + ret = of_genpd_add_provider_simple(np, &imx_sc_pd->pd); + if (!ret) + return &imx_sc_pd->pd; + + pm_genpd_remove_subdomain(genpd_parent, &imx_sc_pd->pd); + +err: + pr_warn("failed to add PM domain %pOF: %d\n", np, ret); + kfree(imx_sc_pd); + return ERR_PTR(ret); +} + +static void imx_sc_pm_add_pm_domains(struct device_node *parent, + struct generic_pm_domain *genpd_parent) +{ + struct generic_pm_domain *pd; + struct device_node *np; + + for_each_child_of_node(parent, np) { + pd = imx_sc_pm_add_one_domain(np, genpd_parent); + if (!IS_ERR(pd)) + imx_sc_pm_add_pm_domains(np, pd); + } +} + +static int imx_sc_pd_probe(struct platform_device *pdev) +{ + struct device_node *np = pdev->dev.of_node; + int ret; + + ret = imx_scu_get_handle(&pm_ipc_handle); + if (ret) + return ret; + + imx_sc_pm_add_pm_domains(np, NULL); + + return 0; +} + +static const struct of_device_id imx_sc_pd_match[] = { + { .compatible = "fsl,scu-pd", }, + { /* sentinel */ } +}; + +static struct platform_driver imx_sc_pd_driver = { + .driver = { + .name = "imx-scu-pd", + .of_match_table = imx_sc_pd_match, + }, + .probe = imx_sc_pd_probe, +}; +builtin_platform_driver(imx_sc_pd_driver); + +MODULE_AUTHOR("Dong Aisheng "); +MODULE_DESCRIPTION("IMX SCU Power Domain driver"); +MODULE_LICENSE("GPL v2");