| Message ID | 1541610593-28542-6-git-send-email-l.luba@partner.samsung.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Zhang Rui |
| Headers | show |
| Series | thermal: add new flag irq-mode for trip point | expand |
On Wed, 7 Nov 2018 at 18:10, Lukasz Luba <l.luba@partner.samsung.com> wrote: > Subject prefix: dt-bindings: thermal: > Thermal trip point gets new flag in DT: irq-mode. > Trip point may have a new explicit flag which indicate > IRQ support when the temperature is met (so the thermal framework > deos not need to set polling for it). > It is useful for 'passive' cooling trip point, > which now will not register for polling the temperature. You wrap lines in weird way making it more difficult to read. I already asked about this while reviewing v1. Please fix it. https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst#L633 > > Update documentation about irq-mode for trip points. > > Cc: Zhang Rui <rui.zhang@intel.com> > Cc: Eduardo Valentin <edubezval@gmail.com> > Cc: Daniel Lezcano <daniel.lezcano@linaro.org> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: devicetree@vger.kernel.org > Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com> > --- > Documentation/devicetree/bindings/thermal/thermal.txt | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt b/Documentation/devicetree/bindings/thermal/thermal.txt > index ca14ba9..bee21e3 100644 > --- a/Documentation/devicetree/bindings/thermal/thermal.txt > +++ b/Documentation/devicetree/bindings/thermal/thermal.txt > @@ -90,6 +90,10 @@ Required properties: > "critical": Hardware not reliable. > Type: string > > +- irq-mode: A flag indicating that trip rises irq, so there is no "rises IRQ" (it is an abbreviation). Best regards, Krzysztof > + Type: bool need of polling in thermal framework. > + Size: one cell > + > * Cooling device maps > > The cooling device maps node is a node to describe how cooling devices > @@ -256,16 +260,19 @@ thermal-zones { > temperature = <90000>; /* millicelsius */ > hysteresis = <2000>; /* millicelsius */ > type = "active"; > + irq-mode; > }; > cpu_alert1: cpu-alert1 { > temperature = <100000>; /* millicelsius */ > hysteresis = <2000>; /* millicelsius */ > type = "passive"; > + irq-mode; > }; > cpu_crit: cpu-crit { > temperature = <125000>; /* millicelsius */ > hysteresis = <2000>; /* millicelsius */ > type = "critical"; > + irq-mode; > }; > }; > > -- > 2.7.4 >
Hi Krzysztof, Thanks for the comments. On 11/12/18 9:51 AM, Krzysztof Kozlowski wrote: > On Wed, 7 Nov 2018 at 18:10, Lukasz Luba <l.luba@partner.samsung.com> wrote: >> > > Subject prefix: > dt-bindings: thermal: > >> Thermal trip point gets new flag in DT: irq-mode. >> Trip point may have a new explicit flag which indicate >> IRQ support when the temperature is met (so the thermal framework >> deos not need to set polling for it). >> It is useful for 'passive' cooling trip point, >> which now will not register for polling the temperature. > > You wrap lines in weird way making it more difficult to read. > I already asked about this while reviewing v1. Please fix it. > https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst#L633 > I will fix it in v3. >> >> Update documentation about irq-mode for trip points. >> >> Cc: Zhang Rui <rui.zhang@intel.com> >> Cc: Eduardo Valentin <edubezval@gmail.com> >> Cc: Daniel Lezcano <daniel.lezcano@linaro.org> >> Cc: Rob Herring <robh+dt@kernel.org> >> Cc: Mark Rutland <mark.rutland@arm.com> >> Cc: devicetree@vger.kernel.org >> Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com> >> --- >> Documentation/devicetree/bindings/thermal/thermal.txt | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt b/Documentation/devicetree/bindings/thermal/thermal.txt >> index ca14ba9..bee21e3 100644 >> --- a/Documentation/devicetree/bindings/thermal/thermal.txt >> +++ b/Documentation/devicetree/bindings/thermal/thermal.txt >> @@ -90,6 +90,10 @@ Required properties: >> "critical": Hardware not reliable. >> Type: string >> >> +- irq-mode: A flag indicating that trip rises irq, so there is no > > "rises IRQ" (it is an abbreviation). ACK > > Best regards, > Krzysztof > Regards, Lukasz
Hi Rob, On 11/12/18 8:09 PM, Rob Herring wrote: > On Wed, Nov 07, 2018 at 06:09:47PM +0100, Lukasz Luba wrote: >> Thermal trip point gets new flag in DT: irq-mode. >> Trip point may have a new explicit flag which indicate >> IRQ support when the temperature is met (so the thermal framework >> deos not need to set polling for it). >> It is useful for 'passive' cooling trip point, >> which now will not register for polling the temperature. >> >> Update documentation about irq-mode for trip points. > > This patch should come before you use it. OK, I will re-order the patch set in v3. > >> >> Cc: Zhang Rui <rui.zhang@intel.com> >> Cc: Eduardo Valentin <edubezval@gmail.com> >> Cc: Daniel Lezcano <daniel.lezcano@linaro.org> >> Cc: Rob Herring <robh+dt@kernel.org> >> Cc: Mark Rutland <mark.rutland@arm.com> >> Cc: devicetree@vger.kernel.org >> Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com> >> --- >> Documentation/devicetree/bindings/thermal/thermal.txt | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt b/Documentation/devicetree/bindings/thermal/thermal.txt >> index ca14ba9..bee21e3 100644 >> --- a/Documentation/devicetree/bindings/thermal/thermal.txt >> +++ b/Documentation/devicetree/bindings/thermal/thermal.txt >> @@ -90,6 +90,10 @@ Required properties: >> "critical": Hardware not reliable. >> Type: string >> >> +- irq-mode: A flag indicating that trip rises irq, so there is no >> + Type: bool need of polling in thermal framework. >> + Size: one cell > > Should be optional, right? Yes, it is optional. I will mention about it in change v3. Thank you for the review. Regards, Lukasz
diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt b/Documentation/devicetree/bindings/thermal/thermal.txt index ca14ba9..bee21e3 100644 --- a/Documentation/devicetree/bindings/thermal/thermal.txt +++ b/Documentation/devicetree/bindings/thermal/thermal.txt @@ -90,6 +90,10 @@ Required properties: "critical": Hardware not reliable. Type: string +- irq-mode: A flag indicating that trip rises irq, so there is no + Type: bool need of polling in thermal framework. + Size: one cell + * Cooling device maps The cooling device maps node is a node to describe how cooling devices @@ -256,16 +260,19 @@ thermal-zones { temperature = <90000>; /* millicelsius */ hysteresis = <2000>; /* millicelsius */ type = "active"; + irq-mode; }; cpu_alert1: cpu-alert1 { temperature = <100000>; /* millicelsius */ hysteresis = <2000>; /* millicelsius */ type = "passive"; + irq-mode; }; cpu_crit: cpu-crit { temperature = <125000>; /* millicelsius */ hysteresis = <2000>; /* millicelsius */ type = "critical"; + irq-mode; }; };
Thermal trip point gets new flag in DT: irq-mode. Trip point may have a new explicit flag which indicate IRQ support when the temperature is met (so the thermal framework deos not need to set polling for it). It is useful for 'passive' cooling trip point, which now will not register for polling the temperature. Update documentation about irq-mode for trip points. Cc: Zhang Rui <rui.zhang@intel.com> Cc: Eduardo Valentin <edubezval@gmail.com> Cc: Daniel Lezcano <daniel.lezcano@linaro.org> Cc: Rob Herring <robh+dt@kernel.org> Cc: Mark Rutland <mark.rutland@arm.com> Cc: devicetree@vger.kernel.org Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com> --- Documentation/devicetree/bindings/thermal/thermal.txt | 7 +++++++ 1 file changed, 7 insertions(+)