From patchwork Wed Mar 6 13:25:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aisheng Dong X-Patchwork-Id: 10841101 X-Patchwork-Delegate: rjw@sisk.pl Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DB49C1803 for ; Wed, 6 Mar 2019 13:25:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C766C2D95F for ; Wed, 6 Mar 2019 13:25:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BB88C2D96E; Wed, 6 Mar 2019 13:25:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 60C962D95F for ; Wed, 6 Mar 2019 13:25:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726429AbfCFNZO (ORCPT ); Wed, 6 Mar 2019 08:25:14 -0500 Received: from mail-eopbgr00067.outbound.protection.outlook.com ([40.107.0.67]:27534 "EHLO EUR02-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726882AbfCFNZO (ORCPT ); Wed, 6 Mar 2019 08:25:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8qLnXgPwWUG37nyYymuZxDZbjc8/U+mMsYxMB1GSBj4=; b=lQHUd82SWH1rrdlvuf44uW/qy00TAez//NqK4PPD95Iy0Akd6Ki29H1999bHOWEaOV+4tUdPoxqv2CQJZGm2ol5laXaJwRCWp7EyjQEZC14lCmLFvn6vZLazvONXa8WuaXjF1It6zE7iGWwec/9KHpfyPXshyV9A6tob7Apui5k= Received: from AM0PR04MB4211.eurprd04.prod.outlook.com (52.134.92.158) by AM0PR04MB5345.eurprd04.prod.outlook.com (20.178.112.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1686.18; Wed, 6 Mar 2019 13:25:12 +0000 Received: from AM0PR04MB4211.eurprd04.prod.outlook.com ([fe80::50ed:d1b5:c043:3b79]) by AM0PR04MB4211.eurprd04.prod.outlook.com ([fe80::50ed:d1b5:c043:3b79%2]) with mapi id 15.20.1686.016; Wed, 6 Mar 2019 13:25:12 +0000 From: Aisheng Dong To: "linux-pm@vger.kernel.org" CC: "linux-arm-kernel@lists.infradead.org" , "dongas86@gmail.com" , dl-linux-imx , "rjw@rjwysocki.net" , "ulf.hansson@linaro.org" , "khilman@kernel.org" , Aisheng Dong Subject: [PATCH 1/6] PM / Domains: Improve warn for multiple states but no governor in genpd Thread-Topic: [PATCH 1/6] PM / Domains: Improve warn for multiple states but no governor in genpd Thread-Index: AQHU1CAG9faKd1tVckmbMj06d/iqUA== Date: Wed, 6 Mar 2019 13:25:12 +0000 Message-ID: <1551878302-8146-2-git-send-email-aisheng.dong@nxp.com> References: <1551878302-8146-1-git-send-email-aisheng.dong@nxp.com> In-Reply-To: <1551878302-8146-1-git-send-email-aisheng.dong@nxp.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.7.4 x-clientproxiedby: HK0P153CA0009.APCP153.PROD.OUTLOOK.COM (2603:1096:203:18::21) To AM0PR04MB4211.eurprd04.prod.outlook.com (2603:10a6:208:5b::30) authentication-results: spf=none (sender IP is ) smtp.mailfrom=aisheng.dong@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [119.31.174.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 51ec0e42-2259-427e-a1db-08d6a237292c x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020);SRVR:AM0PR04MB5345; x-ms-traffictypediagnostic: AM0PR04MB5345: x-microsoft-exchange-diagnostics: =?iso-8859-1?q?1=3BAM0PR04MB5345=3B23=3AxW?= =?iso-8859-1?q?Sl7PN/9cA+FEmeYCtEqun7tAY3yP3fdOH8cECfD32JOfyBu3SxaUkPIH6eKM?= =?iso-8859-1?q?Zcg7DKMSKjvRSJx6OxoX5itKuF5Wz8l+P5smxrnUgGxHmGpCM2tNniR4NP8T?= =?iso-8859-1?q?sT7b5Q9OeMURBHUpyGDeZ7tEcq3L4ccuLzWuYhz0YCIC1p60vk7OEqr1fWp1?= =?iso-8859-1?q?wgL1kmC14q0zs2alWh+Js4McYBOt1nPy/+YAjK4brDKDDAHRL2f/07kfxOti?= =?iso-8859-1?q?SOvBzMU0zXhIYKntQN5A5ik5VsvfORwozwuUcSRRH2SWqxobYiv6jg5DLqC7?= =?iso-8859-1?q?oWBcs8wpXq3OdPt2kXQf3syRhrvI/xA5c7vI3rUEZbexzpA3E6oypK+y9die?= =?iso-8859-1?q?U59dmWBJ3EdfEIs7xjGC3fIbC2rgOHS/a6LFV7Tp1M/r2nxUr6LDbth58TzY?= =?iso-8859-1?q?Yb1fL4OZ9FlhCTQ4FNXvD20MS43dhCmEXKxjiM5OT+ppZYqGgok9lM9E5s4R?= =?iso-8859-1?q?Vmccmdf+ZlUYQzidwxP3tbvMAamOrIpfGnguauGjebW7FKURmR2MEAGQJ/eu?= =?iso-8859-1?q?jWlyng58b1+PZWSWA3vh1NDQoGrqWxYFgGLRMrsZPGmtgDenmVVBqqAQJZMd?= =?iso-8859-1?q?zdc5LrwdvK9+oAAa9ZP4woAu41zhjsgAogif7KTHIecqtv7pRlhaznnffBbR?= =?iso-8859-1?q?CdQ9OwhJnBJAmVR+21LVH8y67e4syy5mRmIfG0hVKP4it/f2EpAT+L8XV0xP?= =?iso-8859-1?q?EnI31FHj9RrVRC0sbbknq2gpCAw6vRUzOgvg59wNpTnRA2dvFIJEnafr3Iuq?= =?iso-8859-1?q?kxvV4an2zhzeojDefesrKfXpl1CRQ0RHVOBZBec2abUOFp7p7wLkOy4tL+zT?= =?iso-8859-1?q?XpXVchhTwCGwubUO2GlbOpsfSu9/xXQ3O5rTHVx5I+o+HNQ6nOC9NhQvY28r?= =?iso-8859-1?q?IZQDPgQhijU9moINtJxRxhhEJOYw4NP1QMmoBVS37JK92OiKJoT7iUVYC4iS?= =?iso-8859-1?q?5D96ir5JaBA8vSM+Ck4+/hqzD1P2EnDVglbat3QiL23bjDX8AKmsEIKfYsGp?= =?iso-8859-1?q?XaB8CoD2JgfHWsfw15Hmy0xkj5ifFXI6/CxaS59kZiEIf+ivQDfIpTxBfWQU?= =?iso-8859-1?q?3fsMUqwVZhXpJEE8JGfcKgrse8ThxHWBcloAheLpyJRB3fD9sne5z8Tc4HJE?= =?iso-8859-1?q?8WqxQALGXBYGe4phPq/8HvpLOr7ZYqdwzUwzytK7bl5IaTMy73KXfY7r+gUt?= =?iso-8859-1?q?oWhodrp+ms8IpakTXcNfUAamDWc0M9YcHgdQvKc1z0kxl6rQ/sAgqE3127HN?= =?iso-8859-1?q?ijpTroz2Fw0YbD3VXclbjskv7IKkwZ+ez3ZZjE0DllGTacsvDOtcRR+oB25T?= =?iso-8859-1?q?E=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 0968D37274 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(39860400002)(396003)(136003)(366004)(376002)(346002)(199004)(189003)(316002)(4326008)(44832011)(386003)(446003)(486006)(2906002)(2616005)(54906003)(476003)(11346002)(6506007)(68736007)(36756003)(52116002)(186003)(105586002)(2351001)(4744005)(14454004)(86362001)(26005)(5660300002)(106356001)(50226002)(71200400001)(71190400001)(25786009)(102836004)(8936002)(305945005)(478600001)(6916009)(6436002)(7736002)(99286004)(8676002)(66066001)(5640700003)(76176011)(256004)(14444005)(6486002)(81156014)(97736004)(3846002)(6116002)(53936002)(2501003)(81166006)(6512007);DIR:OUT;SFP:1101;SCL:1;SRVR:AM0PR04MB5345;H:AM0PR04MB4211.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: +A+jq9+CJX/BjUeN/WOeeYaiGFv+3Dzi4QuES/fhQlaRvpNYubFg+FK7tuYA0qfb/26qrqSyBG+DMITlPccNJYfEigOa4j4AYRMa49Bwn0Q/vqYp80o1Hi0fTPQy/45hIKLQn5OFw8EVJjo943j3FOxS/xv1K3sE987HrNUM+nLFlkBStrntieGm0XSwLOFpP4zguSib0kkdEwCugwHruzSYloE3lFxHrssBcm3Ro2YUpsCLy14vER3PqrZJgPnyogO8+rOzK/9YFPqSxAIXGO1hXxCJqvld0ARJut2wmhW9fxdCYzsJzATtmx8lUopOD5zAIXgD8XMg67eV6HJScjAlg9iFp+Bvxl3R/yiDO/IWjT8nHfukP4S0NvcKEp7OtW6wbtwY7IltvStHrgdEOxwJzsciRyLosGroPJU3XxI= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 51ec0e42-2259-427e-a1db-08d6a237292c X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Mar 2019 13:25:12.1818 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5345 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It's possible a PM domain defines only one state and it does not need a governor to work. For such case, a warning actually is not necessary. Signed-off-by: Dong Aisheng Reviewed-by: Ulf Hansson --- drivers/base/power/domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index 2c334c0..394f9da 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -1766,7 +1766,7 @@ int pm_genpd_init(struct generic_pm_domain *genpd, ret = genpd_set_default_power_state(genpd); if (ret) return ret; - } else if (!gov) { + } else if (!gov && genpd->state_count > 1) { pr_warn("%s : no governor for states\n", genpd->name); }