| Message ID | 1581932575-13177-1-git-send-email-Anson.Huang@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | viresh kumar |
| Headers | show |
| Series | cpufreq: imx-cpufreq-dt: Add "cpu-supply" property check | expand |
On 17-02-20, 17:42, Anson Huang wrote: > The cpufreq-dt driver allows cpufreq driver enabled without valid > regulator assigned, however, all i.MX platforms using cpufreq-dt > driver now require valid regulator, add "cpu-supply" property check > to avoid i.MX platforms' cpufreq enabled without valid regulator > and lead to system unstable. > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > --- > drivers/cpufreq/imx-cpufreq-dt.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/cpufreq/imx-cpufreq-dt.c b/drivers/cpufreq/imx-cpufreq-dt.c > index 6cb8193..0e29d88 100644 > --- a/drivers/cpufreq/imx-cpufreq-dt.c > +++ b/drivers/cpufreq/imx-cpufreq-dt.c > @@ -31,6 +31,9 @@ static int imx_cpufreq_dt_probe(struct platform_device *pdev) > int speed_grade, mkt_segment; > int ret; > > + if (!of_find_property(cpu_dev->of_node, "cpu-supply", NULL)) > + return -ENODEV; > + > ret = nvmem_cell_read_u32(cpu_dev, "speed_grade", &cell_value); > if (ret) > return ret; Applied. Thanks.
diff --git a/drivers/cpufreq/imx-cpufreq-dt.c b/drivers/cpufreq/imx-cpufreq-dt.c index 6cb8193..0e29d88 100644 --- a/drivers/cpufreq/imx-cpufreq-dt.c +++ b/drivers/cpufreq/imx-cpufreq-dt.c @@ -31,6 +31,9 @@ static int imx_cpufreq_dt_probe(struct platform_device *pdev) int speed_grade, mkt_segment; int ret; + if (!of_find_property(cpu_dev->of_node, "cpu-supply", NULL)) + return -ENODEV; + ret = nvmem_cell_read_u32(cpu_dev, "speed_grade", &cell_value); if (ret) return ret;
The cpufreq-dt driver allows cpufreq driver enabled without valid regulator assigned, however, all i.MX platforms using cpufreq-dt driver now require valid regulator, add "cpu-supply" property check to avoid i.MX platforms' cpufreq enabled without valid regulator and lead to system unstable. Signed-off-by: Anson Huang <Anson.Huang@nxp.com> --- drivers/cpufreq/imx-cpufreq-dt.c | 3 +++ 1 file changed, 3 insertions(+)