diff mbox series

powercap: remove unused local MSR define

Message ID 1589974578-26791-1-git-send-email-sumeet.r.pawnikar@intel.com (mailing list archive)
State Superseded, archived
Headers show
Series powercap: remove unused local MSR define | expand

Commit Message

Sumeet Pawnikar May 20, 2020, 11:36 a.m. UTC 
From: "Pawnikar, Sumeet" <sumeet.r.pawnikar@intel.com>

Remove unused PLATFORM_POWER_LIMIT MSR local definition from file
intel_rapl_common.c. This was missed while splitting old RAPL code
intel_rapl.c file into two new files intel_rapl_msr.c and
intel_rapl_common.c as per the commit 3382388d7148
("intel_rapl: abstract RAPL common code"). Currently, this #define
entry is being used only in intel_rapl_msr.c file and local definition
present in this file.

Signed-off-by: Pawnikar, Sumeet <sumeet.r.pawnikar@intel.com>
---
 drivers/powercap/intel_rapl_common.c |    3 ---
 1 file changed, 3 deletions(-)

Comments

Andy Shevchenko May 20, 2020, 11:53 a.m. UTC | #1 
On Wed, May 20, 2020 at 05:06:18PM +0530, Sumeet Pawnikar wrote:
> From: "Pawnikar, Sumeet" <sumeet.r.pawnikar@intel.com>
> 
> Remove unused PLATFORM_POWER_LIMIT MSR local definition from file
> intel_rapl_common.c. This was missed while splitting old RAPL code
> intel_rapl.c file into two new files intel_rapl_msr.c and
> intel_rapl_common.c as per the commit 3382388d7148
> ("intel_rapl: abstract RAPL common code"). Currently, this #define
> entry is being used only in intel_rapl_msr.c file and local definition
> present in this file.

> Signed-off-by: Pawnikar, Sumeet <sumeet.r.pawnikar@intel.com>

Reorganize this to avoid comma (this also should make From: gone in the top of
this message). After addressing,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>

> ---
>  drivers/powercap/intel_rapl_common.c |    3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/powercap/intel_rapl_common.c b/drivers/powercap/intel_rapl_common.c
> index eb328655bc01..5527a7c76309 100644
> --- a/drivers/powercap/intel_rapl_common.c
> +++ b/drivers/powercap/intel_rapl_common.c
> @@ -26,9 +26,6 @@
>  #include <asm/cpu_device_id.h>
>  #include <asm/intel-family.h>
>  
> -/* Local defines */
> -#define MSR_PLATFORM_POWER_LIMIT	0x0000065C
> -
>  /* bitmasks for RAPL MSRs, used by primitive access functions */
>  #define ENERGY_STATUS_MASK      0xffffffff
>  
> -- 
> 1.7.9.5
>
diff mbox series

Patch

diff --git a/drivers/powercap/intel_rapl_common.c b/drivers/powercap/intel_rapl_common.c
index eb328655bc01..5527a7c76309 100644
--- a/drivers/powercap/intel_rapl_common.c
+++ b/drivers/powercap/intel_rapl_common.c
@@ -26,9 +26,6 @@ 
 #include <asm/cpu_device_id.h>
 #include <asm/intel-family.h>
 
-/* Local defines */
-#define MSR_PLATFORM_POWER_LIMIT	0x0000065C
-
 /* bitmasks for RAPL MSRs, used by primitive access functions */
 #define ENERGY_STATUS_MASK      0xffffffff