diff mbox series

cpuidle-haltpoll: move cpuidle_poll_state_init after

Message ID 1646380408-57184-1-git-send-email-lirongqing@baidu.com (mailing list archive)
State Mainlined, archived
Headers show
Series cpuidle-haltpoll: move cpuidle_poll_state_init after | expand

Commit Message

lirongqing March 4, 2022, 7:53 a.m. UTC
call cpuidle_poll_state_init only if it is needed to save
some cpu cycles

Signed-off-by: Li RongQing <lirongqing@baidu.com>
---
 drivers/cpuidle/cpuidle-haltpoll.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Rafael J. Wysocki March 9, 2022, 7:05 p.m. UTC | #1
On Fri, Mar 4, 2022 at 8:54 AM Li RongQing <lirongqing@baidu.com> wrote:
>
> call cpuidle_poll_state_init only if it is needed to save
> some cpu cycles
>
> Signed-off-by: Li RongQing <lirongqing@baidu.com>
> ---
>  drivers/cpuidle/cpuidle-haltpoll.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpuidle/cpuidle-haltpoll.c b/drivers/cpuidle/cpuidle-haltpoll.c
> index fcc5321..3a39a7f 100644
> --- a/drivers/cpuidle/cpuidle-haltpoll.c
> +++ b/drivers/cpuidle/cpuidle-haltpoll.c
> @@ -108,11 +108,11 @@ static int __init haltpoll_init(void)
>         if (boot_option_idle_override != IDLE_NO_OVERRIDE)
>                 return -ENODEV;
>
> -       cpuidle_poll_state_init(drv);
> -
>         if (!kvm_para_available() || !haltpoll_want())
>                 return -ENODEV;
>
> +       cpuidle_poll_state_init(drv);
> +
>         ret = cpuidle_register_driver(drv);
>         if (ret < 0)
>                 return ret;
> --

Applied as 5.18 material with some edits in the changelog and subject.

Thanks!
diff mbox series

Patch

diff --git a/drivers/cpuidle/cpuidle-haltpoll.c b/drivers/cpuidle/cpuidle-haltpoll.c
index fcc5321..3a39a7f 100644
--- a/drivers/cpuidle/cpuidle-haltpoll.c
+++ b/drivers/cpuidle/cpuidle-haltpoll.c
@@ -108,11 +108,11 @@  static int __init haltpoll_init(void)
 	if (boot_option_idle_override != IDLE_NO_OVERRIDE)
 		return -ENODEV;
 
-	cpuidle_poll_state_init(drv);
-
 	if (!kvm_para_available() || !haltpoll_want())
 		return -ENODEV;
 
+	cpuidle_poll_state_init(drv);
+
 	ret = cpuidle_register_driver(drv);
 	if (ret < 0)
 		return ret;