| Message ID | 1649317533-21139-1-git-send-email-hayashi.kunihiko@socionext.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Daniel Lezcano |
| Headers | show |
| Series | dt-bindings: thermal: uniphier: Use unevaluatedProperties and common bindings | expand |
On Thu, Apr 07, 2022 at 04:45:33PM +0900, Kunihiko Hayashi wrote: > This adds common bindings thermal-sensor.yaml and this is preferred for > unevaluatedProperties instead of additionalProperties. > > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> > --- > .../bindings/thermal/socionext,uniphier-thermal.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml b/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml > index c5b25ce44956..537c93da1397 100644 > --- a/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml > +++ b/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml > @@ -14,6 +14,9 @@ description: | > maintainers: > - Kunihiko Hayashi <hayashi.kunihiko@socionext.com> > > +allOf: > + - $ref: "thermal-sensor.yaml#" No advantage to adding this as this schema still has to define the value for "#thermal-sensor-cells". > + > properties: > compatible: > enum: > @@ -40,7 +43,7 @@ required: > - interrupts > - "#thermal-sensor-cells" > > -additionalProperties: false > +unevaluatedProperties: false > > examples: > - | > -- > 2.25.1 > >
Hi Rob, On 2022/04/14 3:56, Rob Herring wrote: > On Thu, Apr 07, 2022 at 04:45:33PM +0900, Kunihiko Hayashi wrote: >> This adds common bindings thermal-sensor.yaml and this is preferred for >> unevaluatedProperties instead of additionalProperties. >> >> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> >> --- >> .../bindings/thermal/socionext,uniphier-thermal.yaml | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git > a/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yam > l > b/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yam > l >> index c5b25ce44956..537c93da1397 100644 >> --- > a/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yam > l >> +++ > b/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yam > l >> @@ -14,6 +14,9 @@ description: | >> maintainers: >> - Kunihiko Hayashi <hayashi.kunihiko@socionext.com> >> >> +allOf: >> + - $ref: "thermal-sensor.yaml#" > > No advantage to adding this as this schema still has to define the value > for "#thermal-sensor-cells". I see. Certainly it's not time to add the common schema yet. I withdraw this patch. Thank you, --- Best Regards Kunihiko Hayashi
diff --git a/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml b/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml index c5b25ce44956..537c93da1397 100644 --- a/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml +++ b/Documentation/devicetree/bindings/thermal/socionext,uniphier-thermal.yaml @@ -14,6 +14,9 @@ description: | maintainers: - Kunihiko Hayashi <hayashi.kunihiko@socionext.com> +allOf: + - $ref: "thermal-sensor.yaml#" + properties: compatible: enum: @@ -40,7 +43,7 @@ required: - interrupts - "#thermal-sensor-cells" -additionalProperties: false +unevaluatedProperties: false examples: - |
This adds common bindings thermal-sensor.yaml and this is preferred for unevaluatedProperties instead of additionalProperties. Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> --- .../bindings/thermal/socionext,uniphier-thermal.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)