| Message ID | 1693250307-8910-5-git-send-email-quic_srichara@quicinc.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Daniel Lezcano |
| Headers | show |
| Series | Add support for IPQ5018 tsens | expand |
On 28/08/2023 21:18, Sricharan Ramabadhran wrote: > IPQ5018 has tsens V1.0 IP with 4 sensors and 1 interrupt. > > Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com> > --- > drivers/thermal/qcom/tsens.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c > index f39495b61952..a24eb88b3444 100644 > --- a/drivers/thermal/qcom/tsens.c > +++ b/drivers/thermal/qcom/tsens.c > @@ -1101,6 +1101,9 @@ static SIMPLE_DEV_PM_OPS(tsens_pm_ops, tsens_suspend, tsens_resume); > > static const struct of_device_id tsens_table[] = { > { > + .compatible = "qcom,ipq5018-tsens", > + .data = &data_ipq5018, > + }, { This patch does not make sense on its own. It must be squashed. You already brought the IPQ5018 in previous patch. Best regards, Krzysztof
On 8/29/2023 1:03 AM, Krzysztof Kozlowski wrote: > On 28/08/2023 21:18, Sricharan Ramabadhran wrote: >> IPQ5018 has tsens V1.0 IP with 4 sensors and 1 interrupt. >> >> Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com> >> --- >> drivers/thermal/qcom/tsens.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c >> index f39495b61952..a24eb88b3444 100644 >> --- a/drivers/thermal/qcom/tsens.c >> +++ b/drivers/thermal/qcom/tsens.c >> @@ -1101,6 +1101,9 @@ static SIMPLE_DEV_PM_OPS(tsens_pm_ops, tsens_suspend, tsens_resume); >> >> static const struct of_device_id tsens_table[] = { >> { >> + .compatible = "qcom,ipq5018-tsens", >> + .data = &data_ipq5018, >> + }, { > > This patch does not make sense on its own. It must be squashed. You > already brought the IPQ5018 in previous patch. > ok, will squash. Regards, Sricharan
diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c index f39495b61952..a24eb88b3444 100644 --- a/drivers/thermal/qcom/tsens.c +++ b/drivers/thermal/qcom/tsens.c @@ -1101,6 +1101,9 @@ static SIMPLE_DEV_PM_OPS(tsens_pm_ops, tsens_suspend, tsens_resume); static const struct of_device_id tsens_table[] = { { + .compatible = "qcom,ipq5018-tsens", + .data = &data_ipq5018, + }, { .compatible = "qcom,ipq8064-tsens", .data = &data_8960, }, {
IPQ5018 has tsens V1.0 IP with 4 sensors and 1 interrupt. Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com> --- drivers/thermal/qcom/tsens.c | 3 +++ 1 file changed, 3 insertions(+)