From patchwork Thu Feb 7 10:49:24 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Kucheria X-Patchwork-Id: 10801105 X-Patchwork-Delegate: eduardo.valentin@ti.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 22BB117FB for ; Thu, 7 Feb 2019 12:57:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 130B92D41B for ; Thu, 7 Feb 2019 12:57:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 074092D424; Thu, 7 Feb 2019 12:57:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8A3762D41B for ; Thu, 7 Feb 2019 12:57:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727003AbfBGM5x (ORCPT ); Thu, 7 Feb 2019 07:57:53 -0500 Received: from mail-pg1-f195.google.com ([209.85.215.195]:45202 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726844AbfBGM5w (ORCPT ); Thu, 7 Feb 2019 07:57:52 -0500 Received: by mail-pg1-f195.google.com with SMTP id y4so4442601pgc.12 for ; Thu, 07 Feb 2019 04:57:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=TBXOh+qCZb1AbvhplyZXyYZ1SSUAH9q1meg8o/qp39A=; b=Dxv12iw1540JjbRcyK2umnt9oXCAqkHsByXWPmEn1LVFPu2+B21yLM0K1sJznok8QQ EWxZg0ZAdBmuGcfmVux11ZIjQrnIMCBbCz4CMNGT2ftRiZnvJSsfs35IkSV1JLliz6+W cFom0VgHRXbl/oPGwYJyoTlgRctZJk6yqRUj117llYHYZBcTX9xrf1c8GOBwcyx9HLLt +g1qsVZUGcmkkLzNp9Rp/6bWwu9Nrz1gH12O7qGOeXSs46kOBlzJCfIIiC+VAP/giUvh t4y94WWhhp/KiGr1/QwVtcZ4HtcISy3hMBu3HGtT3+dQthfe/e9U6Srobab0cdFsXFcG fwRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=TBXOh+qCZb1AbvhplyZXyYZ1SSUAH9q1meg8o/qp39A=; b=Gtf73uy9l8YVnUv36KUu1nCiWPKHRgaBr/RST19pt7M8kqFK93PFJ0dCY0L83R+l4H DZdmw8GNh2jkiXx4bYNHVrKiAktAlkoBuHX0R7JmPhKNfaKe4oRIcjk9fggAMdojLlsc fGYoLP6SZYI8RKGxpFCUVr+VanLXltVM+d4ki8mcleuqB9jxek1hXJv8qApcbcg7GXF5 jpfx5SgXfvzMKlQLMq+1smS3Od3MOwMV4KrIxK/I4/M9ovjOd3PjAm5u3O/p+9VtzaAv BmYIUIarV68Tt2xWdzzhNUvsDJF6Tn5c4tj4nD7YHHtVJj+2XjjtYkKmvSfOHC4QQNs1 NRTA== X-Gm-Message-State: AHQUAuZ8b6MC2h1NbMjOycsk01mlfk2bihlwP08hvw7XjZfT71AB+g6Z F4hnubi35yfcC+u4MSoru6rp3Q== X-Google-Smtp-Source: AHgI3IYYmiAw+FmWPwkuYe1480YXN+cV/Hs36LDUyGThrQywJlslEwoZ5Zchc5gijv4TnhahQXgoRg== X-Received: by 2002:a63:a55:: with SMTP id z21mr14775670pgk.401.1549544271802; Thu, 07 Feb 2019 04:57:51 -0800 (PST) Received: from localhost ([2402:3a80:c80:4138:75dd:3900:1d90:762f]) by smtp.gmail.com with ESMTPSA id n14sm3714273pgd.48.2019.02.07.04.57.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 07 Feb 2019 04:57:51 -0800 (PST) From: Amit Kucheria To: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, bjorn.andersson@linaro.org, edubezval@gmail.com, andy.gross@linaro.org, Daniel Lezcano , David Brown , Zhang Rui Cc: linux-pm@vger.kernel.org Subject: [PATCH v1 06/24] drivers: thermal: tsens: Function prototypes should have argument names Date: Thu, 7 Feb 2019 16:19:24 +0530 Message-Id: <1ff476080e60beab71905ef39f2f703c52ae92f9.1549525708.git.amit.kucheria@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP check_patch complains a lot as follows: WARNING: function definition argument 'struct tsens_priv *' should also have an identifier name + int (*init)(struct tsens_priv *); Fix it. Signed-off-by: Amit Kucheria --- drivers/thermal/qcom/tsens.h | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/thermal/qcom/tsens.h b/drivers/thermal/qcom/tsens.h index 61ca2905ee7a..4d6a406f8dca 100644 --- a/drivers/thermal/qcom/tsens.h +++ b/drivers/thermal/qcom/tsens.h @@ -47,15 +47,15 @@ struct tsens_sensor { */ struct tsens_ops { /* mandatory callbacks */ - int (*init)(struct tsens_priv *); - int (*calibrate)(struct tsens_priv *); - int (*get_temp)(struct tsens_priv *, int, int *); + int (*init)(struct tsens_priv *priv); + int (*calibrate)(struct tsens_priv *priv); + int (*get_temp)(struct tsens_priv *priv, int i, int *temp); /* optional callbacks */ - int (*enable)(struct tsens_priv *, int); - void (*disable)(struct tsens_priv *); - int (*suspend)(struct tsens_priv *); - int (*resume)(struct tsens_priv *); - int (*get_trend)(struct tsens_priv *, int, enum thermal_trend *); + int (*enable)(struct tsens_priv *priv, int i); + void (*disable)(struct tsens_priv *priv); + int (*suspend)(struct tsens_priv *priv); + int (*resume)(struct tsens_priv *priv); + int (*get_trend)(struct tsens_priv *priv, int i, enum thermal_trend *trend); }; enum reg_list { @@ -111,10 +111,10 @@ struct tsens_priv { struct tsens_sensor sensor[0]; }; -char *qfprom_read(struct device *, const char *); -void compute_intercept_slope(struct tsens_priv *, u32 *, u32 *, u32); -int init_common(struct tsens_priv *); -int get_temp_common(struct tsens_priv *, int, int *); +char *qfprom_read(struct device *dev, const char *cname); +void compute_intercept_slope(struct tsens_priv *priv, u32 *pt1, u32 *pt2, u32 mode); +int init_common(struct tsens_priv *priv); +int get_temp_common(struct tsens_priv *priv, int i, int *temp); /* TSENS v1 targets */ extern const struct tsens_plat_data data_8916, data_8974, data_8960;