From patchwork Sun Aug 28 13:08:30 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiko Stuebner X-Patchwork-Id: 1105672 Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p7SDArtT021688 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL) for ; Sun, 28 Aug 2011 13:11:13 GMT Received: from daredevil.linux-foundation.org (localhost [127.0.0.1]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id p7SD8dBx003124; Sun, 28 Aug 2011 06:08:39 -0700 Received: from s15407518.onlinehome-server.info (s15407518.onlinehome-server.info [82.165.136.167]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id p7SD8Zr7003113 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO) for ; Sun, 28 Aug 2011 06:08:37 -0700 Received: from [91.64.125.49] (helo=marty.localnet) by s15407518.onlinehome-server.info with esmtpa (Exim 4.69) (envelope-from ) id 1Qxf6G-0003Kw-6m; Sun, 28 Aug 2011 15:08:32 +0200 From: Heiko =?iso-8859-1?q?St=FCbner?= To: Mark Brown , Liam Girdwood Date: Sun, 28 Aug 2011 15:08:30 +0200 User-Agent: KMail/1.13.5 (Linux/2.6.37-2-686; KDE/4.4.5; i686; ; ) References: <201108281507.35105.heiko@sntech.de> In-Reply-To: <201108281507.35105.heiko@sntech.de> MIME-Version: 1.0 Message-Id: <201108281508.31412.heiko@sntech.de> Received-SPF: pass (localhost is always allowed.) X-Spam-Status: No, hits=-3.698 required=5 tests=AWL, BAYES_00, OSDL_HEADER_SUBJECT_BRACKETED X-Spam-Checker-Version: SpamAssassin 3.2.4-osdl_revision__1.47__ X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.21 Cc: linux-pm@lists.linux-foundation.org, Philipp Zabel Subject: [linux-pm] [PATCH 1/3] bq24022: Evaluate returns of gpio_direction_output-calls X-BeenThere: linux-pm@lists.linux-foundation.org X-Mailman-Version: 2.1.9 Precedence: list List-Id: Linux power management List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Sun, 28 Aug 2011 13:11:13 +0000 (UTC) It wasn't done before. Signed-off-by: Heiko Stuebner --- drivers/regulator/bq24022.c | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/drivers/regulator/bq24022.c b/drivers/regulator/bq24022.c index e24d1b7..973af08 100644 --- a/drivers/regulator/bq24022.c +++ b/drivers/regulator/bq24022.c @@ -104,7 +104,17 @@ static int __init bq24022_probe(struct platform_device *pdev) goto err_iset2; } ret = gpio_direction_output(pdata->gpio_iset2, 0); + if (ret) { + dev_dbg(&pdev->dev, "couldn't set ISET2 GPIO: %d\n", + pdata->gpio_iset2); + goto err_reg; + } ret = gpio_direction_output(pdata->gpio_nce, 1); + if (ret) { + dev_dbg(&pdev->dev, "couldn't set nCE GPIO: %d\n", + pdata->gpio_nce); + goto err_reg; + } bq24022 = regulator_register(&bq24022_desc, &pdev->dev, pdata->init_data, pdata);