diff mbox

[2/4] bq24022: Use dev_err instead of dev_dbg for error messages

Message ID 201108291757.30189.heiko@sntech.de (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Heiko Stuebner Aug. 29, 2011, 3:57 p.m. UTC 
This makes error messages visible to the user,
so he/she can eventually fix them.

Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
 drivers/regulator/bq24022.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

Comments

Mark Brown Aug. 30, 2011, 10:40 a.m. UTC | #1 
On Mon, Aug 29, 2011 at 05:57:29PM +0200, Heiko Stübner wrote:
> This makes error messages visible to the user,
> so he/she can eventually fix them.
> 
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>

Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
diff mbox

Patch

diff --git a/drivers/regulator/bq24022.c b/drivers/regulator/bq24022.c
index 56627d7..7bd906c 100644
--- a/drivers/regulator/bq24022.c
+++ b/drivers/regulator/bq24022.c
@@ -93,13 +93,13 @@  static int __init bq24022_probe(struct platform_device *pdev)
 
 	ret = gpio_request(pdata->gpio_nce, "ncharge_en");
 	if (ret) {
-		dev_dbg(&pdev->dev, "couldn't request nCE GPIO: %d\n",
+		dev_err(&pdev->dev, "couldn't request nCE GPIO: %d\n",
 			pdata->gpio_nce);
 		goto err_ce;
 	}
 	ret = gpio_request(pdata->gpio_iset2, "charge_mode");
 	if (ret) {
-		dev_dbg(&pdev->dev, "couldn't request ISET2 GPIO: %d\n",
+		dev_err(&pdev->dev, "couldn't request ISET2 GPIO: %d\n",
 			pdata->gpio_iset2);
 		goto err_iset2;
 	}
@@ -119,7 +119,7 @@  static int __init bq24022_probe(struct platform_device *pdev)
 	bq24022 = regulator_register(&bq24022_desc, &pdev->dev,
 				     pdata->init_data, pdata);
 	if (IS_ERR(bq24022)) {
-		dev_dbg(&pdev->dev, "couldn't register regulator\n");
+		dev_err(&pdev->dev, "couldn't register regulator\n");
 		ret = PTR_ERR(bq24022);
 		goto err_reg;
 	}