From patchwork Mon Aug 29 15:57:29 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiko Stuebner X-Patchwork-Id: 1108872 Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) by demeter1.kernel.org (8.14.4/8.14.4) with ESMTP id p7TFxWRm025386 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL) for ; Mon, 29 Aug 2011 16:00:03 GMT Received: from daredevil.linux-foundation.org (localhost [127.0.0.1]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id p7TFvZJY025257; Mon, 29 Aug 2011 08:57:35 -0700 Received: from s15407518.onlinehome-server.info (s15407518.onlinehome-server.info [82.165.136.167]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id p7TFvVPo025242 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO) for ; Mon, 29 Aug 2011 08:57:34 -0700 Received: from 91-64-128-49-dynip.superkabel.de ([91.64.128.49] helo=marty.localnet) by s15407518.onlinehome-server.info with esmtpa (Exim 4.69) (envelope-from ) id 1Qy4DK-0002Kz-MO; Mon, 29 Aug 2011 17:57:30 +0200 From: Heiko =?iso-8859-1?q?St=FCbner?= To: Mark Brown , Liam Girdwood Date: Mon, 29 Aug 2011 17:57:29 +0200 User-Agent: KMail/1.13.5 (Linux/2.6.37-2-686; KDE/4.4.5; i686; ; ) References: <201108291755.15701.heiko@sntech.de> In-Reply-To: <201108291755.15701.heiko@sntech.de> MIME-Version: 1.0 Message-Id: <201108291757.30189.heiko@sntech.de> Received-SPF: pass (localhost is always allowed.) X-Spam-Status: No, hits=-3.607 required=5 tests=AWL, BAYES_00, OSDL_HEADER_SUBJECT_BRACKETED X-Spam-Checker-Version: SpamAssassin 3.2.4-osdl_revision__1.47__ X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.21 Cc: linux-pm@lists.linux-foundation.org, Philipp Zabel Subject: [linux-pm] [PATCH 2/4] bq24022: Use dev_err instead of dev_dbg for error messages X-BeenThere: linux-pm@lists.linux-foundation.org X-Mailman-Version: 2.1.9 Precedence: list List-Id: Linux power management List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Mon, 29 Aug 2011 16:00:38 +0000 (UTC) This makes error messages visible to the user, so he/she can eventually fix them. Signed-off-by: Heiko Stuebner Acked-by: Mark Brown --- drivers/regulator/bq24022.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/regulator/bq24022.c b/drivers/regulator/bq24022.c index 56627d7..7bd906c 100644 --- a/drivers/regulator/bq24022.c +++ b/drivers/regulator/bq24022.c @@ -93,13 +93,13 @@ static int __init bq24022_probe(struct platform_device *pdev) ret = gpio_request(pdata->gpio_nce, "ncharge_en"); if (ret) { - dev_dbg(&pdev->dev, "couldn't request nCE GPIO: %d\n", + dev_err(&pdev->dev, "couldn't request nCE GPIO: %d\n", pdata->gpio_nce); goto err_ce; } ret = gpio_request(pdata->gpio_iset2, "charge_mode"); if (ret) { - dev_dbg(&pdev->dev, "couldn't request ISET2 GPIO: %d\n", + dev_err(&pdev->dev, "couldn't request ISET2 GPIO: %d\n", pdata->gpio_iset2); goto err_iset2; } @@ -119,7 +119,7 @@ static int __init bq24022_probe(struct platform_device *pdev) bq24022 = regulator_register(&bq24022_desc, &pdev->dev, pdata->init_data, pdata); if (IS_ERR(bq24022)) { - dev_dbg(&pdev->dev, "couldn't register regulator\n"); + dev_err(&pdev->dev, "couldn't register regulator\n"); ret = PTR_ERR(bq24022); goto err_reg; }