| Message ID | 20130117115844.GB3853@pd.tnic (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
On Thursday, January 17, 2013 12:58:44 PM Borislav Petkov wrote: > From: Borislav Petkov <bp@suse.de> > Date: Thu, 17 Jan 2013 12:44:20 +0100 > Subject: [PATCH] powernow-k8: Add a kconfig dependency on acpi-cpufreq > > Andreas reports in https://bugzilla.kernel.org/show_bug.cgi?id=51741 > that with his Gentoo config, acpi-cpufreq wasn't enabled and powernow-k8 > couldn't handoff properly to acpi-cpufreq leading to running without > P-state support (i.e., cores are constantly in P0). > > To alleaviate that, we need to make powernow-k8 depend on acpi-cpufreq > so that acpi-cpufreq is always present. OK Do we need that in -stable? Rafael > Cc: Andre Przywara <andre@andrep.de> > Reported-by: Andreas <linuxuser330250@gmx.net> > Signed-off-by: Borislav Petkov <bp@suse.de> > --- > drivers/cpufreq/Kconfig.x86 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/Kconfig.x86 b/drivers/cpufreq/Kconfig.x86 > index 934854ae5eb4..7227cd734042 100644 > --- a/drivers/cpufreq/Kconfig.x86 > +++ b/drivers/cpufreq/Kconfig.x86 > @@ -106,7 +106,7 @@ config X86_POWERNOW_K7_ACPI > config X86_POWERNOW_K8 > tristate "AMD Opteron/Athlon64 PowerNow!" > select CPU_FREQ_TABLE > - depends on ACPI && ACPI_PROCESSOR > + depends on ACPI && ACPI_PROCESSOR && X86_ACPI_CPUFREQ > help > This adds the CPUFreq driver for K8/early Opteron/Athlon64 processors. > Support for K10 and newer processors is now in acpi-cpufreq. >
On Thu, Jan 17, 2013 at 01:53:55PM +0100, Rafael J. Wysocki wrote:
> Do we need that in -stable?
Yes, please.
Thanks.
On Thursday, January 17, 2013 03:17:58 PM Borislav Petkov wrote: > On Thu, Jan 17, 2013 at 01:53:55PM +0100, Rafael J. Wysocki wrote: > > Do we need that in -stable? > > Yes, please. 3.7+ I suppose? Rafael
On Thu, Jan 17, 2013 at 11:10:56PM +0100, Rafael J. Wysocki wrote:
> 3.7+ I suppose?
Yes, the patch adding the request_module() call went in in 3.7:
$ git tag --contains e1f0b8e9b04a2
v3.7
v3.7-rc1
v3.7-rc2
v3.7-rc3
v3.7-rc4
v3.7-rc5
v3.7-rc6
v3.7-rc7
v3.7-rc8
v3.7.1
v3.8-rc1
v3.8-rc2
v3.8-rc3
$
diff --git a/drivers/cpufreq/Kconfig.x86 b/drivers/cpufreq/Kconfig.x86 index 934854ae5eb4..7227cd734042 100644 --- a/drivers/cpufreq/Kconfig.x86 +++ b/drivers/cpufreq/Kconfig.x86 @@ -106,7 +106,7 @@ config X86_POWERNOW_K7_ACPI config X86_POWERNOW_K8 tristate "AMD Opteron/Athlon64 PowerNow!" select CPU_FREQ_TABLE - depends on ACPI && ACPI_PROCESSOR + depends on ACPI && ACPI_PROCESSOR && X86_ACPI_CPUFREQ help This adds the CPUFreq driver for K8/early Opteron/Athlon64 processors. Support for K10 and newer processors is now in acpi-cpufreq.