| Message ID | 20130925231915.26184.87083.stgit@srivatsabhat.in.ibm.com (mailing list archive) |
|---|---|
| State | RFC, archived |
| Headers | show |
diff --git a/mm/page_alloc.c b/mm/page_alloc.c index d5acea7..178f210 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -812,6 +812,7 @@ static void del_from_freelist(struct page *page, struct free_list *free_list, #ifdef CONFIG_DEBUG_PAGEALLOC WARN(region->nr_free < 0, "%s: nr_free is negative\n", __func__); +#if 0 /* Verify whether this page indeed belongs to this free list! */ list_for_each(p, &free_list->list) { @@ -820,6 +821,7 @@ static void del_from_freelist(struct page *page, struct free_list *free_list, } WARN(1, "%s: page doesn't belong to the given freelist!\n", __func__); +#endif page_found: #endif
Under CONFIG_DEBUG_PAGEALLOC, we have numerous checks and balances to verify the correctness of various sorted-buddy operations. But some of them are very expensive and hence can't be enabled while benchmarking the code. (They should be used only to verify that the code is working correctly, as a precursor to benchmarking the performance). The check to see if a page given as input to del_from_freelist() indeed belongs to that freelist, is one such very expensive check. Drop it. Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com> --- mm/page_alloc.c | 2 ++ 1 file changed, 2 insertions(+) -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html