From patchwork Wed Sep 25 23:20:27 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Srivatsa S. Bhat" X-Patchwork-Id: 2945571 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 1159ABFF05 for ; Wed, 25 Sep 2013 23:24:49 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 47E982034F for ; Wed, 25 Sep 2013 23:24:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 71E5120207 for ; Wed, 25 Sep 2013 23:24:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755343Ab3IYXYq (ORCPT ); Wed, 25 Sep 2013 19:24:46 -0400 Received: from e23smtp04.au.ibm.com ([202.81.31.146]:60418 "EHLO e23smtp04.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754863Ab3IYXYp (ORCPT ); Wed, 25 Sep 2013 19:24:45 -0400 Received: from /spool/local by e23smtp04.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 26 Sep 2013 09:24:43 +1000 Received: from d23dlp02.au.ibm.com (202.81.31.213) by e23smtp04.au.ibm.com (202.81.31.210) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 26 Sep 2013 09:24:41 +1000 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [9.190.235.21]) by d23dlp02.au.ibm.com (Postfix) with ESMTP id D296C2BB0052; Thu, 26 Sep 2013 09:24:40 +1000 (EST) Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r8PNOTbA65470710; Thu, 26 Sep 2013 09:24:29 +1000 Received: from d23av04.au.ibm.com (loopback [127.0.0.1]) by d23av04.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r8PNOb25018526; Thu, 26 Sep 2013 09:24:40 +1000 Received: from srivatsabhat.in.ibm.com ([9.79.250.85]) by d23av04.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id r8PNOSUK018438; Thu, 26 Sep 2013 09:24:30 +1000 From: "Srivatsa S. Bhat" Subject: [RFC PATCH v4 30/40] mm: Modify move_freepages() to handle pages in the region allocator properly To: akpm@linux-foundation.org, mgorman@suse.de, dave@sr71.net, hannes@cmpxchg.org, tony.luck@intel.com, matthew.garrett@nebula.com, riel@redhat.com, arjan@linux.intel.com, srinivas.pandruvada@linux.intel.com, willy@linux.intel.com, kamezawa.hiroyu@jp.fujitsu.com, lenb@kernel.org, rjw@sisk.pl Cc: gargankita@gmail.com, paulmck@linux.vnet.ibm.com, svaidy@linux.vnet.ibm.com, andi@firstfloor.org, isimatu.yasuaki@jp.fujitsu.com, santosh.shilimkar@ti.com, kosaki.motohiro@gmail.com, srivatsa.bhat@linux.vnet.ibm.com, linux-pm@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Date: Thu, 26 Sep 2013 04:50:27 +0530 Message-ID: <20130925232025.26184.6209.stgit@srivatsabhat.in.ibm.com> In-Reply-To: <20130925231250.26184.31438.stgit@srivatsabhat.in.ibm.com> References: <20130925231250.26184.31438.stgit@srivatsabhat.in.ibm.com> User-Agent: StGIT/0.14.3 MIME-Version: 1.0 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13092523-9264-0000-0000-0000049A11D6 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,KHOP_BIG_TO_CC, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There are situations in which the memory management subsystem needs to move pages from one migratetype to another, such as when setting up the per-zone migrate reserves (where freepages are moved from MIGRATE_MOVABLE to MIGRATE_RESERVE freelists). But the existing code that does freepage movement is unaware of the region allocator. In other words, it always assumes that the freepages that it is moving are always in the buddy page allocator's freelists. But with the introduction of the region allocator, the freepages could instead reside in the region allocator as well. So teach move_freepages() to check whether the pages are in the buddy page allocator's freelists or the region allocator and handle the two cases appropriately. The region allocator is designed in such a way that it always allocates or receives entire memory regions as a single unit. To retain these semantics during freepage movement, we first move all the pages of that region from the region allocator to the MIGRATE_MOVABLE buddy freelist and then move the requested page(s) from MIGRATE_MOVABLE to the required migratetype. Signed-off-by: Srivatsa S. Bhat --- mm/page_alloc.c | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/mm/page_alloc.c b/mm/page_alloc.c index ed5298c..939f378 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -1558,7 +1558,7 @@ int move_freepages(struct zone *zone, struct page *page; unsigned long order; struct free_area *area; - int pages_moved = 0, old_mt; + int pages_moved = 0, old_mt, region_id; #ifndef CONFIG_HOLES_IN_ZONE /* @@ -1585,7 +1585,23 @@ int move_freepages(struct zone *zone, continue; } + /* + * If the page is in the region allocator, we first move the + * region to the MIGRATE_MOVABLE buddy freelists and then move + * that page to the freelist of the requested migratetype. + * This is because the region allocator operates on whole region- + * sized chunks, whereas here we want to move pages in much + * smaller chunks. + */ order = page_order(page); + if (page_in_region_allocator(page)) { + region_id = page_zone_region_id(page); + __del_from_region_allocator(zone, order, MIGRATE_MOVABLE, + region_id); + + continue; /* Try this page again from the buddy-list */ + } + old_mt = get_freepage_migratetype(page); area = &zone->free_area[order]; move_page_freelist(page, &area->free_list[old_mt],