| Message ID | 20150121041134.GA205386@athens (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On ?ro, 2015-01-21 at 12:11 +0800, kbuild test robot wrote: > drivers/power/max77693_charger.c:615:1-4: WARNING: end returns can be simpified > > Simplify a trivial if-return sequence. Possibly combine with a > preceding function call. > Generated by: scripts/coccinelle/misc/simple_return.cocci > > CC: Krzysztof Kozlowski <k.kozlowski@samsung.com> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> > --- > > max77693_charger.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > > --- a/drivers/power/max77693_charger.c > +++ b/drivers/power/max77693_charger.c > @@ -612,12 +612,8 @@ static int max77693_reg_init(struct max7 > if (ret) > return ret; > > - ret = max77693_set_charge_input_threshold_volt(chg, > + return max77693_set_charge_input_threshold_volt(chg, > chg->charge_input_threshold_volt); > - if (ret) > - return ret; > - > - return 0; > } > > #ifdef CONFIG_OF -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Wed, Jan 21, 2015 at 12:11:34PM +0800, kbuild test robot wrote: > drivers/power/max77693_charger.c:615:1-4: WARNING: end returns can be simpified > > Simplify a trivial if-return sequence. Possibly combine with a > preceding function call. > Generated by: scripts/coccinelle/misc/simple_return.cocci Thanks, applied with Reviewed-By from Krzysztof. -- Sebastian
--- a/drivers/power/max77693_charger.c +++ b/drivers/power/max77693_charger.c @@ -612,12 +612,8 @@ static int max77693_reg_init(struct max7 if (ret) return ret; - ret = max77693_set_charge_input_threshold_volt(chg, + return max77693_set_charge_input_threshold_volt(chg, chg->charge_input_threshold_volt); - if (ret) - return ret; - - return 0; } #ifdef CONFIG_OF
drivers/power/max77693_charger.c:615:1-4: WARNING: end returns can be simpified Simplify a trivial if-return sequence. Possibly combine with a preceding function call. Generated by: scripts/coccinelle/misc/simple_return.cocci CC: Krzysztof Kozlowski <k.kozlowski@samsung.com> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> --- max77693_charger.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html