diff mbox

cpufreq: integrator: Fix module autoload for OF platform driver

Message ID 20150916202446.GA4303@goodgumbo.baconseed.org (mailing list archive)
State Accepted, archived
Delegated to: Rafael Wysocki
Headers show

Commit Message

Luis de Bethencourt Sept. 16, 2015, 8:24 p.m. UTC
This platform driver has a OF device ID table but the OF module
alias information is not created so module autoloading won't work.

Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
---

Hello,

This patch adds the missing MODULE_DEVICE_TABLE() for OF to export
that information so modules have the correct aliases built-in and
autoloading works correctly.

A longer explanation by Javier Canillas can be found here:
https://lkml.org/lkml/2015/7/30/519

Thanks,
Luis

 drivers/cpufreq/integrator-cpufreq.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Viresh Kumar Sept. 17, 2015, 1:57 a.m. UTC | #1
On 16-09-15, 22:24, Luis de Bethencourt wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
> 
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> ---
> 
> Hello,
> 
> This patch adds the missing MODULE_DEVICE_TABLE() for OF to export
> that information so modules have the correct aliases built-in and
> autoloading works correctly.
> 
> A longer explanation by Javier Canillas can be found here:
> https://lkml.org/lkml/2015/7/30/519
> 
> Thanks,
> Luis
> 
>  drivers/cpufreq/integrator-cpufreq.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/cpufreq/integrator-cpufreq.c b/drivers/cpufreq/integrator-cpufreq.c
> index 2faa421..79e3ff2 100644
> --- a/drivers/cpufreq/integrator-cpufreq.c
> +++ b/drivers/cpufreq/integrator-cpufreq.c
> @@ -221,6 +221,8 @@ static const struct of_device_id integrator_cpufreq_match[] = {
>  	{ },
>  };
>  
> +MODULE_DEVICE_TABLE(of, integrator_cpufreq_match);
> +
>  static struct platform_driver integrator_cpufreq_driver = {
>  	.driver = {
>  		.name = "integrator-cpufreq",

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Rafael J. Wysocki Oct. 5, 2015, 8:51 p.m. UTC | #2
On Thursday, September 17, 2015 07:27:56 AM Viresh Kumar wrote:
> On 16-09-15, 22:24, Luis de Bethencourt wrote:
> > This platform driver has a OF device ID table but the OF module
> > alias information is not created so module autoloading won't work.
> > 
> > Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> > ---
> > 
> > Hello,
> > 
> > This patch adds the missing MODULE_DEVICE_TABLE() for OF to export
> > that information so modules have the correct aliases built-in and
> > autoloading works correctly.
> > 
> > A longer explanation by Javier Canillas can be found here:
> > https://lkml.org/lkml/2015/7/30/519
> > 
> > Thanks,
> > Luis
> > 
> >  drivers/cpufreq/integrator-cpufreq.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/cpufreq/integrator-cpufreq.c b/drivers/cpufreq/integrator-cpufreq.c
> > index 2faa421..79e3ff2 100644
> > --- a/drivers/cpufreq/integrator-cpufreq.c
> > +++ b/drivers/cpufreq/integrator-cpufreq.c
> > @@ -221,6 +221,8 @@ static const struct of_device_id integrator_cpufreq_match[] = {
> >  	{ },
> >  };
> >  
> > +MODULE_DEVICE_TABLE(of, integrator_cpufreq_match);
> > +
> >  static struct platform_driver integrator_cpufreq_driver = {
> >  	.driver = {
> >  		.name = "integrator-cpufreq",
> 
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

Applied, thanks!

Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/cpufreq/integrator-cpufreq.c b/drivers/cpufreq/integrator-cpufreq.c
index 2faa421..79e3ff2 100644
--- a/drivers/cpufreq/integrator-cpufreq.c
+++ b/drivers/cpufreq/integrator-cpufreq.c
@@ -221,6 +221,8 @@  static const struct of_device_id integrator_cpufreq_match[] = {
 	{ },
 };
 
+MODULE_DEVICE_TABLE(of, integrator_cpufreq_match);
+
 static struct platform_driver integrator_cpufreq_driver = {
 	.driver = {
 		.name = "integrator-cpufreq",