diff mbox

idle/i7300: Add CONFIG_PCI dependency

Message ID 20161030114228.24114-1-bp@alien8.de (mailing list archive)
State Superseded, archived
Headers show

Commit Message

Borislav Petkov Oct. 30, 2016, 11:42 a.m. UTC 
From: Borislav Petkov <bp@suse.de>

... in order to fix this randconfig build warning:

  drivers/idle/i7300_idle.c: In function ‘i7300_idle_stop’:
  ./include/asm-generic/bug.h:117:24: warning: ‘got_ctl’ is used uninitialized in this function [-Wuninitialized]
    int __ret_warn_once = !!(condition);   \
                          ^
  drivers/idle/i7300_idle.c:415:5: note: ‘got_ctl’ was declared here
    u8 got_ctl;
       ^

Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Andy Henroid <andrew.d.henroid@intel.com>
Cc: linux-pm@vger.kernel.org
---
 drivers/idle/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Randy Dunlap Oct. 30, 2016, 2:54 p.m. UTC | #1 
On 10/30/16 04:42, Borislav Petkov wrote:
> From: Borislav Petkov <bp@suse.de>
> 
> ... in order to fix this randconfig build warning:
> 
>   drivers/idle/i7300_idle.c: In function ‘i7300_idle_stop’:
>   ./include/asm-generic/bug.h:117:24: warning: ‘got_ctl’ is used uninitialized in this function [-Wuninitialized]
>     int __ret_warn_once = !!(condition);   \
>                           ^
>   drivers/idle/i7300_idle.c:415:5: note: ‘got_ctl’ was declared here
>     u8 got_ctl;
>        ^
> 
> Signed-off-by: Borislav Petkov <bp@suse.de>
> Cc: Andy Henroid <andrew.d.henroid@intel.com>
> Cc: linux-pm@vger.kernel.org
> ---
>  drivers/idle/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/idle/Kconfig b/drivers/idle/Kconfig
> index 4732dfc15447..c11ee3e657a6 100644
> --- a/drivers/idle/Kconfig
> +++ b/drivers/idle/Kconfig
> @@ -18,6 +18,7 @@ config I7300_IDLE_IOAT_CHANNEL
>  config I7300_IDLE
>  	tristate "Intel chipset idle memory power saving driver"
>  	select I7300_IDLE_IOAT_CHANNEL
> +	depends on CONFIG_PCI

	depends on PCI
(no CONFIG_ prefix)

>  	help
>  	  Enable memory power savings when idle with certain Intel server
>  	  chipsets. The chipset must have I/O AT support, such as the
>
diff mbox

Patch

diff --git a/drivers/idle/Kconfig b/drivers/idle/Kconfig
index 4732dfc15447..c11ee3e657a6 100644
--- a/drivers/idle/Kconfig
+++ b/drivers/idle/Kconfig
@@ -18,6 +18,7 @@  config I7300_IDLE_IOAT_CHANNEL
 config I7300_IDLE
 	tristate "Intel chipset idle memory power saving driver"
 	select I7300_IDLE_IOAT_CHANNEL
+	depends on CONFIG_PCI
 	help
 	  Enable memory power savings when idle with certain Intel server
 	  chipsets. The chipset must have I/O AT support, such as the