From patchwork Sun Oct 30 16:32:47 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Borislav Petkov X-Patchwork-Id: 9404549 X-Patchwork-Delegate: rjw@sisk.pl Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A9C4060588 for ; Sun, 30 Oct 2016 16:32:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4F1FD28C8E for ; Sun, 30 Oct 2016 16:32:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3159B28EEF; Sun, 30 Oct 2016 16:32:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7E80C28C8E for ; Sun, 30 Oct 2016 16:32:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756748AbcJ3Qcv (ORCPT ); Sun, 30 Oct 2016 12:32:51 -0400 Received: from mail.skyhub.de ([78.46.96.112]:56004 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756704AbcJ3Qcv (ORCPT ); Sun, 30 Oct 2016 12:32:51 -0400 X-Virus-Scanned: Nedap ESD1 at mail.skyhub.de Received: from mail.skyhub.de ([127.0.0.1]) by localhost (door.skyhub.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id jJVKIq3rJk38; Sun, 30 Oct 2016 17:32:49 +0100 (CET) Received: from pd.tnic (p5DDC72AA.dip0.t-ipconnect.de [93.220.114.170]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 2B3311DA23F; Sun, 30 Oct 2016 17:32:49 +0100 (CET) Received: by pd.tnic (Postfix, from userid 1000) id 978411618C7; Sun, 30 Oct 2016 17:32:47 +0100 (CET) Date: Sun, 30 Oct 2016 17:32:47 +0100 From: Borislav Petkov To: Randy Dunlap Cc: LKML , Andy Henroid , linux-pm@vger.kernel.org Subject: Re: [PATCH] idle/i7300: Add CONFIG_PCI dependency Message-ID: <20161030163247.l5nj4b52un3nef6z@pd.tnic> References: <20161030114228.24114-1-bp@alien8.de> <1e525299-ffb2-4031-a215-c9407c22a312@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1e525299-ffb2-4031-a215-c9407c22a312@infradead.org> User-Agent: NeoMutt/20161014 (1.7.1) Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Sun, Oct 30, 2016 at 07:54:44AM -0700, Randy Dunlap wrote: > depends on PCI > (no CONFIG_ prefix) Whoops! Thanks. FWIW, it didn't fire even with "depends on CONFIG_PCI" anymore. Didn't investigate why though... --- From: Borislav Petkov Date: Sun, 30 Oct 2016 14:39:28 +0100 Subject: [PATCH] idle/i7300: Add CONFIG_PCI dependency MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ... in order to fix this randconfig build warning: drivers/idle/i7300_idle.c: In function ‘i7300_idle_stop’: ./include/asm-generic/bug.h:117:24: warning: ‘got_ctl’ is used uninitialized in this function [-Wuninitialized] int __ret_warn_once = !!(condition); \ ^ drivers/idle/i7300_idle.c:415:5: note: ‘got_ctl’ was declared here u8 got_ctl; ^ Signed-off-by: Borislav Petkov Cc: Andy Henroid Cc: linux-pm@vger.kernel.org --- drivers/idle/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/idle/Kconfig b/drivers/idle/Kconfig index 4732dfc15447..a066fca3688f 100644 --- a/drivers/idle/Kconfig +++ b/drivers/idle/Kconfig @@ -18,6 +18,7 @@ config I7300_IDLE_IOAT_CHANNEL config I7300_IDLE tristate "Intel chipset idle memory power saving driver" select I7300_IDLE_IOAT_CHANNEL + depends on PCI help Enable memory power savings when idle with certain Intel server chipsets. The chipset must have I/O AT support, such as the