[3/3] MIPS: BMIPS: enable CPUfreq

Message ID	20170202010601.75995-4-code@mmayer.net (mailing list archive)
State	Changes Requested, archived
Headers	show Return-Path: <linux-pm-owner@kernel.org> From: Markus Mayer <code@mmayer.net> To: Ralf Baechle <ralf@linux-mips.org>, Viresh Kumar <viresh.kumar@linaro.org>, "Rafael J . Wysocki" <rjw@rjwysocki.net> Cc: Markus Mayer <mmayer@broadcom.com>, MIPS Linux Kernel List <linux-mips@linux-mips.org>, Power Management List <linux-pm@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: [PATCH 3/3] MIPS: BMIPS: enable CPUfreq Date: Wed, 1 Feb 2017 17:06:01 -0800 Message-Id: <20170202010601.75995-4-code@mmayer.net> In-Reply-To: <20170202010601.75995-1-code@mmayer.net> References: <20170202010601.75995-1-code@mmayer.net> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk

Message ID

20170202010601.75995-4-code@mmayer.net (mailing list archive)

State

Changes Requested, archived

Headers

From: Markus Mayer <code@mmayer.net>
To: Ralf Baechle <ralf@linux-mips.org>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	"Rafael J . Wysocki" <rjw@rjwysocki.net>
Cc: Markus Mayer <mmayer@broadcom.com>,
	MIPS Linux Kernel List <linux-mips@linux-mips.org>,
	Power Management List <linux-pm@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH 3/3] MIPS: BMIPS: enable CPUfreq
Date: Wed,  1 Feb 2017 17:06:01 -0800
Message-Id: <20170202010601.75995-4-code@mmayer.net>
In-Reply-To: <20170202010601.75995-1-code@mmayer.net>
References: <20170202010601.75995-1-code@mmayer.net>
Sender: linux-pm-owner@vger.kernel.org
Precedence: bulk

From: Markus Mayer <mmayer@broadcom.com> Enable all applicable CPUfreq options. Signed-off-by: Markus Mayer <mmayer@broadcom.com> --- arch/mips/configs/bmips_stb_defconfig | 10 ++++++++++ 1 file changed, 10 insertions(+)

Comments

Viresh Kumar Feb. 3, 2017, 4:29 a.m. UTC | #1

On 01-02-17, 17:06, Markus Mayer wrote:
> From: Markus Mayer <mmayer@broadcom.com>
> 
> Enable all applicable CPUfreq options.
> 
> Signed-off-by: Markus Mayer <mmayer@broadcom.com>
> ---
>  arch/mips/configs/bmips_stb_defconfig | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/mips/configs/bmips_stb_defconfig b/arch/mips/configs/bmips_stb_defconfig
> index 4eb5d6e..6fda604 100644
> --- a/arch/mips/configs/bmips_stb_defconfig
> +++ b/arch/mips/configs/bmips_stb_defconfig
> @@ -26,6 +26,16 @@ CONFIG_INET=y
>  # CONFIG_INET_XFRM_MODE_BEET is not set
>  # CONFIG_INET_LRO is not set
>  # CONFIG_INET_DIAG is not set
> +CONFIG_CPU_FREQ=y
> +CONFIG_CPU_FREQ_STAT=y
> +CONFIG_CPU_FREQ_STAT_DETAILS=y
> +CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE=y
> +CONFIG_CPU_FREQ_GOV_PERFORMANCE=y
> +CONFIG_CPU_FREQ_GOV_ONDEMAND=y
> +CONFIG_CPU_FREQ_GOV_POWERSAVE=y
> +CONFIG_CPU_FREQ_GOV_USERSPACE=y
> +CONFIG_CPU_FREQ_GOV_CONSERVATIVE=y
> +CONFIG_BMIPS_CPUFREQ=y
>  CONFIG_CFG80211=y
>  CONFIG_NL80211_TESTMODE=y
>  CONFIG_MAC80211=y

Rebase your stuff over pm/linux-next and you will see some changes here. Also
schedutil is the new governor in town, you must give it a try.

Markus Mayer Feb. 4, 2017, 1 a.m. UTC | #2

On 2 February 2017 at 20:29, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On 01-02-17, 17:06, Markus Mayer wrote:
>> From: Markus Mayer <mmayer@broadcom.com>
>>
>> Enable all applicable CPUfreq options.
>>
>> Signed-off-by: Markus Mayer <mmayer@broadcom.com>
>> ---
>>  arch/mips/configs/bmips_stb_defconfig | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/mips/configs/bmips_stb_defconfig b/arch/mips/configs/bmips_stb_defconfig
>> index 4eb5d6e..6fda604 100644
>> --- a/arch/mips/configs/bmips_stb_defconfig
>> +++ b/arch/mips/configs/bmips_stb_defconfig
>> @@ -26,6 +26,16 @@ CONFIG_INET=y
>>  # CONFIG_INET_XFRM_MODE_BEET is not set
>>  # CONFIG_INET_LRO is not set
>>  # CONFIG_INET_DIAG is not set
>> +CONFIG_CPU_FREQ=y
>> +CONFIG_CPU_FREQ_STAT=y
>> +CONFIG_CPU_FREQ_STAT_DETAILS=y
>> +CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE=y
>> +CONFIG_CPU_FREQ_GOV_PERFORMANCE=y
>> +CONFIG_CPU_FREQ_GOV_ONDEMAND=y
>> +CONFIG_CPU_FREQ_GOV_POWERSAVE=y
>> +CONFIG_CPU_FREQ_GOV_USERSPACE=y
>> +CONFIG_CPU_FREQ_GOV_CONSERVATIVE=y
>> +CONFIG_BMIPS_CPUFREQ=y
>>  CONFIG_CFG80211=y
>>  CONFIG_NL80211_TESTMODE=y
>>  CONFIG_MAC80211=y
>
> Rebase your stuff over pm/linux-next and you will see some changes here. Also
> schedutil is the new governor in town, you must give it a try.

I'll definitely turn on SCHEDUTIL. As for the changes in next, I don't
see any conflicts. My series applied fine on top of linux-next from
https://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git/. Did
I use the wrong tree?

$ git log

commit f81d425292d7d14d45eedc16b9f59066e6640500
Author: Markus Mayer <mmayer@broadcom.com>
Date:   Wed Feb 1 16:45:06 2017 -0800

    MIPS: BMIPS: enable CPUfreq

    Enable all applicable CPUfreq options.

    Signed-off-by: Markus Mayer <mmayer@broadcom.com>

commit 9b71c19f3d9af3867f8ec144305b7f23bfaa42f3
Author: Markus Mayer <mmayer@broadcom.com>
Date:   Wed Feb 1 16:19:01 2017 -0800

    cpufreq: bmips-cpufreq: CPUfreq driver for Broadcom's BMIPS SoCs

    Add the MIPS CPUfreq driver. This driver currently supports CPUfreq on
    BMIPS5xxx-based SoCs.

    Signed-off-by: Markus Mayer <mmayer@broadcom.com>

commit 3a2894802066c8a24da6890bcc2c0b7fae1ccb40
Author: Markus Mayer <mmayer@broadcom.com>
Date:   Wed Feb 1 16:16:55 2017 -0800

    BMIPS: Enable prerequisites for CPUfreq in MIPS Kconfig.

    Turn on CPU_SUPPORTS_CPUFREQ and MIPS_EXTERNAL_TIMER for BMIPS.

    Signed-off-by: Markus Mayer <mmayer@broadcom.com>

commit fd4c9e3a71b4c967731c99525a2e94085a776638
Merge: ba358f6 a9306a6
Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Date:   Sat Feb 4 00:45:12 2017 +0100

    Merge branch 'pm-core-fixes' into linux-next

    * pm-core-fixes:
      PM / runtime: Avoid false-positive warnings from might_sleep_if()

...

Thanks,
-Markus

> --
> viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Viresh Kumar Feb. 6, 2017, 3:35 a.m. UTC | #3

On 03-02-17, 17:00, Markus Mayer wrote:
> On 2 February 2017 at 20:29, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> > On 01-02-17, 17:06, Markus Mayer wrote:
> >> From: Markus Mayer <mmayer@broadcom.com>
> >>
> >> Enable all applicable CPUfreq options.
> >>
> >> Signed-off-by: Markus Mayer <mmayer@broadcom.com>
> >> ---
> >>  arch/mips/configs/bmips_stb_defconfig | 10 ++++++++++
> >>  1 file changed, 10 insertions(+)
> >>
> >> diff --git a/arch/mips/configs/bmips_stb_defconfig b/arch/mips/configs/bmips_stb_defconfig
> >> index 4eb5d6e..6fda604 100644
> >> --- a/arch/mips/configs/bmips_stb_defconfig
> >> +++ b/arch/mips/configs/bmips_stb_defconfig
> >> @@ -26,6 +26,16 @@ CONFIG_INET=y
> >>  # CONFIG_INET_XFRM_MODE_BEET is not set
> >>  # CONFIG_INET_LRO is not set
> >>  # CONFIG_INET_DIAG is not set
> >> +CONFIG_CPU_FREQ=y
> >> +CONFIG_CPU_FREQ_STAT=y
> >> +CONFIG_CPU_FREQ_STAT_DETAILS=y
> >> +CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE=y
> >> +CONFIG_CPU_FREQ_GOV_PERFORMANCE=y
> >> +CONFIG_CPU_FREQ_GOV_ONDEMAND=y
> >> +CONFIG_CPU_FREQ_GOV_POWERSAVE=y
> >> +CONFIG_CPU_FREQ_GOV_USERSPACE=y
> >> +CONFIG_CPU_FREQ_GOV_CONSERVATIVE=y
> >> +CONFIG_BMIPS_CPUFREQ=y
> >>  CONFIG_CFG80211=y
> >>  CONFIG_NL80211_TESTMODE=y
> >>  CONFIG_MAC80211=y
> >
> > Rebase your stuff over pm/linux-next and you will see some changes here. Also
> > schedutil is the new governor in town, you must give it a try.
> 
> I'll definitely turn on SCHEDUTIL. As for the changes in next, I don't
> see any conflicts. My series applied fine on top of linux-next from
> https://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git/. Did
> I use the wrong tree?

No, but you didn't follow the right process. You should use 'make
savedefconfig' to update the defconfig.

The symbol CONFIG_CPU_FREQ_STAT_DETAILS is removed from the kernel
now.

Markus Mayer Feb. 6, 2017, 6:38 a.m. UTC | #4

On 5 February 2017 at 19:35, Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
> On 03-02-17, 17:00, Markus Mayer wrote:
> > On 2 February 2017 at 20:29, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> > > On 01-02-17, 17:06, Markus Mayer wrote:
> > >> From: Markus Mayer <mmayer@broadcom.com>
> > >>
> > >> Enable all applicable CPUfreq options.
> > >>
> > >> Signed-off-by: Markus Mayer <mmayer@broadcom.com>
> > >> ---
> > >>  arch/mips/configs/bmips_stb_defconfig | 10 ++++++++++
> > >>  1 file changed, 10 insertions(+)
> > >>
> > >> diff --git a/arch/mips/configs/bmips_stb_defconfig b/arch/mips/configs/bmips_stb_defconfig
> > >> index 4eb5d6e..6fda604 100644
> > >> --- a/arch/mips/configs/bmips_stb_defconfig
> > >> +++ b/arch/mips/configs/bmips_stb_defconfig
> > >> @@ -26,6 +26,16 @@ CONFIG_INET=y
> > >>  # CONFIG_INET_XFRM_MODE_BEET is not set
> > >>  # CONFIG_INET_LRO is not set
> > >>  # CONFIG_INET_DIAG is not set
> > >> +CONFIG_CPU_FREQ=y
> > >> +CONFIG_CPU_FREQ_STAT=y
> > >> +CONFIG_CPU_FREQ_STAT_DETAILS=y
> > >> +CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE=y
> > >> +CONFIG_CPU_FREQ_GOV_PERFORMANCE=y
> > >> +CONFIG_CPU_FREQ_GOV_ONDEMAND=y
> > >> +CONFIG_CPU_FREQ_GOV_POWERSAVE=y
> > >> +CONFIG_CPU_FREQ_GOV_USERSPACE=y
> > >> +CONFIG_CPU_FREQ_GOV_CONSERVATIVE=y
> > >> +CONFIG_BMIPS_CPUFREQ=y
> > >>  CONFIG_CFG80211=y
> > >>  CONFIG_NL80211_TESTMODE=y
> > >>  CONFIG_MAC80211=y
> > >
> > > Rebase your stuff over pm/linux-next and you will see some changes here. Also
> > > schedutil is the new governor in town, you must give it a try.
> >
> > I'll definitely turn on SCHEDUTIL. As for the changes in next, I don't
> > see any conflicts. My series applied fine on top of linux-next from
> > https://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git/. Did
> > I use the wrong tree?
>
> No, but you didn't follow the right process. You should use 'make
> savedefconfig' to update the defconfig.
>
> The symbol CONFIG_CPU_FREQ_STAT_DETAILS is removed from the kernel
> now.

Okay. Got it. Will do.

-Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

diff --git a/arch/mips/configs/bmips_stb_defconfig b/arch/mips/configs/bmips_stb_defconfig
index 4eb5d6e..6fda604 100644
--- a/arch/mips/configs/bmips_stb_defconfig
+++ b/arch/mips/configs/bmips_stb_defconfig
@@ -26,6 +26,16 @@  CONFIG_INET=y
 # CONFIG_INET_XFRM_MODE_BEET is not set
 # CONFIG_INET_LRO is not set
 # CONFIG_INET_DIAG is not set
+CONFIG_CPU_FREQ=y
+CONFIG_CPU_FREQ_STAT=y
+CONFIG_CPU_FREQ_STAT_DETAILS=y
+CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE=y
+CONFIG_CPU_FREQ_GOV_PERFORMANCE=y
+CONFIG_CPU_FREQ_GOV_ONDEMAND=y
+CONFIG_CPU_FREQ_GOV_POWERSAVE=y
+CONFIG_CPU_FREQ_GOV_USERSPACE=y
+CONFIG_CPU_FREQ_GOV_CONSERVATIVE=y
+CONFIG_BMIPS_CPUFREQ=y
 CONFIG_CFG80211=y
 CONFIG_NL80211_TESTMODE=y
 CONFIG_MAC80211=y

[3/3] MIPS: BMIPS: enable CPUfreq

Commit Message

Comments

Patch