diff mbox

[2/2] dt-bindings: power/supply: Add support for xmega16d4-battery

Message ID 20170223173812.10740-2-enric.balletbo@collabora.com (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Enric Balletbo i Serra Feb. 23, 2017, 5:38 p.m. UTC
Add the documentation for binding of Toby Churchill SBS battery monitor
driver. The device is connected via SPI and is able to report different
battery characteristics.

Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---
 .../devicetree/bindings/power/supply/xmega16d4-battery.txt   | 12 ++++++++++++
 1 file changed, 12 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/supply/xmega16d4-battery.txt

Comments

Enric Balletbo Serra Feb. 23, 2017, 5:44 p.m. UTC | #1
Ooops, sorry I forget to add the device tree maintainers so

CC'ing Rob Herring and Mark Rutland


2017-02-23 18:38 GMT+01:00 Enric Balletbo i Serra
<enric.balletbo@collabora.com>:
> Add the documentation for binding of Toby Churchill SBS battery monitor
> driver. The device is connected via SPI and is able to report different
> battery characteristics.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
>  .../devicetree/bindings/power/supply/xmega16d4-battery.txt   | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/power/supply/xmega16d4-battery.txt
>
> diff --git a/Documentation/devicetree/bindings/power/supply/xmega16d4-battery.txt b/Documentation/devicetree/bindings/power/supply/xmega16d4-battery.txt
> new file mode 100644
> index 0000000..c76db67
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/xmega16d4-battery.txt
> @@ -0,0 +1,12 @@
> +Binding for the Toby Churchill SBS battery monitor
> +
> +Required properties :
> + - compatible : "tcl,xmega16d4-battery"
> +
> +Example:
> +
> +       battery: smart-battery@0 {
> +               compatible = "tcl,xmega16d4-battery";
> +               reg = <0>;
> +               spi-max-frequency = <100000>;
> +       };
> --
> 2.9.3
>
Sebastian Reichel March 15, 2017, 9:54 p.m. UTC | #2
Hi,

On Thu, Feb 23, 2017 at 06:44:59PM +0100, Enric Balletbo Serra wrote:
> Ooops, sorry I forget to add the device tree maintainers so
> 
> CC'ing Rob Herring and Mark Rutland
> 
> 
> 2017-02-23 18:38 GMT+01:00 Enric Balletbo i Serra
> <enric.balletbo@collabora.com>:
> > Add the documentation for binding of Toby Churchill SBS battery monitor
> > driver. The device is connected via SPI and is able to report different
> > battery characteristics.
> >
> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> > ---
> >  .../devicetree/bindings/power/supply/xmega16d4-battery.txt   | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/power/supply/xmega16d4-battery.txt
> >
> > diff --git a/Documentation/devicetree/bindings/power/supply/xmega16d4-battery.txt b/Documentation/devicetree/bindings/power/supply/xmega16d4-battery.txt
> > new file mode 100644
> > index 0000000..c76db67
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/power/supply/xmega16d4-battery.txt
> > @@ -0,0 +1,12 @@
> > +Binding for the Toby Churchill SBS battery monitor
> > +
> > +Required properties :
> > + - compatible : "tcl,xmega16d4-battery"

The same naming issue, that I mentioned in the driver patch applies
here. Also you should reference the standard spi binding document
for properties like spi-max-frequency.

-- Sebastian

> > +Example:
> > +
> > +       battery: smart-battery@0 {
> > +               compatible = "tcl,xmega16d4-battery";
> > +               reg = <0>;
> > +               spi-max-frequency = <100000>;
> > +       };
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/power/supply/xmega16d4-battery.txt b/Documentation/devicetree/bindings/power/supply/xmega16d4-battery.txt
new file mode 100644
index 0000000..c76db67
--- /dev/null
+++ b/Documentation/devicetree/bindings/power/supply/xmega16d4-battery.txt
@@ -0,0 +1,12 @@ 
+Binding for the Toby Churchill SBS battery monitor
+
+Required properties :
+ - compatible : "tcl,xmega16d4-battery"
+
+Example:
+
+	battery: smart-battery@0 {
+		compatible = "tcl,xmega16d4-battery";
+		reg = <0>;
+		spi-max-frequency = <100000>;
+	};