diff mbox

cpufreq: sfi: make freq_table static

Message ID 20170615095559.21973-1-colin.king@canonical.com (mailing list archive)
State Mainlined
Delegated to: Rafael Wysocki
Headers show

Commit Message

Colin King June 15, 2017, 9:55 a.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

pointer freq_table can be made static as it does not need to be in
global scope.

Cleans up sparse warning:
"symbol 'freq_table' was not declared. Should it be static?"

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/cpufreq/sfi-cpufreq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Viresh Kumar June 15, 2017, 9:58 a.m. UTC | #1 
On 15-06-17, 10:55, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> pointer freq_table can be made static as it does not need to be in
> global scope.
> 
> Cleans up sparse warning:
> "symbol 'freq_table' was not declared. Should it be static?"
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/cpufreq/sfi-cpufreq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/sfi-cpufreq.c b/drivers/cpufreq/sfi-cpufreq.c
> index 992ce6f9abec..3779742f86e3 100644
> --- a/drivers/cpufreq/sfi-cpufreq.c
> +++ b/drivers/cpufreq/sfi-cpufreq.c
> @@ -24,7 +24,7 @@
>  
>  #include <asm/msr.h>
>  
> -struct cpufreq_frequency_table *freq_table;
> +static struct cpufreq_frequency_table *freq_table;
>  static struct sfi_freq_table_entry *sfi_cpufreq_array;
>  static int num_freq_table_entries;

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
diff mbox

Patch

diff --git a/drivers/cpufreq/sfi-cpufreq.c b/drivers/cpufreq/sfi-cpufreq.c
index 992ce6f9abec..3779742f86e3 100644
--- a/drivers/cpufreq/sfi-cpufreq.c
+++ b/drivers/cpufreq/sfi-cpufreq.c
@@ -24,7 +24,7 @@ 
 
 #include <asm/msr.h>
 
-struct cpufreq_frequency_table *freq_table;
+static struct cpufreq_frequency_table *freq_table;
 static struct sfi_freq_table_entry *sfi_cpufreq_array;
 static int num_freq_table_entries;