cpuidle: Convert to using %pOF instead of full_name

Commit Message

Rob Herring (Arm) July 18, 2017, 9:42 p.m. UTC

Now that we have a custom printf format specifier, convert users of
full_name to use %pOF instead. This is preparation to remove storing
of the full path string for each node.

Signed-off-by: Rob Herring <[e-mail]>
Cc: "Rafael J. Wysocki" <[e-mail]>
Cc: Daniel Lezcano <[e-mail]>
Cc: [e-mail]
---
 drivers/cpuidle/dt_idle_states.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

--
2.11.0

Comments

Rob Herring (Arm) Aug. 23, 2017, 6:14 p.m. UTC | #1

On Tue, Jul 18, 2017 at 4:42 PM, Rob Herring <[e-mail]> wrote:
> Now that we have a custom printf format specifier, convert users of
> full_name to use %pOF instead. This is preparation to remove storing
> of the full path string for each node.
>
> Signed-off-by: Rob Herring <[e-mail]>
> Cc: "Rafael J. Wysocki" <[e-mail]>
> Cc: Daniel Lezcano <[e-mail]>
> Cc: [e-mail]
> ---
>  drivers/cpuidle/dt_idle_states.c | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)

Rafael, Ping. Please apply this one and 2 others for cpufreq and
PM-domains which haven't been applied yet.

Rob

Rafael J. Wysocki Aug. 23, 2017, 8:34 p.m. UTC | #2

On Wed, Aug 23, 2017 at 8:14 PM, Rob Herring <[e-mail]> wrote:
> On Tue, Jul 18, 2017 at 4:42 PM, Rob Herring <[e-mail]> wrote:
>> Now that we have a custom printf format specifier, convert users of
>> full_name to use %pOF instead. This is preparation to remove storing
>> of the full path string for each node.
>>
>> Signed-off-by: Rob Herring <[e-mail]>
>> Cc: "Rafael J. Wysocki" <[e-mail]>
>> Cc: Daniel Lezcano <[e-mail]>
>> Cc: [e-mail]
>> ---
>>  drivers/cpuidle/dt_idle_states.c | 20 ++++++++++----------
>>  1 file changed, 10 insertions(+), 10 deletions(-)
>
> Rafael, Ping. Please apply this one and 2 others for cpufreq and
> PM-domains which haven't been applied yet.

I thought that these would go in through the DT tree.

I'll try to find them, but next time please make it clear how you want
to route things.

Thanks,
Rafael

Rob Herring (Arm) Aug. 23, 2017, 8:49 p.m. UTC | #3

On Wed, Aug 23, 2017 at 3:34 PM, Rafael J. Wysocki <[e-mail]> wrote:
> On Wed, Aug 23, 2017 at 8:14 PM, Rob Herring <[e-mail]> wrote:
>> On Tue, Jul 18, 2017 at 4:42 PM, Rob Herring <[e-mail]> wrote:
>>> Now that we have a custom printf format specifier, convert users of
>>> full_name to use %pOF instead. This is preparation to remove storing
>>> of the full path string for each node.
>>>
>>> Signed-off-by: Rob Herring <[e-mail]>
>>> Cc: "Rafael J. Wysocki" <[e-mail]>
>>> Cc: Daniel Lezcano <[e-mail]>
>>> Cc: [e-mail]
>>> ---
>>>  drivers/cpuidle/dt_idle_states.c | 20 ++++++++++----------
>>>  1 file changed, 10 insertions(+), 10 deletions(-)
>>
>> Rafael, Ping. Please apply this one and 2 others for cpufreq and
>> PM-domains which haven't been applied yet.
>
> I thought that these would go in through the DT tree.
>
> I'll try to find them, but next time please make it clear how you want
> to route things.

Sorry, I thought addressed TO you and not in a series was enough to imply that.

Rob

Rafael J. Wysocki Aug. 23, 2017, 8:53 p.m. UTC | #4

On Wednesday, August 23, 2017 10:49:00 PM CEST Rob Herring wrote:
> On Wed, Aug 23, 2017 at 3:34 PM, Rafael J. Wysocki <[e-mail]> wrote:
> > On Wed, Aug 23, 2017 at 8:14 PM, Rob Herring <[e-mail]> wrote:
> >> On Tue, Jul 18, 2017 at 4:42 PM, Rob Herring <[e-mail]> wrote:
> >>> Now that we have a custom printf format specifier, convert users of
> >>> full_name to use %pOF instead. This is preparation to remove storing
> >>> of the full path string for each node.
> >>>
> >>> Signed-off-by: Rob Herring <[e-mail]>
> >>> Cc: "Rafael J. Wysocki" <[e-mail]>
> >>> Cc: Daniel Lezcano <[e-mail]>
> >>> Cc: [e-mail]
> >>> ---
> >>>  drivers/cpuidle/dt_idle_states.c | 20 ++++++++++----------
> >>>  1 file changed, 10 insertions(+), 10 deletions(-)
> >>
> >> Rafael, Ping. Please apply this one and 2 others for cpufreq and
> >> PM-domains which haven't been applied yet.
> >
> > I thought that these would go in through the DT tree.
> >
> > I'll try to find them, but next time please make it clear how you want
> > to route things.
> 
> Sorry, I thought addressed TO you and not in a series was enough to imply that.

Well, Patchwork doesn't tell me who the patch was addressed to. :-)

Thanks,
Rafael

Patch

diff --git a/drivers/cpuidle/dt_idle_states.c b/drivers/cpuidle/dt_idle_states.c
index ae8eb0359889..bafd4dbf55d4 100644
--- a/drivers/cpuidle/dt_idle_states.c
+++ b/drivers/cpuidle/dt_idle_states.c
@@ -53,16 +53,16 @@  static int init_state_node(struct cpuidle_state *idle_state,
 		err = of_property_read_u32(state_node, "entry-latency-us",
 					   &entry_latency);
 		if (err) {
-			pr_debug(" * %s missing entry-latency-us property\n",
-				 state_node->full_name);
+			pr_debug(" * %pOF missing entry-latency-us property\n",
+				 state_node);
 			return -EINVAL;
 		}

 		err = of_property_read_u32(state_node, "exit-latency-us",
 					   &exit_latency);
 		if (err) {
-			pr_debug(" * %s missing exit-latency-us property\n",
-				 state_node->full_name);
+			pr_debug(" * %pOF missing exit-latency-us property\n",
+				 state_node);
 			return -EINVAL;
 		}
 		/*
@@ -75,8 +75,8 @@  static int init_state_node(struct cpuidle_state *idle_state,
 	err = of_property_read_u32(state_node, "min-residency-us",
 				   &idle_state->target_residency);
 	if (err) {
-		pr_debug(" * %s missing min-residency-us property\n",
-			     state_node->full_name);
+		pr_debug(" * %pOF missing min-residency-us property\n",
+			     state_node);
 		return -EINVAL;
 	}

@@ -186,8 +186,8 @@  int dt_init_idle_driver(struct cpuidle_driver *drv,
 		}

 		if (!idle_state_valid(state_node, i, cpumask)) {
-			pr_warn("%s idle state not valid, bailing out\n",
-				state_node->full_name);
+			pr_warn("%pOF idle state not valid, bailing out\n",
+				state_node);
 			err = -EINVAL;
 			break;
 		}
@@ -200,8 +200,8 @@  int dt_init_idle_driver(struct cpuidle_driver *drv,
 		idle_state = &drv->states[state_idx++];
 		err = init_state_node(idle_state, matches, state_node);
 		if (err) {
-			pr_err("Parsing idle state node %s failed with err %d\n",
-			       state_node->full_name, err);
+			pr_err("Parsing idle state node %pOF failed with err %d\n",
+			       state_node, err);
 			err = -EINVAL;
 			break;
 		}