diff mbox

typec: tcpm: fix ptr_ret.cocci warnings

Message ID 20171220152456.GA73368@lkp-g5 (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

kernel test robot Dec. 20, 2017, 3:24 p.m. UTC
From: Fengguang Wu <fengguang.wu@intel.com>

drivers/usb/typec/tcpm.c:4396:1-3: WARNING: PTR_ERR_OR_ZERO can be used


 Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Generated by: scripts/coccinelle/api/ptr_ret.cocci

Fixes: 91886adfce05 ("typec: tcpm: Represent source supply through power_supply class")
CC: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 tcpm.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
diff mbox

Patch

--- a/drivers/usb/typec/tcpm.c
+++ b/drivers/usb/typec/tcpm.c
@@ -4393,10 +4393,7 @@  int devm_tcpm_psy_register(struct tcpm_p
 
 	port->psy = devm_power_supply_register(port->dev, &port->psy_desc,
 					       &psy_cfg);
-	if (IS_ERR(port->psy))
-		return PTR_ERR(port->psy);
-
-	return 0;
+	return PTR_ERR_OR_ZERO(port->psy);
 }
 
 struct tcpm_port *tcpm_register_port(struct device *dev, struct tcpc_dev *tcpc)