diff mbox

cpuidle: Enable coupled cpuidle support on Exynos3250 platform

Message ID 20180313150451.5525-1-m.szyprowski@samsung.com (mailing list archive)
State Mainlined
Delegated to: Rafael Wysocki
Headers show

Commit Message

Marek Szyprowski March 13, 2018, 3:04 p.m. UTC
All the needed code has been already merged to mach-exynos core in
commit af9971144dde ("ARM: EXYNOS: add coupled cpuidle support for
Exynos3250"), so enable support for coupled variant also for Exynos3250
SoCs.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
This change was initially submitted with the mentioned commit:
https://lkml.org/lkml/2015/2/20/321
For some reasons it has been separated from it and then it has been
forgotten. This is patch brings it back to live.

Tested on Exynos3250 ARTIK5 (520) development board.
---
 drivers/cpuidle/cpuidle-exynos.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Krzysztof Kozlowski March 13, 2018, 3:13 p.m. UTC | #1
On Tue, Mar 13, 2018 at 4:04 PM, Marek Szyprowski
<m.szyprowski@samsung.com> wrote:
> All the needed code has been already merged to mach-exynos core in
> commit af9971144dde ("ARM: EXYNOS: add coupled cpuidle support for
> Exynos3250"), so enable support for coupled variant also for Exynos3250
> SoCs.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> This change was initially submitted with the mentioned commit:
> https://lkml.org/lkml/2015/2/20/321
> For some reasons it has been separated from it and then it has been
> forgotten. This is patch brings it back to live.
>
> Tested on Exynos3250 ARTIK5 (520) development board.
> ---
>  drivers/cpuidle/cpuidle-exynos.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Acked-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof
Bartlomiej Zolnierkiewicz March 13, 2018, 4:01 p.m. UTC | #2
On Tuesday, March 13, 2018 04:04:51 PM Marek Szyprowski wrote:
> All the needed code has been already merged to mach-exynos core in
> commit af9971144dde ("ARM: EXYNOS: add coupled cpuidle support for
> Exynos3250"), so enable support for coupled variant also for Exynos3250
> SoCs.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> This change was initially submitted with the mentioned commit:
> https://lkml.org/lkml/2015/2/20/321
> For some reasons it has been separated from it and then it has been
> forgotten. This is patch brings it back to live.
> 
> Tested on Exynos3250 ARTIK5 (520) development board.

Thanks for spotting and fixing this.

Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

> ---
>  drivers/cpuidle/cpuidle-exynos.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/cpuidle/cpuidle-exynos.c b/drivers/cpuidle/cpuidle-exynos.c
> index 00cd129b10a4..0171a6e190d7 100644
> --- a/drivers/cpuidle/cpuidle-exynos.c
> +++ b/drivers/cpuidle/cpuidle-exynos.c
> @@ -117,7 +117,8 @@ static int exynos_cpuidle_probe(struct platform_device *pdev)
>  	int ret;
>  
>  	if (IS_ENABLED(CONFIG_SMP) &&
> -	    of_machine_is_compatible("samsung,exynos4210")) {
> +	    (of_machine_is_compatible("samsung,exynos4210") ||
> +	     of_machine_is_compatible("samsung,exynos3250"))) {
>  		exynos_cpuidle_pdata = pdev->dev.platform_data;
>  
>  		ret = cpuidle_register(&exynos_coupled_idle_driver,

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
Rafael J. Wysocki March 22, 2018, 11:16 p.m. UTC | #3
On Tuesday, March 13, 2018 5:01:07 PM CET Bartlomiej Zolnierkiewicz wrote:
> On Tuesday, March 13, 2018 04:04:51 PM Marek Szyprowski wrote:
> > All the needed code has been already merged to mach-exynos core in
> > commit af9971144dde ("ARM: EXYNOS: add coupled cpuidle support for
> > Exynos3250"), so enable support for coupled variant also for Exynos3250
> > SoCs.
> > 
> > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> > ---
> > This change was initially submitted with the mentioned commit:
> > https://lkml.org/lkml/2015/2/20/321
> > For some reasons it has been separated from it and then it has been
> > forgotten. This is patch brings it back to live.
> > 
> > Tested on Exynos3250 ARTIK5 (520) development board.
> 
> Thanks for spotting and fixing this.
> 
> Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> 
> > ---
> >  drivers/cpuidle/cpuidle-exynos.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/cpuidle/cpuidle-exynos.c b/drivers/cpuidle/cpuidle-exynos.c
> > index 00cd129b10a4..0171a6e190d7 100644
> > --- a/drivers/cpuidle/cpuidle-exynos.c
> > +++ b/drivers/cpuidle/cpuidle-exynos.c
> > @@ -117,7 +117,8 @@ static int exynos_cpuidle_probe(struct platform_device *pdev)
> >  	int ret;
> >  
> >  	if (IS_ENABLED(CONFIG_SMP) &&
> > -	    of_machine_is_compatible("samsung,exynos4210")) {
> > +	    (of_machine_is_compatible("samsung,exynos4210") ||
> > +	     of_machine_is_compatible("samsung,exynos3250"))) {
> >  		exynos_cpuidle_pdata = pdev->dev.platform_data;
> >  
> >  		ret = cpuidle_register(&exynos_coupled_idle_driver,
> 

Applied, thanks!
diff mbox

Patch

diff --git a/drivers/cpuidle/cpuidle-exynos.c b/drivers/cpuidle/cpuidle-exynos.c
index 00cd129b10a4..0171a6e190d7 100644
--- a/drivers/cpuidle/cpuidle-exynos.c
+++ b/drivers/cpuidle/cpuidle-exynos.c
@@ -117,7 +117,8 @@  static int exynos_cpuidle_probe(struct platform_device *pdev)
 	int ret;
 
 	if (IS_ENABLED(CONFIG_SMP) &&
-	    of_machine_is_compatible("samsung,exynos4210")) {
+	    (of_machine_is_compatible("samsung,exynos4210") ||
+	     of_machine_is_compatible("samsung,exynos3250"))) {
 		exynos_cpuidle_pdata = pdev->dev.platform_data;
 
 		ret = cpuidle_register(&exynos_coupled_idle_driver,