From patchwork Wed May 9 08:40:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Juri Lelli X-Patchwork-Id: 10388713 X-Patchwork-Delegate: rjw@sisk.pl Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3A6CE60170 for ; Wed, 9 May 2018 08:43:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2EEE3283C9 for ; Wed, 9 May 2018 08:43:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 23B9528E3F; Wed, 9 May 2018 08:43:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A81E7283C9 for ; Wed, 9 May 2018 08:43:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934245AbeEIIlX (ORCPT ); Wed, 9 May 2018 04:41:23 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:41360 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933882AbeEIIlU (ORCPT ); Wed, 9 May 2018 04:41:20 -0400 Received: by mail-wr0-f194.google.com with SMTP id g21-v6so34840914wrb.8 for ; Wed, 09 May 2018 01:41:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=1bDAyDq/wK1sAhOL6IXAfBHa20gNcXPjGEmbfnJ3XJg=; b=pyy51xvWCugfs2hnvgnxtPP/w+LQ3nsXg7/TY4gdJY/sbaXP98T/8viFJy84HI/NB8 +0H1waO2bczErGDxD1FXkgt9OPzSzmTFCgPDb3sitTAhfsoMUj9KuZ3R6gd3vteP9jg1 qsDWmPf6FsELWUpzf4cNlB2PQTl5SUJkgzOn0rcylrpcuOrMB5cgPvHD42J+UlnFzdw9 HAIapAGjQvlczgpRQ2UeV1R0LFqRWyqcA8BE5YbmzeyGMcQCiyMMefusYsWgfxfh7h9F hV8NRRDtVFYOaTtGEW0OefAKK0VJ5hDX5ACpGS0iiLl5bp1CCKG+fvfVlM2rtYrrxUGV D/Ug== X-Gm-Message-State: ALQs6tCllwwTn7baBOEGfYCn7fUgDGWRRcO51pCh9wDvFZ3WNppGFcUy A5DnGhWWnSkDg7jWs1h7ca/eLw== X-Google-Smtp-Source: AB8JxZp6/CHp9u2rcQxusYOZ9rwMePdOSi1MZk82gnhcCd/Q7ziHoWW6DWTD0nE2B3xuBRSIkV3+sw== X-Received: by 2002:adf:85b8:: with SMTP id 53-v6mr37737379wrt.31.1525855278974; Wed, 09 May 2018 01:41:18 -0700 (PDT) Received: from localhost.localdomain.com ([151.15.207.48]) by smtp.gmail.com with ESMTPSA id p35-v6sm36363093wrb.12.2018.05.09.01.41.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 09 May 2018 01:41:18 -0700 (PDT) From: Juri Lelli To: rafael.j.wysocki@intel.com, peterz@infradead.org Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Juri Lelli , Ingo Molnar , Viresh Kumar , Claudio Scordino , Luca Abeni Subject: [PATCH] kernel/sched/cpufreq_schedutil: remove stale comment Date: Wed, 9 May 2018 10:40:51 +0200 Message-Id: <20180509084051.12107-1-juri.lelli@redhat.com> X-Mailer: git-send-email 2.14.3 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP After commit 794a56ebd9a57 ("sched/cpufreq: Change the worker kthread to SCHED_DEADLINE") schedutil kthreads are "ignored" for a clock frequency selection point of view, so the potential corner case for RT tasks is not possible at all now. Remove the stale comment mentioning it. Signed-off-by: Juri Lelli Cc: Ingo Molnar Cc: Peter Zijlstra Cc: "Rafael J. Wysocki" Cc: Viresh Kumar Cc: Claudio Scordino Cc: Luca Abeni --- kernel/sched/cpufreq_schedutil.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c index d2c6083304b4..23ef19070137 100644 --- a/kernel/sched/cpufreq_schedutil.c +++ b/kernel/sched/cpufreq_schedutil.c @@ -396,19 +396,6 @@ static void sugov_irq_work(struct irq_work *irq_work) sg_policy = container_of(irq_work, struct sugov_policy, irq_work); - /* - * For RT tasks, the schedutil governor shoots the frequency to maximum. - * Special care must be taken to ensure that this kthread doesn't result - * in the same behavior. - * - * This is (mostly) guaranteed by the work_in_progress flag. The flag is - * updated only at the end of the sugov_work() function and before that - * the schedutil governor rejects all other frequency scaling requests. - * - * There is a very rare case though, where the RT thread yields right - * after the work_in_progress flag is cleared. The effects of that are - * neglected for now. - */ kthread_queue_work(&sg_policy->worker, &sg_policy->work); }