| Message ID | 20180703234705.227473-10-mka@chromium.org (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On 03-07-18, 16:47, Matthias Kaehlcke wrote: > The Throttler is used for non-thermal throttling of system components > like CPUs or devfreq devices. > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> > -- > Changes in v5: > - patch added to the series (replacing "dt-bindings: PM / OPP: add > opp-throttlers property") > --- > .../devicetree/bindings/misc/throttler.txt | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > create mode 100644 Documentation/devicetree/bindings/misc/throttler.txt > > diff --git a/Documentation/devicetree/bindings/misc/throttler.txt b/Documentation/devicetree/bindings/misc/throttler.txt > new file mode 100644 > index 000000000000..2ea80c62dbe1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/misc/throttler.txt > @@ -0,0 +1,13 @@ > +Throttler driver > + > +The Throttler is used for non-thermal throttling of system components like > +CPUs or devfreq devices. > + > +Required properties: > +- throttler-opps Array of OPP-v2 phandles with the OPPs used for > + throttling. > + > +Example: > + throttler { > + throttler-opps = <&cpu0_opp03, &cpu1_opp02, &gpu_opp03>; > + }; All you do with these phandles for now is that you parse them and read "opp-hz" value. For that purpose current bindings look sufficient. From OPP point of view: Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Hi Matthias, On 2018년 07월 04일 08:47, Matthias Kaehlcke wrote: > The Throttler is used for non-thermal throttling of system components > like CPUs or devfreq devices. > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> > -- > Changes in v5: > - patch added to the series (replacing "dt-bindings: PM / OPP: add > opp-throttlers property") > --- > .../devicetree/bindings/misc/throttler.txt | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > create mode 100644 Documentation/devicetree/bindings/misc/throttler.txt > > diff --git a/Documentation/devicetree/bindings/misc/throttler.txt b/Documentation/devicetree/bindings/misc/throttler.txt > new file mode 100644 > index 000000000000..2ea80c62dbe1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/misc/throttler.txt > @@ -0,0 +1,13 @@ > +Throttler driver > + > +The Throttler is used for non-thermal throttling of system components like > +CPUs or devfreq devices. > + > +Required properties: > +- throttler-opps Array of OPP-v2 phandles with the OPPs used for > + throttling. > + > +Example: > + throttler { > + throttler-opps = <&cpu0_opp03, &cpu1_opp02, &gpu_opp03>; > + }; > If possible, I hope the more detailed example for "cpu0_opp03, &cpu1_opp02, &gpu_opp03" because I'm confusing the meaning of 'cpu0_opp03' phandle. cpu0_opp03 indicates the only one specific OPP entry among set of OPP entries of CPU0 cpufreq? or cpu0_opp03 indicates the set of OPP entries for CPU0 cpufreq ?
Hi Chanwoo, On Wed, Aug 01, 2018 at 05:27:57PM +0900, Chanwoo Choi wrote: > Hi Matthias, > > On 2018년 07월 04일 08:47, Matthias Kaehlcke wrote: > > The Throttler is used for non-thermal throttling of system components > > like CPUs or devfreq devices. > > > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> > > If possible, I hope the more detailed example for "cpu0_opp03, &cpu1_opp02, &gpu_opp03" > because I'm confusing the meaning of 'cpu0_opp03' phandle. I omitted the OPP definitions to avoid cluttering the example. I'm happy to add them if DT folks also think it would add value. > cpu0_opp03 indicates the only one specific OPP entry among set of > OPP entries of CPU0 cpufreq? or cpu0_opp03 indicates the set of OPP > entries for CPU0 cpufreq ? cpu0_opp03 and the other phandles are specific OPP entries, that indicate the throttler which frequencies/OPPs should be used for throttling. For devices/CPUs with multiple levels of throttling multiple entries from its OPP set are listed. In the example a single level of throttling is used for all devices/CPUs.
diff --git a/Documentation/devicetree/bindings/misc/throttler.txt b/Documentation/devicetree/bindings/misc/throttler.txt new file mode 100644 index 000000000000..2ea80c62dbe1 --- /dev/null +++ b/Documentation/devicetree/bindings/misc/throttler.txt @@ -0,0 +1,13 @@ +Throttler driver + +The Throttler is used for non-thermal throttling of system components like +CPUs or devfreq devices. + +Required properties: +- throttler-opps Array of OPP-v2 phandles with the OPPs used for + throttling. + +Example: + throttler { + throttler-opps = <&cpu0_opp03, &cpu1_opp02, &gpu_opp03>; + };
The Throttler is used for non-thermal throttling of system components like CPUs or devfreq devices. Signed-off-by: Matthias Kaehlcke <mka@chromium.org> -- Changes in v5: - patch added to the series (replacing "dt-bindings: PM / OPP: add opp-throttlers property") --- .../devicetree/bindings/misc/throttler.txt | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100644 Documentation/devicetree/bindings/misc/throttler.txt