From patchwork Tue Jul 3 23:46:54 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthias Kaehlcke X-Patchwork-Id: 10505657 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id F222660225 for ; Tue, 3 Jul 2018 23:50:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E53A528B8C for ; Tue, 3 Jul 2018 23:50:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D982C28B1B; Tue, 3 Jul 2018 23:50:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 86DF228A22 for ; Tue, 3 Jul 2018 23:50:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932163AbeGCXuY (ORCPT ); Tue, 3 Jul 2018 19:50:24 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:40538 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752197AbeGCXrY (ORCPT ); Tue, 3 Jul 2018 19:47:24 -0400 Received: by mail-pf0-f194.google.com with SMTP id z24-v6so1728249pfe.7 for ; Tue, 03 Jul 2018 16:47:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=t//gmzpIVvV+WQDfrai/menR07GoTdBew0ehvnbR71Y=; b=CyQZ/RaB8NNEzVUFNn7eYBzJ/fSOppwJQAduGd4YIEpPdZ8ctgj/MR7WKn9JP4+ySr /dPHbAXSSKSBRu276dwaBxvbAGS2aRxEHOsiR9z14atXJs0UImO3Bhq/F/4uXSm2rDAp zIssmwnB9ChNcuoR9RDtoh2i5oeNLMFAYFj5fy5NQLpAUk8FSwmxZOj3PweioOO02KhE IXwVSIO5MMoX9F4fGFMFl+lbHo88raGcBikn9X1G9JGrOyU5SHOEEW/QC5ylokci5gY5 OZIT7OXk/TW28EnWi5fb9YHEQcNg3WkB+JFDbp6PT5LsgkXO/I+0HmGkNsQtLEWg5vT+ x4gQ== X-Gm-Message-State: APt69E1ceLLKC9oWLCPpNpLRjfNfj21fSWbgeGiIyfq82zxfOdJRj3P3 Uz79g0Q1g1oA1z7gku7Sn0Tb6w== X-Google-Smtp-Source: AAOMgpf6L4gCr+Ua9dg/5haEcBWNbzIbarE12TlOgnXHGGQKDnoxVO4UirfsEbv4MhYWzSZ127Pcdg== X-Received: by 2002:a62:4a51:: with SMTP id x78-v6mr31824908pfa.45.1530661643730; Tue, 03 Jul 2018 16:47:23 -0700 (PDT) Received: from mka.mtv.corp.google.com ([2620:0:1000:1501:8e2d:4727:1211:622]) by smtp.gmail.com with ESMTPSA id l85-v6sm6608562pfk.79.2018.07.03.16.47.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Jul 2018 16:47:22 -0700 (PDT) From: Matthias Kaehlcke To: MyungJoo Ham Cc: Kyungmin Park , Chanwoo Choi , Arnd Bergmann , Greg Kroah-Hartman , Rob Herring , Mark Rutland , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Norris , Douglas Anderson , Enric Balletbo i Serra , "Rafael J . Wysocki" , Viresh Kumar , Lee Jones , Benson Leung , Olof Johansson , Matthias Kaehlcke Subject: [PATCH v5 01/12] PM / devfreq: Init user limits from OPP limits, not viceversa Date: Tue, 3 Jul 2018 16:46:54 -0700 Message-Id: <20180703234705.227473-2-mka@chromium.org> X-Mailer: git-send-email 2.18.0.203.gfac676dfb9-goog In-Reply-To: <20180703234705.227473-1-mka@chromium.org> References: <20180703234705.227473-1-mka@chromium.org> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Commit ab8f58ad72c4 ("PM / devfreq: Set min/max_freq when adding the devfreq device") introduced the initialization of the user limits min/max_freq from the lowest/highest available OPPs. Later commit f1d981eaecf8 ("PM / devfreq: Use the available min/max frequency") added scaling_min/max_freq, which actually represent the frequencies of the lowest/highest available OPP. scaling_min/ max_freq are initialized with the values from min/max_freq, which is totally correct in the context, but a bit awkward to read. Swap the initialization and assign scaling_min/max_freq with the OPP freqs and then the user limts min/max_freq with scaling_min/ max_freq. Needless to say that this change is a NOP, intended to improve readability. Signed-off-by: Matthias Kaehlcke Reviewed-by: Chanwoo Choi Reviewed-by: Brian Norris Acked-by: MyungJoo Ham --- Changes in v5: - none Changes in v4: - added 'Reviewed-by: Brian Norris ' tag Changes in v3: - none Changes in v2: - added 'Reviewed-by: Chanwoo Choi ' tag --- drivers/devfreq/devfreq.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c index fe2af6aa88fc..0057ef5b0a98 100644 --- a/drivers/devfreq/devfreq.c +++ b/drivers/devfreq/devfreq.c @@ -604,21 +604,21 @@ struct devfreq *devfreq_add_device(struct device *dev, mutex_lock(&devfreq->lock); } - devfreq->min_freq = find_available_min_freq(devfreq); - if (!devfreq->min_freq) { + devfreq->scaling_min_freq = find_available_min_freq(devfreq); + if (!devfreq->scaling_min_freq) { mutex_unlock(&devfreq->lock); err = -EINVAL; goto err_dev; } - devfreq->scaling_min_freq = devfreq->min_freq; + devfreq->min_freq = devfreq->scaling_min_freq; - devfreq->max_freq = find_available_max_freq(devfreq); - if (!devfreq->max_freq) { + devfreq->scaling_max_freq = find_available_max_freq(devfreq); + if (!devfreq->scaling_max_freq) { mutex_unlock(&devfreq->lock); err = -EINVAL; goto err_dev; } - devfreq->scaling_max_freq = devfreq->max_freq; + devfreq->max_freq = devfreq->scaling_max_freq; dev_set_name(&devfreq->dev, "devfreq%d", atomic_inc_return(&devfreq_no));