| Message ID | 20181218183241.12830-4-jcrouse@codeaurora.org (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | arm64: dts: Add sdm845 GPU/GMU and SMMU | expand |
Hi, On Tue, Dec 18, 2018 at 10:32 AM Jordan Crouse <jcrouse@codeaurora.org> wrote: > > 'interrupt-names' shouldn't be used in cases when there is only > one interrupt and it is not otherwise used in the driver. > > Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org> > --- > arch/arm/boot/dts/qcom-apq8064.dtsi | 1 - > 1 file changed, 1 deletion(-) Looks good to me. It should be noted that Andy shouldn't land this until he has a tree that contains ("drm/msm/gpu: Remove hardcoded interrupt name"). ...or he should Ack this and it should go through the same tree as that patch. I'm curious: is there a reason you didn't remove it from the other two users? linuxnext/master:arch/arm/boot/dts/imx51.dtsi: interrupt-names = "kgsl_3d0_irq"; linuxnext/master:arch/arm/boot/dts/imx53.dtsi: interrupt-names = "kgsl_3d0_irq"; ...also: if this really is only for "apq8064" and not globally for all qcom devices it'd be nice to mention "apq8064" somewhere in the subject. -Doug
On Tue, Dec 18, 2018 at 02:29:25PM -0800, Doug Anderson wrote: > Hi, > > On Tue, Dec 18, 2018 at 10:32 AM Jordan Crouse <jcrouse@codeaurora.org> wrote: > > > > 'interrupt-names' shouldn't be used in cases when there is only > > one interrupt and it is not otherwise used in the driver. > > > > Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org> > > --- > > arch/arm/boot/dts/qcom-apq8064.dtsi | 1 - > > 1 file changed, 1 deletion(-) > > Looks good to me. It should be noted that Andy shouldn't land this > until he has a tree that contains ("drm/msm/gpu: Remove hardcoded > interrupt name"). ...or he should Ack this and it should go through > the same tree as that patch. > > I'm curious: is there a reason you didn't remove it from the other two users? > > linuxnext/master:arch/arm/boot/dts/imx51.dtsi: > interrupt-names = "kgsl_3d0_irq"; > linuxnext/master:arch/arm/boot/dts/imx53.dtsi: > interrupt-names = "kgsl_3d0_irq"; Because those aren't in Andy's tree. I suspect after all this lands we'll need another sweep to clean up the extras. There is also a 8996 dt floating around somewhere. Jordan > ...also: if this really is only for "apq8064" and not globally for all > qcom devices it'd be nice to mention "apq8064" somewhere in the > subject. > -Doug
diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi index 48c3cf427610..0a9862729c80 100644 --- a/arch/arm/boot/dts/qcom-apq8064.dtsi +++ b/arch/arm/boot/dts/qcom-apq8064.dtsi @@ -1186,7 +1186,6 @@ reg = <0x04300000 0x20000>; reg-names = "kgsl_3d0_reg_memory"; interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>; - interrupt-names = "kgsl_3d0_irq"; clock-names = "core_clk", "iface_clk",
'interrupt-names' shouldn't be used in cases when there is only one interrupt and it is not otherwise used in the driver. Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org> --- arch/arm/boot/dts/qcom-apq8064.dtsi | 1 - 1 file changed, 1 deletion(-)