| Message ID | 20190208100554.32196-3-patrick.bellasi@arm.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Add utilization clamping support | expand |
On Fri, Feb 08, 2019 at 10:05:41AM +0000, Patrick Bellasi wrote: > +uclamp_idle_value(struct rq *rq, unsigned int clamp_id, unsigned int clamp_value) > +{ > + /* > + * Avoid blocked utilization pushing up the frequency when we go > + * idle (which drops the max-clamp) by retaining the last known > + * max-clamp. > + */ > + if (clamp_id == UCLAMP_MAX) { > + rq->uclamp_flags |= UCLAMP_FLAG_IDLE; > + return clamp_value; > + } > + > + return uclamp_none(UCLAMP_MIN); That's a very complicated way or writing: return 0, right? > +}
On Fri, Feb 08, 2019 at 10:05:41AM +0000, Patrick Bellasi wrote: > +static inline void uclamp_idle_reset(struct rq *rq, unsigned int clamp_id, > + unsigned int clamp_value) > +{ > + /* Reset max-clamp retention only on idle exit */ > + if (!(rq->uclamp_flags & UCLAMP_FLAG_IDLE)) > + return; > + > + WRITE_ONCE(rq->uclamp[clamp_id].value, clamp_value); > + > + /* > + * This function is called for both UCLAMP_MIN (before) and UCLAMP_MAX > + * (after). The idle flag is reset only the second time, when we know > + * that UCLAMP_MIN has been already updated. Why do we care? That is, what is this comment trying to tell us. > + */ > + if (clamp_id == UCLAMP_MAX) > + rq->uclamp_flags &= ~UCLAMP_FLAG_IDLE; > +}
On 13-Mar 15:12, Peter Zijlstra wrote: > On Fri, Feb 08, 2019 at 10:05:41AM +0000, Patrick Bellasi wrote: > > +static inline void uclamp_idle_reset(struct rq *rq, unsigned int clamp_id, > > + unsigned int clamp_value) > > +{ > > + /* Reset max-clamp retention only on idle exit */ > > + if (!(rq->uclamp_flags & UCLAMP_FLAG_IDLE)) > > + return; > > + > > + WRITE_ONCE(rq->uclamp[clamp_id].value, clamp_value); > > + > > + /* > > + * This function is called for both UCLAMP_MIN (before) and UCLAMP_MAX > > + * (after). The idle flag is reset only the second time, when we know > > + * that UCLAMP_MIN has been already updated. > > Why do we care? That is, what is this comment trying to tell us. Right, the code is clear enough, I'll remove this comment. > > > + */ > > + if (clamp_id == UCLAMP_MAX) > > + rq->uclamp_flags &= ~UCLAMP_FLAG_IDLE; > > +}
On 13-Mar 15:10, Peter Zijlstra wrote: > On Fri, Feb 08, 2019 at 10:05:41AM +0000, Patrick Bellasi wrote: > > +uclamp_idle_value(struct rq *rq, unsigned int clamp_id, unsigned int clamp_value) > > +{ > > + /* > > + * Avoid blocked utilization pushing up the frequency when we go > > + * idle (which drops the max-clamp) by retaining the last known > > + * max-clamp. > > + */ > > + if (clamp_id == UCLAMP_MAX) { > > + rq->uclamp_flags |= UCLAMP_FLAG_IDLE; > > + return clamp_value; > > + } > > + > > + return uclamp_none(UCLAMP_MIN); > > That's a very complicated way or writing: return 0, right? In my mind it's just a simple way to hardcode values in just one place. In the current implementation uclamp_none(UCLAMP_MIN) is 0 and the compiler is not in trubles to inline a 0 there. Is it really so disgusting ?
On Wed, Mar 13, 2019 at 04:20:51PM +0000, Patrick Bellasi wrote: > On 13-Mar 15:10, Peter Zijlstra wrote: > > On Fri, Feb 08, 2019 at 10:05:41AM +0000, Patrick Bellasi wrote: > > > +uclamp_idle_value(struct rq *rq, unsigned int clamp_id, unsigned int clamp_value) > > > +{ > > > + /* > > > + * Avoid blocked utilization pushing up the frequency when we go > > > + * idle (which drops the max-clamp) by retaining the last known > > > + * max-clamp. > > > + */ > > > + if (clamp_id == UCLAMP_MAX) { > > > + rq->uclamp_flags |= UCLAMP_FLAG_IDLE; > > > + return clamp_value; > > > + } > > > + > > > + return uclamp_none(UCLAMP_MIN); > > > > That's a very complicated way or writing: return 0, right? > > In my mind it's just a simple way to hardcode values in just one place. > > In the current implementation uclamp_none(UCLAMP_MIN) is 0 and the > compiler is not in trubles to inline a 0 there. > > Is it really so disgusting ? Not disguisting per se, just complicated. It had me go back and check wth uclamp_none() did again.
On 13-Mar 18:29, Peter Zijlstra wrote: > On Wed, Mar 13, 2019 at 04:20:51PM +0000, Patrick Bellasi wrote: > > On 13-Mar 15:10, Peter Zijlstra wrote: > > > On Fri, Feb 08, 2019 at 10:05:41AM +0000, Patrick Bellasi wrote: > > > > +uclamp_idle_value(struct rq *rq, unsigned int clamp_id, unsigned int clamp_value) > > > > +{ > > > > + /* > > > > + * Avoid blocked utilization pushing up the frequency when we go > > > > + * idle (which drops the max-clamp) by retaining the last known > > > > + * max-clamp. > > > > + */ > > > > + if (clamp_id == UCLAMP_MAX) { > > > > + rq->uclamp_flags |= UCLAMP_FLAG_IDLE; > > > > + return clamp_value; > > > > + } > > > > + > > > > + return uclamp_none(UCLAMP_MIN); > > > > > > That's a very complicated way or writing: return 0, right? > > > > In my mind it's just a simple way to hardcode values in just one place. > > > > In the current implementation uclamp_none(UCLAMP_MIN) is 0 and the > > compiler is not in trubles to inline a 0 there. > > > > Is it really so disgusting ? > > Not disguisting per se, just complicated. It had me go back and check > wth uclamp_none() did again. Yes, I see... every time I read it I just consider that uclamp_none() it's just returning whatever is (or will be) the "non clamped" value for the specified clamp index. If it's ok with you, I would keep the code above as it is now.
On Wed, Mar 13, 2019 at 9:16 AM Patrick Bellasi <patrick.bellasi@arm.com> wrote: > > On 13-Mar 15:12, Peter Zijlstra wrote: > > On Fri, Feb 08, 2019 at 10:05:41AM +0000, Patrick Bellasi wrote: > > > +static inline void uclamp_idle_reset(struct rq *rq, unsigned int clamp_id, > > > + unsigned int clamp_value) > > > +{ > > > + /* Reset max-clamp retention only on idle exit */ > > > + if (!(rq->uclamp_flags & UCLAMP_FLAG_IDLE)) > > > + return; > > > + > > > + WRITE_ONCE(rq->uclamp[clamp_id].value, clamp_value); > > > + > > > + /* > > > + * This function is called for both UCLAMP_MIN (before) and UCLAMP_MAX > > > + * (after). The idle flag is reset only the second time, when we know > > > + * that UCLAMP_MIN has been already updated. > > > > Why do we care? That is, what is this comment trying to tell us. > > Right, the code is clear enough, I'll remove this comment. It would be probably even clearer if rq->uclamp_flags &= ~UCLAMP_FLAG_IDLE is done from inside uclamp_rq_inc after uclamp_rq_inc_id for both clamps is called. > > > > > + */ > > > + if (clamp_id == UCLAMP_MAX) > > > + rq->uclamp_flags &= ~UCLAMP_FLAG_IDLE; > > > +} > > -- > #include <best/regards.h> > > Patrick Bellasi
On 13-Mar 17:29, Suren Baghdasaryan wrote: > On Wed, Mar 13, 2019 at 9:16 AM Patrick Bellasi <patrick.bellasi@arm.com> wrote: > > > > On 13-Mar 15:12, Peter Zijlstra wrote: > > > On Fri, Feb 08, 2019 at 10:05:41AM +0000, Patrick Bellasi wrote: > > > > +static inline void uclamp_idle_reset(struct rq *rq, unsigned int clamp_id, > > > > + unsigned int clamp_value) > > > > +{ > > > > + /* Reset max-clamp retention only on idle exit */ > > > > + if (!(rq->uclamp_flags & UCLAMP_FLAG_IDLE)) > > > > + return; > > > > + > > > > + WRITE_ONCE(rq->uclamp[clamp_id].value, clamp_value); > > > > + > > > > + /* > > > > + * This function is called for both UCLAMP_MIN (before) and UCLAMP_MAX > > > > + * (after). The idle flag is reset only the second time, when we know > > > > + * that UCLAMP_MIN has been already updated. > > > > > > Why do we care? That is, what is this comment trying to tell us. > > > > Right, the code is clear enough, I'll remove this comment. > > It would be probably even clearer if rq->uclamp_flags &= > ~UCLAMP_FLAG_IDLE is done from inside uclamp_rq_inc after > uclamp_rq_inc_id for both clamps is called. Good point! I'll move it there to have something like: ---8<--- static inline void uclamp_rq_inc(struct rq *rq, struct task_struct *p) { unsigned int clamp_id; if (unlikely(!p->sched_class->uclamp_enabled)) return; for (clamp_id = 0; clamp_id < UCLAMP_CNT; ++clamp_id) uclamp_rq_inc_id(p, rq, clamp_id); /* Reset clamp holding when we have at least one RUNNABLE task */ if (rq->uclamp_flags & UCLAMP_FLAG_IDLE) rq->uclamp_flags &= ~UCLAMP_FLAG_IDLE; } ---8<---
diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 8ecf5470058c..e4f5e8c426ab 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -741,11 +741,47 @@ static inline unsigned int uclamp_none(int clamp_id) return SCHED_CAPACITY_SCALE; } -static inline void uclamp_rq_update(struct rq *rq, unsigned int clamp_id) +static inline unsigned int +uclamp_idle_value(struct rq *rq, unsigned int clamp_id, unsigned int clamp_value) +{ + /* + * Avoid blocked utilization pushing up the frequency when we go + * idle (which drops the max-clamp) by retaining the last known + * max-clamp. + */ + if (clamp_id == UCLAMP_MAX) { + rq->uclamp_flags |= UCLAMP_FLAG_IDLE; + return clamp_value; + } + + return uclamp_none(UCLAMP_MIN); +} + +static inline void uclamp_idle_reset(struct rq *rq, unsigned int clamp_id, + unsigned int clamp_value) +{ + /* Reset max-clamp retention only on idle exit */ + if (!(rq->uclamp_flags & UCLAMP_FLAG_IDLE)) + return; + + WRITE_ONCE(rq->uclamp[clamp_id].value, clamp_value); + + /* + * This function is called for both UCLAMP_MIN (before) and UCLAMP_MAX + * (after). The idle flag is reset only the second time, when we know + * that UCLAMP_MIN has been already updated. + */ + if (clamp_id == UCLAMP_MAX) + rq->uclamp_flags &= ~UCLAMP_FLAG_IDLE; +} + +static inline void uclamp_rq_update(struct rq *rq, unsigned int clamp_id, + unsigned int clamp_value) { struct uclamp_bucket *bucket = rq->uclamp[clamp_id].bucket; unsigned int max_value = uclamp_none(clamp_id); unsigned int bucket_id; + bool active = false; /* * Both min and max clamps are MAX aggregated, thus the topmost @@ -757,9 +793,13 @@ static inline void uclamp_rq_update(struct rq *rq, unsigned int clamp_id) if (!rq->uclamp[clamp_id].bucket[bucket_id].tasks) continue; max_value = bucket[bucket_id].value; + active = true; break; } while (bucket_id); + if (unlikely(!active)) + max_value = uclamp_idle_value(rq, clamp_id, clamp_value); + WRITE_ONCE(rq->uclamp[clamp_id].value, max_value); } @@ -781,12 +821,14 @@ static inline void uclamp_rq_inc_id(struct task_struct *p, struct rq *rq, unsigned int rq_clamp, bkt_clamp, tsk_clamp; rq->uclamp[clamp_id].bucket[bucket_id].tasks++; + /* Reset clamp holds on idle exit */ + tsk_clamp = p->uclamp[clamp_id].value; + uclamp_idle_reset(rq, clamp_id, tsk_clamp); /* * Local clamping: rq's buckets always track the max "requested" * clamp value from all RUNNABLE tasks in that bucket. */ - tsk_clamp = p->uclamp[clamp_id].value; bkt_clamp = rq->uclamp[clamp_id].bucket[bucket_id].value; rq->uclamp[clamp_id].bucket[bucket_id].value = max(bkt_clamp, tsk_clamp); @@ -830,7 +872,7 @@ static inline void uclamp_rq_dec_id(struct task_struct *p, struct rq *rq, */ rq->uclamp[clamp_id].bucket[bucket_id].value = uclamp_bucket_value(rq_clamp); - uclamp_rq_update(rq, clamp_id); + uclamp_rq_update(rq, clamp_id, bkt_clamp); } } @@ -861,8 +903,10 @@ static void __init init_uclamp(void) unsigned int clamp_id; int cpu; - for_each_possible_cpu(cpu) + for_each_possible_cpu(cpu) { memset(&cpu_rq(cpu)->uclamp, 0, sizeof(struct uclamp_rq)); + cpu_rq(cpu)->uclamp_flags = 0; + } for (clamp_id = 0; clamp_id < UCLAMP_CNT; ++clamp_id) { unsigned int clamp_value = uclamp_none(clamp_id); diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index ea9e28723946..b3274b2423f8 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -880,6 +880,8 @@ struct rq { #ifdef CONFIG_UCLAMP_TASK /* Utilization clamp values based on CPU's RUNNABLE tasks */ struct uclamp_rq uclamp[UCLAMP_CNT] ____cacheline_aligned; + unsigned int uclamp_flags; +#define UCLAMP_FLAG_IDLE 0x01 #endif struct cfs_rq cfs;
When the task sleeps, it removes its max utilization clamp from its CPU. However, the blocked utilization on that CPU can be higher than the max clamp value enforced while the task was running. This allows undesired CPU frequency increases while a CPU is idle, for example, when another CPU on the same frequency domain triggers a frequency update, since schedutil can now see the full not clamped blocked utilization of the idle CPU. Fix this by using uclamp_rq_dec_id(p, rq, UCLAMP_MAX) uclamp_rq_update(rq, UCLAMP_MAX, clamp_value) to detect when a CPU has no more RUNNABLE clamped tasks and to flag this condition. Don't track any minimum utilization clamps since an idle CPU never requires a minimum frequency. The decay of the blocked utilization is good enough to reduce the CPU frequency. Signed-off-by: Patrick Bellasi <patrick.bellasi@arm.com> Cc: Ingo Molnar <mingo@redhat.com> Cc: Peter Zijlstra <peterz@infradead.org> --- kernel/sched/core.c | 52 ++++++++++++++++++++++++++++++++++++++++---- kernel/sched/sched.h | 2 ++ 2 files changed, 50 insertions(+), 4 deletions(-)