| Message ID | 20190424051145.23072-3-jiada_wang@mentor.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Eduardo Valentin |
| Headers | show |
| Series | thermal: rcar_gen3_thermal: fix IRQ issues | expand |
On Wed, Apr 24, 2019 at 02:11:45PM +0900, Jiada Wang wrote: > Currently IRQ remains enabled after .remove, later if device is probed, > IRQ is requested before .thermal_init, this may cause IRQ function be > called before device is initialized. > > this patch disables interrupt in .remove, to ensure irq function > only be called after device is fully initialized. > > Signed-off-by: Jiada Wang <jiada_wang@mentor.com> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
On 24/04/2019 07:11, Jiada Wang wrote: > Currently IRQ remains enabled after .remove, later if device is probed, > IRQ is requested before .thermal_init, this may cause IRQ function be > called before device is initialized. > > this patch disables interrupt in .remove, to ensure irq function > only be called after device is fully initialized. > > Signed-off-by: Jiada Wang <jiada_wang@mentor.com> Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org> > --- > drivers/thermal/rcar_gen3_thermal.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/thermal/rcar_gen3_thermal.c b/drivers/thermal/rcar_gen3_thermal.c > index 065e16f53285..280230951dfe 100644 > --- a/drivers/thermal/rcar_gen3_thermal.c > +++ b/drivers/thermal/rcar_gen3_thermal.c > @@ -307,6 +307,9 @@ MODULE_DEVICE_TABLE(of, rcar_gen3_thermal_dt_ids); > static int rcar_gen3_thermal_remove(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > + struct rcar_gen3_thermal_priv *priv = dev_get_drvdata(dev); > + > + rcar_thermal_irq_set(priv, false); > > pm_runtime_put(dev); > pm_runtime_disable(dev); >
On Wed, Apr 24, 2019 at 02:11:45PM +0900, Jiada Wang wrote: > Currently IRQ remains enabled after .remove, later if device is probed, > IRQ is requested before .thermal_init, this may cause IRQ function be > called before device is initialized. > > this patch disables interrupt in .remove, to ensure irq function > only be called after device is fully initialized. > > Signed-off-by: Jiada Wang <jiada_wang@mentor.com> Based on https://patchwork.kernel.org/cover/10914079/#22603533 : Reviewed-and-Tested-by: Eugeniu Rosca <erosca@de.adit-jv.com> Thanks!
diff --git a/drivers/thermal/rcar_gen3_thermal.c b/drivers/thermal/rcar_gen3_thermal.c index 065e16f53285..280230951dfe 100644 --- a/drivers/thermal/rcar_gen3_thermal.c +++ b/drivers/thermal/rcar_gen3_thermal.c @@ -307,6 +307,9 @@ MODULE_DEVICE_TABLE(of, rcar_gen3_thermal_dt_ids); static int rcar_gen3_thermal_remove(struct platform_device *pdev) { struct device *dev = &pdev->dev; + struct rcar_gen3_thermal_priv *priv = dev_get_drvdata(dev); + + rcar_thermal_irq_set(priv, false); pm_runtime_put(dev); pm_runtime_disable(dev);
Currently IRQ remains enabled after .remove, later if device is probed, IRQ is requested before .thermal_init, this may cause IRQ function be called before device is initialized. this patch disables interrupt in .remove, to ensure irq function only be called after device is fully initialized. Signed-off-by: Jiada Wang <jiada_wang@mentor.com> --- drivers/thermal/rcar_gen3_thermal.c | 3 +++ 1 file changed, 3 insertions(+)