| Message ID | 20190515093647.47656-1-andy.tang@nxp.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Eduardo Valentin |
| Headers | show |
| Series | dt-bindings: thermal: Make cooling-maps property optional | expand |
On Wed, May 15, 2019 at 05:36:47PM +0800, Yuantian Tang wrote: > There may be no cooling device on system, or there are no enough > cooling devices for each thermal zone in multiple thermal zone > cases since cooling devices can't be shared. > So make this property optional to remove such limitations. Yeah, I am not sure that is enough reason to make this property optional. Let me maybe ask you why do you care creating a thermal zone if your control has no actions? Or rather, why bothering setting up a control that has no actuators? > > Signed-off-by: Yuantian Tang <andy.tang@nxp.com> > --- > .../devicetree/bindings/thermal/thermal.txt | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt b/Documentation/devicetree/bindings/thermal/thermal.txt > index ca14ba9..694e834 100644 > --- a/Documentation/devicetree/bindings/thermal/thermal.txt > +++ b/Documentation/devicetree/bindings/thermal/thermal.txt > @@ -142,11 +142,11 @@ Required properties: > - trips: A sub-node which is a container of only trip point nodes > Type: sub-node required to describe the thermal zone. > > + > +Optional property: > - cooling-maps: A sub-node which is a container of only cooling device > Type: sub-node map nodes, used to describe the relation between trips > and cooling devices. > - > -Optional property: > - coefficients: An array of integers (one signed cell) containing > Type: array coefficients to compose a linear relation between > Elem size: one cell the sensors listed in the thermal-sensors property. > -- > 1.7.1 >
> -----Original Message----- > From: Eduardo Valentin <edubezval@gmail.com> > Sent: 2019年5月24日 10:50 > To: Andy Tang <andy.tang@nxp.com> > Cc: rui.zhang@intel.com; robh+dt@kernel.org; daniel.lezcano@linaro.org; > mark.rutland@arm.com; linux-pm@vger.kernel.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: [EXT] Re: [PATCH] dt-bindings: thermal: Make cooling-maps property > optional > > Caution: EXT Email > > On Wed, May 15, 2019 at 05:36:47PM +0800, Yuantian Tang wrote: > > There may be no cooling device on system, or there are no enough > > cooling devices for each thermal zone in multiple thermal zone cases > > since cooling devices can't be shared. > > So make this property optional to remove such limitations. > > Yeah, I am not sure that is enough reason to make this property optional. > Let me maybe ask you why do you care creating a thermal zone if your control > has no actions? Or rather, why bothering setting up a control that has no > actuators? No cooling-device map doesn't mean NO ACTIONS. There could be critic trips that trigger CPU reset or shutdown. The root cause for it here is: there is no enough cooling device for each zone when multiple zone exist. For example, for our ls2088a platform, there are 7 thermal zones, but we have only one cooling device which is cpufreq. Due to this option limitation, multiple zones can't be supported. I believe on most platform, there are only two type of cooling devices, cpufreq and fan. So how many cooling devices it could be? So making the property optional is reasonable. We can assign cooling devices to certain thermal zones and leave the thermal zone with no cooling device taking default actions. BR, Andy > > > > > Signed-off-by: Yuantian Tang <andy.tang@nxp.com> > > --- > > .../devicetree/bindings/thermal/thermal.txt | 4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt > > b/Documentation/devicetree/bindings/thermal/thermal.txt > > index ca14ba9..694e834 100644 > > --- a/Documentation/devicetree/bindings/thermal/thermal.txt > > +++ b/Documentation/devicetree/bindings/thermal/thermal.txt > > @@ -142,11 +142,11 @@ Required properties: > > - trips: A sub-node which is a container of only trip point > nodes > > Type: sub-node required to describe the thermal zone. > > > > + > > +Optional property: > > - cooling-maps: A sub-node which is a container of only > cooling device > > Type: sub-node map nodes, used to describe the relation > between trips > > and cooling devices. > > - > > -Optional property: > > - coefficients: An array of integers (one signed cell) > containing > > Type: array coefficients to compose a linear relation > between > > Elem size: one cell the sensors listed in the thermal-sensors > property. > > -- > > 1.7.1 > >
Hi Edubezval, Rui, Any further comments? BR, Andy > -----Original Message----- > From: Yuantian Tang <andy.tang@nxp.com> > Sent: 2019年5月15日 17:37 > To: rui.zhang@intel.com; edubezval@gmail.com > Cc: robh+dt@kernel.org; daniel.lezcano@linaro.org; mark.rutland@arm.com; > linux-pm@vger.kernel.org; devicetree@vger.kernel.org; > linux-kernel@vger.kernel.org; Andy Tang <andy.tang@nxp.com> > Subject: [PATCH] dt-bindings: thermal: Make cooling-maps property optional > > There may be no cooling device on system, or there are no enough cooling > devices for each thermal zone in multiple thermal zone cases since cooling > devices can't be shared. > So make this property optional to remove such limitations. > > Signed-off-by: Yuantian Tang <andy.tang@nxp.com> > --- > .../devicetree/bindings/thermal/thermal.txt | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt > b/Documentation/devicetree/bindings/thermal/thermal.txt > index ca14ba9..694e834 100644 > --- a/Documentation/devicetree/bindings/thermal/thermal.txt > +++ b/Documentation/devicetree/bindings/thermal/thermal.txt > @@ -142,11 +142,11 @@ Required properties: > - trips: A sub-node which is a container of only trip point nodes > Type: sub-node required to describe the thermal zone. > > + > +Optional property: > - cooling-maps: A sub-node which is a container of only cooling device > Type: sub-node map nodes, used to describe the relation between > trips > and cooling devices. > - > -Optional property: > - coefficients: An array of integers (one signed cell) containing > Type: array coefficients to compose a linear relation between > Elem size: one cell the sensors listed in the thermal-sensors property. > -- > 1.7.1
On 04/06/2019 07:56, Andy Tang wrote: > Hi Edubezval, Rui, > > Any further comments? From my POV, this patch makes sense. We may be interested to show up the thermal zones in sysfs and optionally mitigate them via an userspace governor. Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org> >> -----Original Message----- >> From: Yuantian Tang <andy.tang@nxp.com> >> Sent: 2019年5月15日 17:37 >> To: rui.zhang@intel.com; edubezval@gmail.com >> Cc: robh+dt@kernel.org; daniel.lezcano@linaro.org; mark.rutland@arm.com; >> linux-pm@vger.kernel.org; devicetree@vger.kernel.org; >> linux-kernel@vger.kernel.org; Andy Tang <andy.tang@nxp.com> >> Subject: [PATCH] dt-bindings: thermal: Make cooling-maps property optional >> >> There may be no cooling device on system, or there are no enough cooling >> devices for each thermal zone in multiple thermal zone cases since cooling >> devices can't be shared. >> So make this property optional to remove such limitations. >> >> Signed-off-by: Yuantian Tang <andy.tang@nxp.com> >> --- >> .../devicetree/bindings/thermal/thermal.txt | 4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt >> b/Documentation/devicetree/bindings/thermal/thermal.txt >> index ca14ba9..694e834 100644 >> --- a/Documentation/devicetree/bindings/thermal/thermal.txt >> +++ b/Documentation/devicetree/bindings/thermal/thermal.txt >> @@ -142,11 +142,11 @@ Required properties: >> - trips: A sub-node which is a container of only trip point nodes >> Type: sub-node required to describe the thermal zone. >> >> + >> +Optional property: >> - cooling-maps: A sub-node which is a container of only cooling device >> Type: sub-node map nodes, used to describe the relation between >> trips >> and cooling devices. >> - >> -Optional property: >> - coefficients: An array of integers (one signed cell) containing >> Type: array coefficients to compose a linear relation between >> Elem size: one cell the sensors listed in the thermal-sensors property. >> -- >> 1.7.1 >
Hi Edubezval, Rui, Are you going to pick up this patch? BR, Andy > -----Original Message----- > From: Daniel Lezcano <daniel.lezcano@linaro.org> > Sent: 2019年6月4日 14:04 > To: Andy Tang <andy.tang@nxp.com>; rui.zhang@intel.com; > edubezval@gmail.com > Cc: robh+dt@kernel.org; mark.rutland@arm.com; linux-pm@vger.kernel.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: [EXT] Re: [PATCH] dt-bindings: thermal: Make cooling-maps property > optional > > Caution: EXT Email > > On 04/06/2019 07:56, Andy Tang wrote: > > Hi Edubezval, Rui, > > > > Any further comments? > > From my POV, this patch makes sense. We may be interested to show up the > thermal zones in sysfs and optionally mitigate them via an userspace > governor. > > Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org> > > >> -----Original Message----- > >> From: Yuantian Tang <andy.tang@nxp.com> > >> Sent: 2019年5月15日 17:37 > >> To: rui.zhang@intel.com; edubezval@gmail.com > >> Cc: robh+dt@kernel.org; daniel.lezcano@linaro.org; > >> mark.rutland@arm.com; linux-pm@vger.kernel.org; > >> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Andy Tang > >> <andy.tang@nxp.com> > >> Subject: [PATCH] dt-bindings: thermal: Make cooling-maps property > >> optional > >> > >> There may be no cooling device on system, or there are no enough > >> cooling devices for each thermal zone in multiple thermal zone cases > >> since cooling devices can't be shared. > >> So make this property optional to remove such limitations. > >> > >> Signed-off-by: Yuantian Tang <andy.tang@nxp.com> > >> --- > >> .../devicetree/bindings/thermal/thermal.txt | 4 ++-- > >> 1 files changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt > >> b/Documentation/devicetree/bindings/thermal/thermal.txt > >> index ca14ba9..694e834 100644 > >> --- a/Documentation/devicetree/bindings/thermal/thermal.txt > >> +++ b/Documentation/devicetree/bindings/thermal/thermal.txt > >> @@ -142,11 +142,11 @@ Required properties: > >> - trips: A sub-node which is a container of only trip point > nodes > >> Type: sub-node required to describe the thermal zone. > >> > >> + > >> +Optional property: > >> - cooling-maps: A sub-node which is a container of only > cooling device > >> Type: sub-node map nodes, used to describe the relation > between > >> trips > >> and cooling devices. > >> - > >> -Optional property: > >> - coefficients: An array of integers (one signed cell) > containing > >> Type: array coefficients to compose a linear relation > between > >> Elem size: one cell the sensors listed in the thermal-sensors > property. > >> -- > >> 1.7.1 > > > > > -- > > <https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww. > linaro.org%2F&data=02%7C01%7Candy.tang%40nxp.com%7C2287a987 > 116c4240ed8408d6e8b27b81%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C > 0%7C0%7C636952250606346540&sdata=D8XH3corlkEU91u7FguNtCF8 > hkzR8viNntDQ4NjF9OM%3D&reserved=0> Linaro.org │ Open source > software for ARM SoCs > > Follow Linaro: > <https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww. > facebook.com%2Fpages%2FLinaro&data=02%7C01%7Candy.tang%40nx > p.com%7C2287a987116c4240ed8408d6e8b27b81%7C686ea1d3bc2b4c6fa92 > cd99c5c301635%7C0%7C0%7C636952250606356528&sdata=hRuvmW > %2BrQ61tDEy7XIHKhTaTqxL%2FJC6gRy29YgsEazk%3D&reserved=0> > Facebook | > <https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Ftwitte > r.com%2F%23!%2Flinaroorg&data=02%7C01%7Candy.tang%40nxp.com > %7C2287a987116c4240ed8408d6e8b27b81%7C686ea1d3bc2b4c6fa92cd99c > 5c301635%7C0%7C0%7C636952250606356528&sdata=j6yO88tkG0uQs > ViSV%2F9SCOYLa3iJ6pXs8mqxs6qt4uA%3D&reserved=0> Twitter | > <https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww. > linaro.org%2Flinaro-blog%2F&data=02%7C01%7Candy.tang%40nxp.co > m%7C2287a987116c4240ed8408d6e8b27b81%7C686ea1d3bc2b4c6fa92cd99 > c5c301635%7C0%7C0%7C636952250606356528&sdata=q9tOF%2FiOL6 > GpdvpSiT%2FyFIFL33Dx0%2FuBBaOxcmdD1Ro%3D&reserved=0> Blog
diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt b/Documentation/devicetree/bindings/thermal/thermal.txt index ca14ba9..694e834 100644 --- a/Documentation/devicetree/bindings/thermal/thermal.txt +++ b/Documentation/devicetree/bindings/thermal/thermal.txt @@ -142,11 +142,11 @@ Required properties: - trips: A sub-node which is a container of only trip point nodes Type: sub-node required to describe the thermal zone. + +Optional property: - cooling-maps: A sub-node which is a container of only cooling device Type: sub-node map nodes, used to describe the relation between trips and cooling devices. - -Optional property: - coefficients: An array of integers (one signed cell) containing Type: array coefficients to compose a linear relation between Elem size: one cell the sensors listed in the thermal-sensors property.
There may be no cooling device on system, or there are no enough cooling devices for each thermal zone in multiple thermal zone cases since cooling devices can't be shared. So make this property optional to remove such limitations. Signed-off-by: Yuantian Tang <andy.tang@nxp.com> --- .../devicetree/bindings/thermal/thermal.txt | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)