| Message ID | 20190605091236.24263-5-l.luba@partner.samsung.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Exynos Performance Monitoring Counters enhancements | expand |
Hi Chanwoo, On 6/26/19 10:23 AM, Chanwoo Choi wrote: > Hi Lukasz, > > 2019년 6월 5일 (수) 18:14, Lukasz Luba <l.luba@partner.samsung.com > <mailto:l.luba@partner.samsung.com>>님이 작성: > > Extend the documenation by events description with new 'event-data-type' > field. Add example how the event might be defined in DT. > > Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com > <mailto:l.luba@partner.samsung.com>> > Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com > <mailto:cw00.choi@samsung.com>> > --- > .../bindings/devfreq/event/exynos-ppmu.txt | 26 +++++++++++++++++-- > 1 file changed, 24 insertions(+), 2 deletions(-) > > > > Acked-by: Chanwoo Choi <cw00.choi@samsung.com Thank you for the ACKs for this a 2/5 patch. Do you think the v4 could be merged now? Regards, Lukasz
On Wed, 26 Jun 2019 at 15:58, Lukasz Luba <l.luba@partner.samsung.com> wrote: > > Hi Chanwoo, > > On 6/26/19 10:23 AM, Chanwoo Choi wrote: > > Hi Lukasz, > > > > 2019년 6월 5일 (수) 18:14, Lukasz Luba <l.luba@partner.samsung.com > > <mailto:l.luba@partner.samsung.com>>님이 작성: > > > > Extend the documenation by events description with new 'event-data-type' > > field. Add example how the event might be defined in DT. > > > > Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com > > <mailto:l.luba@partner.samsung.com>> > > Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com > > <mailto:cw00.choi@samsung.com>> > > --- > > .../bindings/devfreq/event/exynos-ppmu.txt | 26 +++++++++++++++++-- > > 1 file changed, 24 insertions(+), 2 deletions(-) > > > > > > > > Acked-by: Chanwoo Choi <cw00.choi@samsung.com > > Thank you for the ACKs for this a 2/5 patch. > Do you think the v4 could be merged now? I think you have all necessary acks. I can take the DTS patch (5/5) although probably for next merge window as I just sent one. Best regards, Krzysztof
Hi Krzysztof, On 6/26/19 4:03 PM, Krzysztof Kozlowski wrote: > On Wed, 26 Jun 2019 at 15:58, Lukasz Luba <l.luba@partner.samsung.com> wrote: >> >> Hi Chanwoo, >> >> On 6/26/19 10:23 AM, Chanwoo Choi wrote: >>> Hi Lukasz, >>> >>> 2019년 6월 5일 (수) 18:14, Lukasz Luba <l.luba@partner.samsung.com >>> <mailto:l.luba@partner.samsung.com>>님이 작성: >>> >>> Extend the documenation by events description with new 'event-data-type' >>> field. Add example how the event might be defined in DT. >>> >>> Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com >>> <mailto:l.luba@partner.samsung.com>> >>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com >>> <mailto:cw00.choi@samsung.com>> >>> --- >>> .../bindings/devfreq/event/exynos-ppmu.txt | 26 +++++++++++++++++-- >>> 1 file changed, 24 insertions(+), 2 deletions(-) >>> >>> >>> >>> Acked-by: Chanwoo Choi <cw00.choi@samsung.com >> >> Thank you for the ACKs for this a 2/5 patch. >> Do you think the v4 could be merged now? > > I think you have all necessary acks. I can take the DTS patch (5/5) > although probably for next merge window as I just sent one. There was one patch 3/5 https://lkml.org/lkml/2019/6/5/215 which was waiting ACK or I missed the email somehow. Regards, Lukasz > > Best regards, > Krzysztof > >
Hi Lukasz, On 19. 6. 26. 오후 11:17, Lukasz Luba wrote: > Hi Krzysztof, > > On 6/26/19 4:03 PM, Krzysztof Kozlowski wrote: >> On Wed, 26 Jun 2019 at 15:58, Lukasz Luba <l.luba@partner.samsung.com> wrote: >>> >>> Hi Chanwoo, >>> >>> On 6/26/19 10:23 AM, Chanwoo Choi wrote: >>>> Hi Lukasz, >>>> >>>> 2019년 6월 5일 (수) 18:14, Lukasz Luba <l.luba@partner.samsung.com >>>> <mailto:l.luba@partner.samsung.com>>님이 작성: >>>> >>>> Extend the documenation by events description with new 'event-data-type' >>>> field. Add example how the event might be defined in DT. >>>> >>>> Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com >>>> <mailto:l.luba@partner.samsung.com>> >>>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com >>>> <mailto:cw00.choi@samsung.com>> >>>> --- >>>> .../bindings/devfreq/event/exynos-ppmu.txt | 26 +++++++++++++++++-- >>>> 1 file changed, 24 insertions(+), 2 deletions(-) >>>> >>>> >>>> >>>> Acked-by: Chanwoo Choi <cw00.choi@samsung.com >>> >>> Thank you for the ACKs for this a 2/5 patch. >>> Do you think the v4 could be merged now? >> >> I think you have all necessary acks. I can take the DTS patch (5/5) >> although probably for next merge window as I just sent one. > There was one patch 3/5 > https://protect2.fireeye.com/url?k=82dd0d0cbe2abd04.82dc8643-d13ecd7e5f989b8d&u=https://lkml.org/lkml/2019/6/5/215 > which was waiting ACK or I missed the email somehow. When I was in vacation, your patches are removed on my email account because of the email expiration. So, I replied with my Ack through gmail account on mobile phone. But, there are some problem. My reply didn't arrive the mailing list. I have no any way to reply about this at company. After leaving one's office, I'll reply with Ack again at home. > > Regards, > Lukasz > >> >> Best regards, >> Krzysztof >> >> > >
Hi Chanwoo, On 6/27/19 3:11 AM, Chanwoo Choi wrote: > Hi Lukasz, > > On 19. 6. 26. 오후 11:17, Lukasz Luba wrote: >> Hi Krzysztof, >> >> On 6/26/19 4:03 PM, Krzysztof Kozlowski wrote: >>> On Wed, 26 Jun 2019 at 15:58, Lukasz Luba <l.luba@partner.samsung.com> wrote: >>>> >>>> Hi Chanwoo, >>>> >>>> On 6/26/19 10:23 AM, Chanwoo Choi wrote: >>>>> Hi Lukasz, >>>>> >>>>> 2019년 6월 5일 (수) 18:14, Lukasz Luba <l.luba@partner.samsung.com >>>>> <mailto:l.luba@partner.samsung.com>>님이 작성: >>>>> >>>>> Extend the documenation by events description with new 'event-data-type' >>>>> field. Add example how the event might be defined in DT. >>>>> >>>>> Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com >>>>> <mailto:l.luba@partner.samsung.com>> >>>>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com >>>>> <mailto:cw00.choi@samsung.com>> >>>>> --- >>>>> .../bindings/devfreq/event/exynos-ppmu.txt | 26 +++++++++++++++++-- >>>>> 1 file changed, 24 insertions(+), 2 deletions(-) >>>>> >>>>> >>>>> >>>>> Acked-by: Chanwoo Choi <cw00.choi@samsung.com >>>> >>>> Thank you for the ACKs for this a 2/5 patch. >>>> Do you think the v4 could be merged now? >>> >>> I think you have all necessary acks. I can take the DTS patch (5/5) >>> although probably for next merge window as I just sent one. >> There was one patch 3/5 >> https://protect2.fireeye.com/url?k=82dd0d0cbe2abd04.82dc8643-d13ecd7e5f989b8d&u=https://lkml.org/lkml/2019/6/5/215 >> which was waiting ACK or I missed the email somehow. > > When I was in vacation, your patches are removed on my email account > because of the email expiration. So, I replied with my Ack through > gmail account on mobile phone. But, there are some problem. My reply > didn't arrive the mailing list. > > I have no any way to reply about this at company. After leaving one's > office, I'll reply with Ack again at home. > OK, no worries, it is not an emergency issue. Regards, Lukasz
diff --git a/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt b/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt index 3e36c1d11386..fb46b491791c 100644 --- a/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt +++ b/Documentation/devicetree/bindings/devfreq/event/exynos-ppmu.txt @@ -10,14 +10,23 @@ The Exynos PPMU driver uses the devfreq-event class to provide event data to various devfreq devices. The devfreq devices would use the event data when derterming the current state of each IP. -Required properties: +Required properties for PPMU device: - compatible: Should be "samsung,exynos-ppmu" or "samsung,exynos-ppmu-v2. - reg: physical base address of each PPMU and length of memory mapped region. -Optional properties: +Optional properties for PPMU device: - clock-names : the name of clock used by the PPMU, "ppmu" - clocks : phandles for clock specified in "clock-names" property +Required properties for 'events' child node of PPMU device: +- event-name : the unique event name among PPMU device +Optional properties for 'events' child node of PPMU device: +- event-data-type : Define the type of data which shell be counted +by the counter. You can check include/dt-bindings/pmu/exynos_ppmu.h for +all possible type, i.e. count read requests, count write data in bytes, +etc. This field is optional and when it is missing, the driver code +will use default data type. + Example1 : PPMUv1 nodes in exynos3250.dtsi are listed below. ppmu_dmc0: ppmu_dmc0@106a0000 { @@ -145,3 +154,16 @@ Example3 : PPMUv2 nodes in exynos5433.dtsi are listed below. reg = <0x104d0000 0x2000>; status = "disabled"; }; + +Example4 : 'event-data-type' in exynos4412-ppmu-common.dtsi are listed below. + + &ppmu_dmc0 { + status = "okay"; + events { + ppmu_dmc0_3: ppmu-event3-dmc0 { + event-name = "ppmu-event3-dmc0"; + event-data-type = <(PPMU_RO_DATA_CNT | + PPMU_WO_DATA_CNT)>; + }; + }; + };