| Message ID | 20190722094646.13342-7-l.luba@partner.samsung.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [v12,1/9] dt-bindings: ddr: rename lpddr2 directory | expand |
On Mon, Jul 22, 2019 at 11:46:43AM +0200, Lukasz Luba wrote: > Add the chipid label which allows to use it in phandle from other device. > Use syscon in compatible to get the regmap of the device register set. > The chipid is used in DMC during initialization to compare compatibility. > I cannot find its usage in DMC driver. Best regards, Krzysztof > Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com> > --- > arch/arm/boot/dts/exynos5.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5.dtsi b/arch/arm/boot/dts/exynos5.dtsi > index 67f9b4504a42..4801ca759feb 100644 > --- a/arch/arm/boot/dts/exynos5.dtsi > +++ b/arch/arm/boot/dts/exynos5.dtsi > @@ -35,8 +35,8 @@ > #size-cells = <1>; > ranges; > > - chipid@10000000 { > - compatible = "samsung,exynos4210-chipid"; > + chipid: chipid@10000000 { > + compatible = "samsung,exynos4210-chipid", "syscon"; > reg = <0x10000000 0x100>; > }; > > -- > 2.17.1 >
On 7/24/19 7:10 PM, Krzysztof Kozlowski wrote: > On Mon, Jul 22, 2019 at 11:46:43AM +0200, Lukasz Luba wrote: >> Add the chipid label which allows to use it in phandle from other device. >> Use syscon in compatible to get the regmap of the device register set. >> The chipid is used in DMC during initialization to compare compatibility. >> > > I cannot find its usage in DMC driver. You are right, it was used in the old versions. I will skip this patch. Regards, Lukasz > > Best regards, > Krzysztof > > >> Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com> >> --- >> arch/arm/boot/dts/exynos5.dtsi | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm/boot/dts/exynos5.dtsi b/arch/arm/boot/dts/exynos5.dtsi >> index 67f9b4504a42..4801ca759feb 100644 >> --- a/arch/arm/boot/dts/exynos5.dtsi >> +++ b/arch/arm/boot/dts/exynos5.dtsi >> @@ -35,8 +35,8 @@ >> #size-cells = <1>; >> ranges; >> >> - chipid@10000000 { >> - compatible = "samsung,exynos4210-chipid"; >> + chipid: chipid@10000000 { >> + compatible = "samsung,exynos4210-chipid", "syscon"; >> reg = <0x10000000 0x100>; >> }; >> >> -- >> 2.17.1 >> > >
diff --git a/arch/arm/boot/dts/exynos5.dtsi b/arch/arm/boot/dts/exynos5.dtsi index 67f9b4504a42..4801ca759feb 100644 --- a/arch/arm/boot/dts/exynos5.dtsi +++ b/arch/arm/boot/dts/exynos5.dtsi @@ -35,8 +35,8 @@ #size-cells = <1>; ranges; - chipid@10000000 { - compatible = "samsung,exynos4210-chipid"; + chipid: chipid@10000000 { + compatible = "samsung,exynos4210-chipid", "syscon"; reg = <0x10000000 0x100>; };
Add the chipid label which allows to use it in phandle from other device. Use syscon in compatible to get the regmap of the device register set. The chipid is used in DMC during initialization to compare compatibility. Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com> --- arch/arm/boot/dts/exynos5.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)