| Message ID | 20200129112002.6998-2-cw00.choi@samsung.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Chanwoo Choi |
| Headers | show |
| Series | [1/2] PM / devfreq: Remove unneeded extern keyword | expand |
Hi Chanwoo, Apart from small mistakes in the commit message, looks good to me. On 1/29/20 11:20 AM, Chanwoo Choi wrote: > DEVFREQ_GOV_INTERVAL event indicates that update the interval > for polling mode of devfreq device. But, this event name doesn't > specify exactly what to do. > > Change DEVFREQ_GOV_INTERVAL event name to DEVFREQ_GOV_UPDATE_INTERVAL > which specifies what to do by event name. > > And modify the functio name for DEVFREQ_GOV_UPDATE_INTERVAL s/functio/function > with 'devfreq_' prefix + verb + obejct as following: 'obejct'? > - devfreq_interval_update -> devfreq_updatee_interval > > Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> > --- > drivers/devfreq/devfreq.c | 10 +++++----- > drivers/devfreq/governor.h | 4 ++-- > drivers/devfreq/governor_simpleondemand.c | 4 ++-- > drivers/devfreq/tegra30-devfreq.c | 4 ++-- > 4 files changed, 11 insertions(+), 11 deletions(-) > > diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c > index cceee8bc3c2f..8494c5f05a73 100644 > --- a/drivers/devfreq/devfreq.c > +++ b/drivers/devfreq/devfreq.c > @@ -550,14 +550,14 @@ void devfreq_monitor_resume(struct devfreq *devfreq) > EXPORT_SYMBOL(devfreq_monitor_resume); > > /** > - * devfreq_interval_update() - Update device devfreq monitoring interval > + * devfreq_update_interval() - Update device devfreq monitoring interval > * @devfreq: the devfreq instance. > * @delay: new polling interval to be set. > * > * Helper function to set new load monitoring polling interval. Function > - * to be called from governor in response to DEVFREQ_GOV_INTERVAL event. > + * to be called from governor in response to DEVFREQ_GOV_UPDATE_INTERVAL event. > */ > -void devfreq_interval_update(struct devfreq *devfreq, unsigned int *delay) > +void devfreq_update_interval(struct devfreq *devfreq, unsigned int *delay) > { > unsigned int cur_delay = devfreq->profile->polling_ms; > unsigned int new_delay = *delay; > @@ -597,7 +597,7 @@ void devfreq_interval_update(struct devfreq *devfreq, unsigned int *delay) > out: > mutex_unlock(&devfreq->lock); > } > -EXPORT_SYMBOL(devfreq_interval_update); > +EXPORT_SYMBOL(devfreq_update_interval); > > /** > * devfreq_notifier_call() - Notify that the device frequency requirements > @@ -1426,7 +1426,7 @@ static ssize_t polling_interval_store(struct device *dev, > if (ret != 1) > return -EINVAL; > > - df->governor->event_handler(df, DEVFREQ_GOV_INTERVAL, &value); > + df->governor->event_handler(df, DEVFREQ_GOV_UPDATE_INTERVAL, &value); > ret = count; > > return ret; > diff --git a/drivers/devfreq/governor.h b/drivers/devfreq/governor.h > index 5ba3e051b1d0..c07ce77c253d 100644 > --- a/drivers/devfreq/governor.h > +++ b/drivers/devfreq/governor.h > @@ -18,7 +18,7 @@ > /* Devfreq events */ > #define DEVFREQ_GOV_START 0x1 > #define DEVFREQ_GOV_STOP 0x2 > -#define DEVFREQ_GOV_INTERVAL 0x3 > +#define DEVFREQ_GOV_UPDATE_INTERVAL 0x3 > #define DEVFREQ_GOV_SUSPEND 0x4 > #define DEVFREQ_GOV_RESUME 0x5 > > @@ -61,7 +61,7 @@ void devfreq_monitor_start(struct devfreq *devfreq); > void devfreq_monitor_stop(struct devfreq *devfreq); > void devfreq_monitor_suspend(struct devfreq *devfreq); > void devfreq_monitor_resume(struct devfreq *devfreq); > -void devfreq_interval_update(struct devfreq *devfreq, unsigned int *delay); > +void devfreq_update_interval(struct devfreq *devfreq, unsigned int *delay); > > int devfreq_add_governor(struct devfreq_governor *governor); > int devfreq_remove_governor(struct devfreq_governor *governor); > diff --git a/drivers/devfreq/governor_simpleondemand.c b/drivers/devfreq/governor_simpleondemand.c > index 3d809f228619..1b314e1df028 100644 > --- a/drivers/devfreq/governor_simpleondemand.c > +++ b/drivers/devfreq/governor_simpleondemand.c > @@ -96,8 +96,8 @@ static int devfreq_simple_ondemand_handler(struct devfreq *devfreq, > devfreq_monitor_stop(devfreq); > break; > > - case DEVFREQ_GOV_INTERVAL: > - devfreq_interval_update(devfreq, (unsigned int *)data); > + case DEVFREQ_GOV_UPDATE_INTERVAL: > + devfreq_update_interval(devfreq, (unsigned int *)data); > break; > > case DEVFREQ_GOV_SUSPEND: > diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c > index 0b65f89d74d5..28b2c7ca416e 100644 > --- a/drivers/devfreq/tegra30-devfreq.c > +++ b/drivers/devfreq/tegra30-devfreq.c > @@ -734,7 +734,7 @@ static int tegra_governor_event_handler(struct devfreq *devfreq, > devfreq_monitor_stop(devfreq); > break; > > - case DEVFREQ_GOV_INTERVAL: > + case DEVFREQ_GOV_UPDATE_INTERVAL: > /* > * ACTMON hardware supports up to 256 milliseconds for the > * sampling period. > @@ -745,7 +745,7 @@ static int tegra_governor_event_handler(struct devfreq *devfreq, > } > > tegra_actmon_pause(tegra); > - devfreq_interval_update(devfreq, new_delay); > + devfreq_update_interval(devfreq, new_delay); > ret = tegra_actmon_resume(tegra); > break; > > Reviewed-by: Lukasz Luba <lukasz.luba@arm.com> Regards, Lukasz
On 1/29/20 8:28 PM, Lukasz Luba wrote: > Hi Chanwoo, > > Apart from small mistakes in the commit message, looks good to me. > > On 1/29/20 11:20 AM, Chanwoo Choi wrote: >> DEVFREQ_GOV_INTERVAL event indicates that update the interval >> for polling mode of devfreq device. But, this event name doesn't >> specify exactly what to do. >> >> Change DEVFREQ_GOV_INTERVAL event name to DEVFREQ_GOV_UPDATE_INTERVAL >> which specifies what to do by event name. >> >> And modify the functio name for DEVFREQ_GOV_UPDATE_INTERVAL > > s/functio/function I'll fix it. > >> with 'devfreq_' prefix + verb + obejct as following: > > 'obejct'? I'll fix it to 'object'. Thanks for the review. > >> - devfreq_interval_update -> devfreq_updatee_interval >> >> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> >> --- >> drivers/devfreq/devfreq.c | 10 +++++----- >> drivers/devfreq/governor.h | 4 ++-- >> drivers/devfreq/governor_simpleondemand.c | 4 ++-- >> drivers/devfreq/tegra30-devfreq.c | 4 ++-- >> 4 files changed, 11 insertions(+), 11 deletions(-) >> >> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c >> index cceee8bc3c2f..8494c5f05a73 100644 >> --- a/drivers/devfreq/devfreq.c >> +++ b/drivers/devfreq/devfreq.c >> @@ -550,14 +550,14 @@ void devfreq_monitor_resume(struct devfreq *devfreq) >> EXPORT_SYMBOL(devfreq_monitor_resume); >> /** >> - * devfreq_interval_update() - Update device devfreq monitoring interval >> + * devfreq_update_interval() - Update device devfreq monitoring interval >> * @devfreq: the devfreq instance. >> * @delay: new polling interval to be set. >> * >> * Helper function to set new load monitoring polling interval. Function >> - * to be called from governor in response to DEVFREQ_GOV_INTERVAL event. >> + * to be called from governor in response to DEVFREQ_GOV_UPDATE_INTERVAL event. >> */ >> -void devfreq_interval_update(struct devfreq *devfreq, unsigned int *delay) >> +void devfreq_update_interval(struct devfreq *devfreq, unsigned int *delay) >> { >> unsigned int cur_delay = devfreq->profile->polling_ms; >> unsigned int new_delay = *delay; >> @@ -597,7 +597,7 @@ void devfreq_interval_update(struct devfreq *devfreq, unsigned int *delay) >> out: >> mutex_unlock(&devfreq->lock); >> } >> -EXPORT_SYMBOL(devfreq_interval_update); >> +EXPORT_SYMBOL(devfreq_update_interval); >> /** >> * devfreq_notifier_call() - Notify that the device frequency requirements >> @@ -1426,7 +1426,7 @@ static ssize_t polling_interval_store(struct device *dev, >> if (ret != 1) >> return -EINVAL; >> - df->governor->event_handler(df, DEVFREQ_GOV_INTERVAL, &value); >> + df->governor->event_handler(df, DEVFREQ_GOV_UPDATE_INTERVAL, &value); >> ret = count; >> return ret; >> diff --git a/drivers/devfreq/governor.h b/drivers/devfreq/governor.h >> index 5ba3e051b1d0..c07ce77c253d 100644 >> --- a/drivers/devfreq/governor.h >> +++ b/drivers/devfreq/governor.h >> @@ -18,7 +18,7 @@ >> /* Devfreq events */ >> #define DEVFREQ_GOV_START 0x1 >> #define DEVFREQ_GOV_STOP 0x2 >> -#define DEVFREQ_GOV_INTERVAL 0x3 >> +#define DEVFREQ_GOV_UPDATE_INTERVAL 0x3 >> #define DEVFREQ_GOV_SUSPEND 0x4 >> #define DEVFREQ_GOV_RESUME 0x5 >> @@ -61,7 +61,7 @@ void devfreq_monitor_start(struct devfreq *devfreq); >> void devfreq_monitor_stop(struct devfreq *devfreq); >> void devfreq_monitor_suspend(struct devfreq *devfreq); >> void devfreq_monitor_resume(struct devfreq *devfreq); >> -void devfreq_interval_update(struct devfreq *devfreq, unsigned int *delay); >> +void devfreq_update_interval(struct devfreq *devfreq, unsigned int *delay); >> int devfreq_add_governor(struct devfreq_governor *governor); >> int devfreq_remove_governor(struct devfreq_governor *governor); >> diff --git a/drivers/devfreq/governor_simpleondemand.c b/drivers/devfreq/governor_simpleondemand.c >> index 3d809f228619..1b314e1df028 100644 >> --- a/drivers/devfreq/governor_simpleondemand.c >> +++ b/drivers/devfreq/governor_simpleondemand.c >> @@ -96,8 +96,8 @@ static int devfreq_simple_ondemand_handler(struct devfreq *devfreq, >> devfreq_monitor_stop(devfreq); >> break; >> - case DEVFREQ_GOV_INTERVAL: >> - devfreq_interval_update(devfreq, (unsigned int *)data); >> + case DEVFREQ_GOV_UPDATE_INTERVAL: >> + devfreq_update_interval(devfreq, (unsigned int *)data); >> break; >> case DEVFREQ_GOV_SUSPEND: >> diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c >> index 0b65f89d74d5..28b2c7ca416e 100644 >> --- a/drivers/devfreq/tegra30-devfreq.c >> +++ b/drivers/devfreq/tegra30-devfreq.c >> @@ -734,7 +734,7 @@ static int tegra_governor_event_handler(struct devfreq *devfreq, >> devfreq_monitor_stop(devfreq); >> break; >> - case DEVFREQ_GOV_INTERVAL: >> + case DEVFREQ_GOV_UPDATE_INTERVAL: >> /* >> * ACTMON hardware supports up to 256 milliseconds for the >> * sampling period. >> @@ -745,7 +745,7 @@ static int tegra_governor_event_handler(struct devfreq *devfreq, >> } >> tegra_actmon_pause(tegra); >> - devfreq_interval_update(devfreq, new_delay); >> + devfreq_update_interval(devfreq, new_delay); >> ret = tegra_actmon_resume(tegra); >> break; >> > > > Reviewed-by: Lukasz Luba <lukasz.luba@arm.com> > > > Regards, > Lukasz > >
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c index cceee8bc3c2f..8494c5f05a73 100644 --- a/drivers/devfreq/devfreq.c +++ b/drivers/devfreq/devfreq.c @@ -550,14 +550,14 @@ void devfreq_monitor_resume(struct devfreq *devfreq) EXPORT_SYMBOL(devfreq_monitor_resume); /** - * devfreq_interval_update() - Update device devfreq monitoring interval + * devfreq_update_interval() - Update device devfreq monitoring interval * @devfreq: the devfreq instance. * @delay: new polling interval to be set. * * Helper function to set new load monitoring polling interval. Function - * to be called from governor in response to DEVFREQ_GOV_INTERVAL event. + * to be called from governor in response to DEVFREQ_GOV_UPDATE_INTERVAL event. */ -void devfreq_interval_update(struct devfreq *devfreq, unsigned int *delay) +void devfreq_update_interval(struct devfreq *devfreq, unsigned int *delay) { unsigned int cur_delay = devfreq->profile->polling_ms; unsigned int new_delay = *delay; @@ -597,7 +597,7 @@ void devfreq_interval_update(struct devfreq *devfreq, unsigned int *delay) out: mutex_unlock(&devfreq->lock); } -EXPORT_SYMBOL(devfreq_interval_update); +EXPORT_SYMBOL(devfreq_update_interval); /** * devfreq_notifier_call() - Notify that the device frequency requirements @@ -1426,7 +1426,7 @@ static ssize_t polling_interval_store(struct device *dev, if (ret != 1) return -EINVAL; - df->governor->event_handler(df, DEVFREQ_GOV_INTERVAL, &value); + df->governor->event_handler(df, DEVFREQ_GOV_UPDATE_INTERVAL, &value); ret = count; return ret; diff --git a/drivers/devfreq/governor.h b/drivers/devfreq/governor.h index 5ba3e051b1d0..c07ce77c253d 100644 --- a/drivers/devfreq/governor.h +++ b/drivers/devfreq/governor.h @@ -18,7 +18,7 @@ /* Devfreq events */ #define DEVFREQ_GOV_START 0x1 #define DEVFREQ_GOV_STOP 0x2 -#define DEVFREQ_GOV_INTERVAL 0x3 +#define DEVFREQ_GOV_UPDATE_INTERVAL 0x3 #define DEVFREQ_GOV_SUSPEND 0x4 #define DEVFREQ_GOV_RESUME 0x5 @@ -61,7 +61,7 @@ void devfreq_monitor_start(struct devfreq *devfreq); void devfreq_monitor_stop(struct devfreq *devfreq); void devfreq_monitor_suspend(struct devfreq *devfreq); void devfreq_monitor_resume(struct devfreq *devfreq); -void devfreq_interval_update(struct devfreq *devfreq, unsigned int *delay); +void devfreq_update_interval(struct devfreq *devfreq, unsigned int *delay); int devfreq_add_governor(struct devfreq_governor *governor); int devfreq_remove_governor(struct devfreq_governor *governor); diff --git a/drivers/devfreq/governor_simpleondemand.c b/drivers/devfreq/governor_simpleondemand.c index 3d809f228619..1b314e1df028 100644 --- a/drivers/devfreq/governor_simpleondemand.c +++ b/drivers/devfreq/governor_simpleondemand.c @@ -96,8 +96,8 @@ static int devfreq_simple_ondemand_handler(struct devfreq *devfreq, devfreq_monitor_stop(devfreq); break; - case DEVFREQ_GOV_INTERVAL: - devfreq_interval_update(devfreq, (unsigned int *)data); + case DEVFREQ_GOV_UPDATE_INTERVAL: + devfreq_update_interval(devfreq, (unsigned int *)data); break; case DEVFREQ_GOV_SUSPEND: diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c index 0b65f89d74d5..28b2c7ca416e 100644 --- a/drivers/devfreq/tegra30-devfreq.c +++ b/drivers/devfreq/tegra30-devfreq.c @@ -734,7 +734,7 @@ static int tegra_governor_event_handler(struct devfreq *devfreq, devfreq_monitor_stop(devfreq); break; - case DEVFREQ_GOV_INTERVAL: + case DEVFREQ_GOV_UPDATE_INTERVAL: /* * ACTMON hardware supports up to 256 milliseconds for the * sampling period. @@ -745,7 +745,7 @@ static int tegra_governor_event_handler(struct devfreq *devfreq, } tegra_actmon_pause(tegra); - devfreq_interval_update(devfreq, new_delay); + devfreq_update_interval(devfreq, new_delay); ret = tegra_actmon_resume(tegra); break;
DEVFREQ_GOV_INTERVAL event indicates that update the interval for polling mode of devfreq device. But, this event name doesn't specify exactly what to do. Change DEVFREQ_GOV_INTERVAL event name to DEVFREQ_GOV_UPDATE_INTERVAL which specifies what to do by event name. And modify the functio name for DEVFREQ_GOV_UPDATE_INTERVAL with 'devfreq_' prefix + verb + obejct as following: - devfreq_interval_update -> devfreq_updatee_interval Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> --- drivers/devfreq/devfreq.c | 10 +++++----- drivers/devfreq/governor.h | 4 ++-- drivers/devfreq/governor_simpleondemand.c | 4 ++-- drivers/devfreq/tegra30-devfreq.c | 4 ++-- 4 files changed, 11 insertions(+), 11 deletions(-)