diff mbox series

[1/1] power: supply: bq24190_charger: convert to use i2c_new_client_device()

Message ID 20200326210954.12931-2-wsa+renesas@sang-engineering.com (mailing list archive)
State Not Applicable, archived
Headers show
Series power: convert to use new I2C API | expand

Commit Message

Wolfram Sang March 26, 2020, 9:09 p.m. UTC
Move away from the deprecated API in this comment.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/power/supply/bq24190_charger.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Wolfram Sang May 12, 2020, 4:27 p.m. UTC | #1
On Thu, Mar 26, 2020 at 10:09:54PM +0100, Wolfram Sang wrote:
> Move away from the deprecated API in this comment.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Can we have this now so I can remove the old API in the next merge
window?

> ---
>  drivers/power/supply/bq24190_charger.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c
> index 453d6332d43a..4540e913057f 100644
> --- a/drivers/power/supply/bq24190_charger.c
> +++ b/drivers/power/supply/bq24190_charger.c
> @@ -673,7 +673,7 @@ static int bq24190_register_reset(struct bq24190_dev_info *bdi)
>  	 *   { .type = "bq24190", .addr = 0x6b, .properties = pe, .irq = irq };
>  	 * struct i2c_adapter ad = { ... };
>  	 * i2c_add_adapter(&ad);
> -	 * i2c_new_device(&ad, &bi);
> +	 * i2c_new_client_device(&ad, &bi);
>  	 */
>  	if (device_property_read_bool(bdi->dev, "disable-reset"))
>  		return 0;
> -- 
> 2.20.1
>
Sebastian Reichel May 12, 2020, 5:10 p.m. UTC | #2
Hi Wolfram,

On Tue, May 12, 2020 at 06:27:23PM +0200, Wolfram Sang wrote:
> On Thu, Mar 26, 2020 at 10:09:54PM +0100, Wolfram Sang wrote:
> > Move away from the deprecated API in this comment.
> > 
> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> 
> Can we have this now so I can remove the old API in the next merge
> window?

Thanks for the ping. The patch is now queued into power-supply's
for-next branch.

-- Sebastian

> > ---
> >  drivers/power/supply/bq24190_charger.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c
> > index 453d6332d43a..4540e913057f 100644
> > --- a/drivers/power/supply/bq24190_charger.c
> > +++ b/drivers/power/supply/bq24190_charger.c
> > @@ -673,7 +673,7 @@ static int bq24190_register_reset(struct bq24190_dev_info *bdi)
> >  	 *   { .type = "bq24190", .addr = 0x6b, .properties = pe, .irq = irq };
> >  	 * struct i2c_adapter ad = { ... };
> >  	 * i2c_add_adapter(&ad);
> > -	 * i2c_new_device(&ad, &bi);
> > +	 * i2c_new_client_device(&ad, &bi);
> >  	 */
> >  	if (device_property_read_bool(bdi->dev, "disable-reset"))
> >  		return 0;
> > -- 
> > 2.20.1
> >
diff mbox series

Patch

diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c
index 453d6332d43a..4540e913057f 100644
--- a/drivers/power/supply/bq24190_charger.c
+++ b/drivers/power/supply/bq24190_charger.c
@@ -673,7 +673,7 @@  static int bq24190_register_reset(struct bq24190_dev_info *bdi)
 	 *   { .type = "bq24190", .addr = 0x6b, .properties = pe, .irq = irq };
 	 * struct i2c_adapter ad = { ... };
 	 * i2c_add_adapter(&ad);
-	 * i2c_new_device(&ad, &bi);
+	 * i2c_new_client_device(&ad, &bi);
 	 */
 	if (device_property_read_bool(bdi->dev, "disable-reset"))
 		return 0;